Re: RFR: JDK-8225056 VM support for sealed classes

2020-05-24 Thread David Holmes
Hi Harold, On 22/05/2020 4:33 am, Harold Seigel wrote: Hi David, Thanks for looking at this!  Please review this new webrev: http://cr.openjdk.java.net/~hseigel/webrev.01/webrev/ I'll list all relevant commens here rather than interspersing below so that it is easier to track. Mostly

Re: RFR: 8244993: Revert changes to OutputAnalyzer stderrShouldBeEmptyIgnoreVMWarnings() that allow version strings

2020-05-24 Thread David Holmes
On 24/05/2020 3:06 am, Chris Plummer wrote: On 5/23/20 6:03 AM, David Holmes wrote: Hi Chris, On 23/05/2020 4:50 am, Chris Plummer wrote: Hi Daniil, There is one reference to "jvmwarningmsg" that occurs before it is declared while all the rest all come after. It probably would make sense