Re: RFR(XS): 8234882: JVM TI StopThread should only allow ThreadDeath

2020-05-31 Thread serguei.spit...@oracle.com
Hi David, Also jumping to end. On 5/30/20 06:50, David Holmes wrote: Hi Serguei, Jumping to the end for now ... On 30/05/2020 5:50 am, serguei.spit...@oracle.com wrote: Hi David and reviewers, The updated webrev version is: http://cr.openjdk.java.net/~sspitsyn/webrevs/2020/jvmti-stop-thread

RFR(XS): 8221306: JVMTI spec for FramePop(), MethodExit(), and MethodEnter() could use some cleanup

2020-05-31 Thread serguei.spit...@oracle.com
Please, review a fix for small spec bug:   https://bugs.openjdk.java.net/browse/JDK-8221306 Webrev:   http://cr.openjdk.java.net/~sspitsyn/webrevs/2020/jvmt-funcs-cleanup.1/src/ Updated JVM TI spec for the FramePop, MethodEntry and MethodExit events:

Re: RFR: JDK-8225056 VM support for sealed classes

2020-05-31 Thread Harold Seigel
Thanks for the comments. Here's version 3 of the JDK and VM changes for sealed classes. full webrev: http://cr.openjdk.java.net/~hseigel/sealedClasses.8225056.3/webrev/ The new webrev contains just the following three changes: 1. The sealed classes API's in Class.java (permittedSubclasses()

Re: RFR: JDK-8225056 VM support for sealed classes

2020-05-31 Thread David Holmes
Hi Harold, On 1/06/2020 8:57 am, Harold Seigel wrote: Thanks for the comments. Here's version 3 of the JDK and VM changes for sealed classes. full webrev: http://cr.openjdk.java.net/~hseigel/sealedClasses.8225056.3/webrev/ The new webrev contains just the following three changes: 1. The s

Re: RFR JDK-8232222: Set state to 'linked' when an archived class is restored at runtime

2020-05-31 Thread David Holmes
Hi Jiangli, On 29/05/2020 9:02 am, Jiangli Zhou wrote: (Looping in serviceability-dev@openjdk.java.net ...) Hi David and Ioi, On Wed, May 27, 2020 at 11:15 PM David Holmes wrote: Hi Jiangli, On 28/05/2020 11:35 am, Ioi Lam wrote: On 5/27/20 6:17 PM, Jiangli Zhou wrote: On Wed, May 27,

Re: RFR(XS): 8245126 Kitchensink fails with: assert(!method->is_old()) failed: Should not be installing old methods

2020-05-31 Thread serguei.spit...@oracle.com
Hi Dean, To check the is_old as you suggest the target method has to be passed to the cache_jvmti_state() as argument. Is it what you are suggesting? Just want to make sure I understand you correctly. The cache_jvmti_state() and cache_dtr

Re: RFR(XS): 8245126 Kitchensink fails with: assert(!method->is_old()) failed: Should not be installing old methods

2020-05-31 Thread serguei.spit...@oracle.com
On 5/31/20 23:16, serguei.spit...@oracle.com wrote: Hi Dean, To check the is_old as you suggest the target method has to be passed to the cache_jvmti_state() as argument. Is it what you are suggesting? Just want to ma