Re: RFR: [15,docs] JDK-8247958,minor HTML errors in com.sun.jdi

2020-06-19 Thread David Holmes
Looks good. Thanks, David On 20/06/2020 1:08 pm, Jonathan Gibbons wrote: Please review a couple of minor HTML errors (missing end tags) in a couple of classes.  These should be the last of the fixes for com.sun.jdi in this round of cleanup. -- Jon JBS: https://bugs.openjdk.java.net/browse/J

RFR: [15,docs] JDK-8247958,minor HTML errors in com.sun.jdi

2020-06-19 Thread Jonathan Gibbons
Please review a couple of minor HTML errors (missing end tags) in a couple of classes.  These should be the last of the fixes for com.sun.jdi in this round of cleanup. -- Jon JBS: https://bugs.openjdk.java.net/browse/JDK-8247958 Patch inline: diff -r 086c7f077fc6 src/jdk.jdi/share/classes/c

Re: RFR(S): 8247533: SA stack walking sometimes fails with sun.jvm.hotspot.debugger.DebuggerException: get_thread_regs failed for a lwp

2020-06-19 Thread Yasumasa Suenaga
Hi Chris, I checked Linux kernel code at a glance, ESRCH seems to be set to errno by default. So I guess it is similar to "generic" error code. https://github.com/torvalds/linux/blob/master/kernel/ptrace.c According to manpage of ptrace(2), it might return errno other than ESRCH. For example,

Re: RFR(S): 8247533: SA stack walking sometimes fails with sun.jvm.hotspot.debugger.DebuggerException: get_thread_regs failed for a lwp

2020-06-19 Thread Chris Plummer
Hello, I've  updated with webrev based on the new finding that a JavaThread cannot be on the ThreadList after its OS thread has been destroyed since the JavaThread removes itself from the ThreadList, and therefore must be running on its OS thread. The logic of the fix is unchanged from the fi

Re: RFR: JDK-8247784,Bad link causes invalid documentation

2020-06-19 Thread Mandy Chung
+1.  Thanks for fixing this. Mandy On 6/18/20 8:16 PM, Jonathan Gibbons wrote: resend, with correct subject line On 6/18/20 8:12 PM, Jonathan Gibbons wrote: Please review some changes to fix typos in some recent doc updates. In two places, ${docRoot} is used instead of {@docRoot} -- Jon

Re: RFR(S): 8247533: SA stack walking sometimes fails with sun.jvm.hotspot.debugger.DebuggerException: get_thread_regs failed for a lwp

2020-06-19 Thread David Holmes
Hi Chris, On 19/06/2020 8:55 am, Chris Plummer wrote: On 6/18/20 1:43 AM, David Holmes wrote: On 18/06/2020 4:49 pm, Chris Plummer wrote: On 6/17/20 10:29 PM, David Holmes wrote: On 18/06/2020 3:13 pm, Chris Plummer wrote: On 6/17/20 10:09 PM, David Holmes wrote: On 18/06/2020 2:33 pm, Chri

Re: RFR: https://bugs.openjdk.java.net/browse/JDK-8247784

2020-06-19 Thread David Holmes
Looks good and trivial. Thanks, David On 19/06/2020 1:12 pm, Jonathan Gibbons wrote: Please review some changes to fix typos in some recent doc updates. In two places, ${docRoot} is used instead of {@docRoot} -- Jon JBS: https://bugs.openjdk.java.net/browse/JDK-8247784 Patch: diff -r c5904