Re: RFR: [15,docs] JDK-8248061,bad reference in @throws in HotSpotDiagnosticMXBean

2020-06-22 Thread Mandy Chung
+1 Mandy On 6/22/20 4:55 PM, Jonathan Gibbons wrote: Please review a small change to fix an unresolved reference in `@throws IOException`. The problem is that the method signature uses a fully-qualified name for `java.io.IOException` instead of importing it. meaning that the `@throws` can

Re: RFR: [15,docs] JDK-8248061,bad reference in @throws in HotSpotDiagnosticMXBean

2020-06-22 Thread serguei.spit...@oracle.com
+1 Thanks, Serguei On 6/22/20 19:32, Daniel D. Daugherty wrote: On 6/22/20 7:55 PM, Jonathan Gibbons wrote: Please review a small change to fix an unresolved reference in `@throws IOException`.  

Re: RFR: [15,docs] JDK-8248061,bad reference in @throws in HotSpotDiagnosticMXBean

2020-06-22 Thread Daniel D. Daugherty
On 6/22/20 7:55 PM, Jonathan Gibbons wrote: Please review a small change to fix an unresolved reference in `@throws IOException`. Thumbs up. Dan The problem is that the method signature uses a fully-qualified name for `java.io.IOException` instead of importing it. meaning that the `@th

RFR: [15,docs] JDK-8248061,bad reference in @throws in HotSpotDiagnosticMXBean

2020-06-22 Thread Jonathan Gibbons
Please review a small change to fix an unresolved reference in `@throws IOException`. The problem is that the method signature uses a fully-qualified name for `java.io.IOException` instead of importing it. meaning that the `@throws` cannot resolve the name. Although this could be fixed by usin

RE: RFR (S): 8245129: Enhance jstat gc option output and tests

2020-06-22 Thread Hohensee, Paul
Thanks very much for review, Volker. I'll file a follow-up issue. One more reviewer, please? :) Paul On 6/22/20, 8:10 AM, "serviceability-dev on behalf of Volker Simonis" wrote: Hi Paul, thanks for fixing jstat for larger heaps. I like that you've added explicit tests for Parall

Re: RFR (S): 8245129: Enhance jstat gc option output and tests

2020-06-22 Thread Volker Simonis
Hi Paul, thanks for fixing jstat for larger heaps. I like that you've added explicit tests for ParallelGC which hasn't been tested since G1 was made the default collector. I also agree that sizes should all be right justified. I only wonder if the header of a right justified column shouldn't be r