Hi Dan, David,
I uploaded new webrev. Could you review again?
http://cr.openjdk.java.net/~ysuenaga/JDK-8242428/webrev.04/
OneGetThreadListStackTraces.java in this webrev would wait until thread state is
transited to "waiting" with spin wait.
CountDownLatch::await call as Dan pointed is fixed
I can do that.
Chris
On 7/2/20 10:40 PM, Igor Ignatyev wrote:
Hi Chris,
looks good and trivial. would you consider pushing it into jdk/jdk15?
-- Igor
On Jul 2, 2020, at 10:36 PM, Chris Plummer wrote:
Hello,
Please review the following trivial change:
https://bugs.openjdk.java.net/browse
Hi Chris,
looks good and trivial. would you consider pushing it into jdk/jdk15?
-- Igor
> On Jul 2, 2020, at 10:36 PM, Chris Plummer wrote:
>
> Hello,
>
> Please review the following trivial change:
>
> https://bugs.openjdk.java.net/browse/JDK-8248746
>
> diff --git a/test/jdk/TEST.ROOT b/t
Hello,
Please review the following trivial change:
https://bugs.openjdk.java.net/browse/JDK-8248746
diff --git a/test/jdk/TEST.ROOT b/test/jdk/TEST.ROOT
--- a/test/jdk/TEST.ROOT
+++ b/test/jdk/TEST.ROOT
@@ -24,7 +24,7 @@
# Tests that cannot run concurrently
exclusiveAccess.dirs=java/math/BigI
On 3/07/2020 2:27 pm, Yasumasa Suenaga wrote:
On 2020/07/03 12:24, Daniel D. Daugherty wrote:
On 7/2/20 10:50 PM, David Holmes wrote:
Sorry I'm responding here without seeing latest webrev but there is
enough context I think ...
On 3/07/2020 9:14 am, Yasumasa Suenaga wrote:
Hi Dan,
Thank
On 3/07/2020 1:24 pm, Daniel D. Daugherty wrote:
On 7/2/20 10:50 PM, David Holmes wrote:
Sorry I'm responding here without seeing latest webrev but there is
enough context I think ...
On 3/07/2020 9:14 am, Yasumasa Suenaga wrote:
Hi Dan,
Thanks for your comment!
On 2020/07/03 7:16, Daniel D
Hi Igor,
On 3/07/2020 12:59 pm, Igor Ignatyev wrote:
Hi David,
it's in my todo list to improve this situation and have vm.gc.X to take selected JIT
into account; and update existing (>200) occurrences of 'vm.gc.X &
!vm.graal.enabled'
200+ ouch! :(
I guess this fix doesn't make the situatio
On 2020/07/03 12:24, Daniel D. Daugherty wrote:
On 7/2/20 10:50 PM, David Holmes wrote:
Sorry I'm responding here without seeing latest webrev but there is enough
context I think ...
On 3/07/2020 9:14 am, Yasumasa Suenaga wrote:
Hi Dan,
Thanks for your comment!
On 2020/07/03 7:16, Daniel D.
On 7/2/20 10:50 PM, David Holmes wrote:
Sorry I'm responding here without seeing latest webrev but there is
enough context I think ...
On 3/07/2020 9:14 am, Yasumasa Suenaga wrote:
Hi Dan,
Thanks for your comment!
On 2020/07/03 7:16, Daniel D. Daugherty wrote:
On 7/2/20 5:19 AM, Yasumasa Su
Hi David,
it's in my todo list to improve this situation and have vm.gc.X to take
selected JIT into account; and update existing (>200) occurrences of 'vm.gc.X &
!vm.graal.enabled'
-- Igor
> On Jul 2, 2020, at 7:25 PM, David Holmes wrote:
>
> Hi Vladimir,
>
> On 3/07/2020 12:02 pm, Vladimi
Sorry I'm responding here without seeing latest webrev but there is
enough context I think ...
On 3/07/2020 9:14 am, Yasumasa Suenaga wrote:
Hi Dan,
Thanks for your comment!
On 2020/07/03 7:16, Daniel D. Daugherty wrote:
On 7/2/20 5:19 AM, Yasumasa Suenaga wrote:
Hi David,
I upload new web
LGTM
— Igor
> On Jul 2, 2020, at 7:03 PM, Vladimir Kozlov
> wrote:
>
> https://cr.openjdk.java.net/~kvn/8247527/webrev.00/
> https://bugs.openjdk.java.net/browse/JDK-8247527
>
> Test should have @requires which excludes running Graal with GC which it does
> not support.
>
> Testing: hs-tie
Hi Vladimir,
On 3/07/2020 12:02 pm, Vladimir Kozlov wrote:
https://cr.openjdk.java.net/~kvn/8247527/webrev.00/
https://bugs.openjdk.java.net/browse/JDK-8247527
Test should have @requires which excludes running Graal with GC which it
does not support.
I find it somewhat disturbing that a gene
https://cr.openjdk.java.net/~kvn/8247527/webrev.00/
https://bugs.openjdk.java.net/browse/JDK-8247527
Test should have @requires which excludes running Graal with GC which it does
not support.
Testing: hs-tier1,hs-tier4-graal
Thanks,
Vladimir
On 7/2/20 7:14 PM, Yasumasa Suenaga wrote:
Hi Dan,
Thanks for your comment!
On 2020/07/03 7:16, Daniel D. Daugherty wrote:
On 7/2/20 5:19 AM, Yasumasa Suenaga wrote:
Hi David,
I upload new webrev. Could you review again?
http://cr.openjdk.java.net/~ysuenaga/JDK-8242428/webrev.03/
src/hots
Hi Dan,
Thanks for your comment!
On 2020/07/03 7:16, Daniel D. Daugherty wrote:
On 7/2/20 5:19 AM, Yasumasa Suenaga wrote:
Hi David,
I upload new webrev. Could you review again?
http://cr.openjdk.java.net/~ysuenaga/JDK-8242428/webrev.03/
src/hotspot/share/prims/jvmtiEnv.cpp
L1542:
On 7/2/20 5:19 AM, Yasumasa Suenaga wrote:
Hi David,
I upload new webrev. Could you review again?
http://cr.openjdk.java.net/~ysuenaga/JDK-8242428/webrev.03/
src/hotspot/share/prims/jvmtiEnv.cpp
L1542: // Get stack trace with handshake
nit - please add a period at the end.
[Note, the following changes only impact serviceability tests, but I am
adding some test library code to assist with creating and finding core
files, and I thought others on hotspot-dev might have an interest in that.]
Hello,
Please help review the following changes to add better support for
Hi David,
I upload new webrev. Could you review again?
http://cr.openjdk.java.net/~ysuenaga/JDK-8242428/webrev.03/
On 2020/07/02 15:05, David Holmes wrote:
Hi Yasumasa,
On 1/07/2020 11:53 am, Yasumasa Suenaga wrote:
Hi,
I uploaded new webrev. Could review again?
http://cr.openjdk.java
19 matches
Mail list logo
