Re: RFR: 8242428: JVMTI thread operations should use Thread-Local Handshake

Hi Serguei, I'm not an Oracle employee, so I cannot know real request(s) from your customers. However JDK-8201641 says Dynatrace has requested this enhancement. BTW I haven't heared any request from my customers about this. Thanks, Yasumasa On 2020/07/04 4:32, serguei.spit...@oracle.com

Re: [15] RFR(T) 8247527: serviceability/dcmd/gc/HeapDumpCompressedTest.java fails with Graal + ZGC

Thank you, David Vladimir K On 7/3/20 3:18 PM, David Holmes wrote: On 4/07/2020 4:30 am, Vladimir Kozlov wrote: Thank you, David, for looking on changes. I will remember to update tests. I filed RFE 8248815 [1] for tracking. Can you approve this fix now? Yes - thanks. David Thanks,

Re: [15] RFR(T) 8247527: serviceability/dcmd/gc/HeapDumpCompressedTest.java fails with Graal + ZGC

On 4/07/2020 4:30 am, Vladimir Kozlov wrote: Thank you, David, for looking on changes. I will remember to update tests. I filed RFE 8248815 [1] for tracking. Can you approve this fix now? Yes - thanks. David Thanks, Vladimir K [1] https://bugs.openjdk.java.net/browse/JDK-8248815 On

Re: RFR: 8242428: JVMTI thread operations should use Thread-Local Handshake

Hi Yasumasa, This difference is not that big to care about. I feel this is really rare case and so, does not worth these complications. Do we have a real request from customers to optimize it? Thanks, Serguei On 7/3/20 01:16, Yasumasa Suenaga wrote: Hi Serguei, Generally I agree with you,

Re: [15] RFR(T) 8247527: serviceability/dcmd/gc/HeapDumpCompressedTest.java fails with Graal + ZGC

Thank you, David, for looking on changes. I will remember to update tests. I filed RFE 8248815 [1] for tracking. Can you approve this fix now? Thanks, Vladimir K [1] https://bugs.openjdk.java.net/browse/JDK-8248815 On 7/2/20 10:09 PM, David Holmes wrote: Hi Igor, On 3/07/2020 12:59 pm,

Re: [15] RFR(T) 8247527: serviceability/dcmd/gc/HeapDumpCompressedTest.java fails with Graal + ZGC

Thank you, Igor Vladimir K On 7/2/20 7:24 PM, igor.ignat...@oracle.com wrote: LGTM — Igor On Jul 2, 2020, at 7:03 PM, Vladimir Kozlov wrote: https://cr.openjdk.java.net/~kvn/8247527/webrev.00/ https://bugs.openjdk.java.net/browse/JDK-8247527 Test should have @requires which excludes

Re: RFR: 8242428: JVMTI thread operations should use Thread-Local Handshake

Hi Serguei, Generally I agree with you, but I have concern about the difference of the result of GetStackTrace() and GetThreadListStackTraces(). GetStackTrace: jvmtiFrameInfo GetThreadListStackTraces: jvmtiStackInfo jvmtiStackInfo contains thread state, and it is ensured it is the state

Re: RFR: 8242428: JVMTI thread operations should use Thread-Local Handshake

Hi Dan, David, I uploaded new webrev. Could you review again? http://cr.openjdk.java.net/~ysuenaga/JDK-8242428/webrev.04/ OneGetThreadListStackTraces.java in this webrev would wait until thread state is transited to "waiting" with spin wait. CountDownLatch::await call as Dan pointed is

Re: RFR(T): 8248746: Undo jhsdb related exclusiveAccess.dirs changes that were done for JDK-8220295

I can do that. Chris On 7/2/20 10:40 PM, Igor Ignatyev wrote: Hi Chris, looks good and trivial. would you consider pushing it into jdk/jdk15? -- Igor On Jul 2, 2020, at 10:36 PM, Chris Plummer wrote: Hello, Please review the following trivial change: