Re: RFR(L): 8215624: add parallel heap inspection support for jmap histo(G1)(Internet mail)

2020-07-09 Thread 臧琳
Hi Paul, Thanks for reviewing! >> >> I'd move all the argument parsing code to JMap.java and just pass the results to Hotspot. Both histo() in JMap.java and code in attachListener.* parse the command line arguments, though the code in histo() doesn't parse the argument to "para

Re: RFR: 8242428: JVMTI thread operations should use Thread-Local Handshake

2020-07-09 Thread David Holmes
Hi Yasumasa, On 9/07/2020 10:25 am, Yasumasa Suenaga wrote: Hi Dan, Thanks for your comment! I uploaded new webrev:   http://cr.openjdk.java.net/~ysuenaga/JDK-8242428/webrev.09/   Diff from previous webrev: http://hg.openjdk.java.net/jdk/submit/rev/5d167adf8524 I saw similar build errors

Re: RFR: 8242428: JVMTI thread operations should use Thread-Local Handshake

2020-07-09 Thread Yasumasa Suenaga
%p to %lx, and also cast values to unsigned long [1] [2], but the test on submit repo was failed. Can anyone share details of mach5-one-ysuenaga-JDK-8242428-20200709-1030-12500928 ? Thanks, Yasumasa [1] http://hg.openjdk.java.net/jdk/submit/rev/dfca51958217 [2] http://hg.openjdk.java.net/jdk/

Some clarification about JVMTI_EVENT_THREAD_START and PRIMORDIAL phase

2020-07-09 Thread Jaroslav Bachorík
Hello, Recently, after backporting JDK-8233197 to JDK8u I received a report from Sergey Nazarkin (cc) that the backport broke JVMTI spec basically emitting JVMTI_EVENT_THREAD_START events in primordial phase while the spec states that it should be emitted only in either start or live phase. But i

Re: RFR (S) 8249137: Remove CollectedHeap::obj_size

2020-07-09 Thread Daniel D. Daugherty
Adding serviceability-dev@... since a couple of JVM/TI files are changed in this RFR. Also, I moved the bug from hotspot/runtime -> hotspot/gc. Dan On 7/9/20 2:36 AM, Aleksey Shipilev wrote: RFE: https://bugs.openjdk.java.net/browse/JDK-8249137 It was added by JDK-8211270 to support old-st

Re: RFR: 8242428: JVMTI thread operations should use Thread-Local Handshake

2020-07-09 Thread Patricio Chilano
don't know what exists in the testing code. I replaced %p to %lx, and also cast values to unsigned long [1] [2], but the test on submit repo was failed. Can anyone share details of mach5-one-ysuenaga-JDK-8242428-20200709-1030-12500928 ? These are the errors I see for the macOS build: .

Re: Some clarification about JVMTI_EVENT_THREAD_START and PRIMORDIAL phase

2020-07-09 Thread Daniel D. Daugherty
On 7/9/20 9:07 AM, Jaroslav Bachorík wrote: Hello, Recently, after backporting JDK-8233197 to JDK8u I received a report from Sergey Nazarkin (cc) that the backport broke JVMTI spec basically emitting JVMTI_EVENT_THREAD_START events in primordial phase while the spec states that it should be emit

Re: RFR: 8242428: JVMTI thread operations should use Thread-Local Handshake

2020-07-09 Thread Patricio Chilano
e use INTPTR_FORMAT and convert the arg using p2i. I don't know what exists in the testing code. I replaced %p to %lx, and also cast values to unsigned long [1] [2], but the test on submit repo was failed. Can anyone share details of mach5-one-ysuenaga-JDK-8242428-20200709-1030-12500928 ? These are

Re: RFR: 8242428: JVMTI thread operations should use Thread-Local Handshake

2020-07-09 Thread Yasumasa Suenaga
x27;t know what exists in the testing code. I replaced %p to %lx, and also cast values to unsigned long [1] [2], but the test on submit repo was failed. Can anyone share details of mach5-one-ysuenaga-JDK-8242428-20200709-1030-12500928 ? These are the errors I see for the macOS build: ./open/tes

Re: RFR: 8242428: JVMTI thread operations should use Thread-Local Handshake

2020-07-09 Thread Patricio Chilano
, and also cast values to unsigned long [1] [2], but the test on submit repo was failed. Can anyone share details of mach5-one-ysuenaga-JDK-8242428-20200709-1030-12500928 ? These are the errors I see for the macOS build: ./open/test/hotspot/jtreg/serviceability/jvmti/GetThread