Re: RFR: 8242428: JVMTI thread operations should use Thread-Local Handshake

2020-07-10 Thread Yasumasa Suenaga
58 AM, Yasumasa Suenaga wrote: Hi Patricio, Thanks for your advice! I've fixed testcase as [1], but I still see an error in validate-headers-linux-x64-build-1 on submit repo. What does it mean? Can you share details?   mach5-one-ysuenaga-JDK-8242428-20200710-0339-12529134 Not your bug, you a

Re: RFR: 8242428: JVMTI thread operations should use Thread-Local Handshake

2020-07-10 Thread serguei.spit...@oracle.com
d testcase as [1], but I still see an error in validate-headers-linux-x64-build-1 on submit repo. What does it mean? Can you share details?   mach5-one-ysuenaga-JDK-8242428-20200710-0339-12529134 Not your bug, you are getting the header validation failure from 8248570. It was fixed two days a

RE: RFR(s): 8236042: [TESTBUG] serviceability/sa/ClhsdbCDSCore.java fails with -Xcomp -XX:TieredStopAtLevel=1

2020-07-10 Thread Fairoz Matte
Thanks Vladimir for the review. Thanks for mentioning the reasons for MDO's not being generated, I have added them as comment in bug for future reference. Thanks, Fairoz > -Original Message- > From: Vladimir Kozlov > Sent: Saturday, July 11, 2020 5:36 AM > To: Fairoz Matte ; Chris Plumm

Re: RFR: 8242428: JVMTI thread operations should use Thread-Local Handshake

2020-07-10 Thread Yasumasa Suenaga
es it mean? Can you share details?   mach5-one-ysuenaga-JDK-8242428-20200710-0339-12529134 Not your bug, you are getting the header validation failure from 8248570. It was fixed two days ago so just update the repo and it should work now. Thanks, Patricio Of course this change can be built on my

Re: RFR(s): 8236042: [TESTBUG] serviceability/sa/ClhsdbCDSCore.java fails with -Xcomp -XX:TieredStopAtLevel=1

2020-07-10 Thread Vladimir Kozlov
Fix is good. I think next are reasons you don't get MDO in this scenario. Tier1 (C1 compilation) does not generate profiling code and does not created MDO. C1 request MDO only with tiers 2 and 3 [1][2]. With -Xcomp flag a Java method is not executed in Interpreter but requests its compilation

Re: RFR: 8242428: JVMTI thread operations should use Thread-Local Handshake

2020-07-10 Thread Daniel D. Daugherty
, Yasumasa Suenaga wrote: Hi Patricio, Thanks for your advice! I've fixed testcase as [1], but I still see an error in validate-headers-linux-x64-build-1 on submit repo. What does it mean? Can you share details?   mach5-one-ysuenaga-JDK-8242428-20200710-0339-12529134 Not your bug, you are gettin

Re: RFR (S) 8249137: Remove CollectedHeap::obj_size

2020-07-10 Thread Daniel D. Daugherty
On 7/10/20 4:37 AM, Aleksey Shipilev wrote: Okay, thanks. I already have 2 reviewers (rkennke, tschatzl), do I need more specifically from serviceability-dev@? Since you're touching the Serviceability team's code, it would be polite to wait for a review... Dan -Aleksey On 7/9/20 3:34 PM

Re: RFR (S) 8249137: Remove CollectedHeap::obj_size

2020-07-10 Thread Aleksey Shipilev
Okay, thanks. I already have 2 reviewers (rkennke, tschatzl), do I need more specifically from serviceability-dev@? -Aleksey On 7/9/20 3:34 PM, Daniel D. Daugherty wrote: > Adding serviceability-dev@... since a couple of JVM/TI files are changed > in this RFR. Also, I moved the bug from hotspot

Re: RFR: 8242428: JVMTI thread operations should use Thread-Local Handshake

2020-07-10 Thread Yasumasa Suenaga
share details?   mach5-one-ysuenaga-JDK-8242428-20200710-0339-12529134 Not your bug, you are getting the header validation failure from 8248570. It was fixed two days ago so just update the repo and it should work now. Thanks, Patricio Of course this change can be built on my Linux box (Fedora 32,