Hi Yasumasa,
The fix looks good to me.
Thanks to Chris for discussing the details in previous emails.
Just one suggestion:
http://cr.openjdk.java.net/~ysuenaga/JDK-8250826/webrev.02/src/jdk.hotspot.agent/share/native/libsaproc/ps_core_common.c.frame
Hi Lin,
Some small nits:
Could you go over the patch and move both declaration and definition of
the newly added heap functions, so that their location match the one
chosen in collectedHeap.hpp? And that the locations is consistent
between the hpp and cpp files?
https://cr.openjdk.java.net
Hi Serguei,
Thanks for your comment!
On 2020/08/04 18:11, serguei.spit...@oracle.com wrote:
Hi Yasumasa,
The fix looks good to me.
Thanks to Chris for discussing the details in previous emails.
Just one suggestion:
http://cr.openjdk.java.net/~ysuenaga/JDK-8250826/webrev.02/src/jdk.hotspot.ag
Hi, Stefan,
I suggested changing the missed_count type because it's a count, not a size. It
didn’t seem to me that 32 bits would overflow, but if that's a concern, then
using uint64_t would make the size explicit.
Thanks,
Paul
On 8/4/20, 5:13 AM, "Stefan Karlsson" wrote:
Hi Lin,
So
Forward it to serviceability-dev since this issue in the JBS has been moved
from hotspot/runtime to core-svc/java.lang.management.
Please review it.
Thanks.
Best regards,
Jie
From: "jiefu(傅杰)"
Date: Tuesday, August 4, 2020 at 5:10 PM
To: "hotspot-runtime-...@openjdk.java.net"
Subject: RFR:
Hi Yasumasa,
It looks good.
I forgot to say there is no need in new webrev.
Thanks,
Serguei
On 8/4/20 05:22, Yasumasa Suenaga wrote:
Hi Serguei,
Thanks for your comment!
On 2020/08/04 18:11, serguei.spit...@oracle.com wrote:
Hi Yasumasa,
The fix looks good to me.
Thanks to Chris for discu
Hi Chris,
LGTM++
Thanks,
Serguei
On 8/3/20 22:10, Yasumasa Suenaga wrote:
Hi Chris,
Looks good.
Yasumasa
On 2020/08/04 13:10, Chris Plummer wrote:
Ping!
On 7/27/20 10:04 PM, Chris Plummer wrote:
I should have mentioned that currently there is no testing of this
code. There will with th
On 8/4/20 2:11 AM,
serguei.spit...@oracle.com wrote:
Hi Yasumasa,
The fix looks good to me.
Thanks to Chris for discussing the details in previous emails.
Just one suggestion:
http://cr.openjdk.java.n
Hi Jie,
The fix appears to directly address the issue of allowing a hostname to
start with a digit. I'm still not convinced that the check will properly
validate the hostname in all cases, but maybe that's a fix for another day:
https://stackoverflow.com/questions/1418423/the-hostname-regex
Thanks Serguei and Yasumasa!
On 8/4/20 9:38 AM, serguei.spit...@oracle.com wrote:
Hi Chris,
LGTM++
Thanks,
Serguei
On 8/3/20 22:10, Yasumasa Suenaga wrote:
Hi Chris,
Looks good.
Yasumasa
On 2020/08/04 13:10, Chris Plummer wrote:
Ping!
On 7/27/20 10:04 PM, Chris Plummer wrote:
I should
On 8/4/20 11:04, Chris Plummer wrote:
On 8/4/20 2:11 AM, serguei.spit...@oracle.com wrote:
Hi Yasumasa,
The fix looks good to me.
Thanks to Chris for discussing the details in previous emails.
Just
LGTM
--alex
On 07/28/2020 23:26, Leonid Mesnik wrote:
ok, let change it to following
diff -r f489d5d13a51
test/hotspot/jtreg/vmTestbase/nsk/jdi/EventRequest/setEnabled/setenabled002.java
---
a/test/hotspot/jtreg/vmTestbase/nsk/jdi/EventRequest/setEnabled/setenabled002.java
Thu Jul 23 16:3
Hi Chris,
396 posbin = strstr(execname, "/bin/java");
I suppose this should be rstrstr.
--alex
On 07/28/2020 20:40, Chris Plummer wrote:
Hi Serguei and Alex,
Sorry about the delay getting back to this. I got sidetracked with other
bugs and also realized the code needed more work than ju
Hi Alex,
Since this is searching for a file and not a directory, I didn't think
it was necessary, but I can see now that rstrstr may be better just in
case /bin/java appears somewhere in the middle of the path such as
~/bin/java16/bin/java.
thanks,
Chris
On 8/4/20 3:05 PM, Alex Menkov wrot
Needs one more reviewer.
One more details to simplify review.
SocketTransportService extends TransportService and spec for
TransportService.startListening() is:
/**
* Listens on an address chosen by the transport service.
*
* This convenience method works as if by invoking
ping?
-- Igor
> On Jul 31, 2020, at 1:24 PM, Igor Ignatyev wrote:
>
> http://cr.openjdk.java.net/~iignatyev//8249030/webrev.00
>> 2258 lines changed: 0 ins; 1144 del; 1114 mod;
>
> Hi all,
>
> could you please review the clean-up of nsk_jdi tests?
> from main issue(8204985) :
>> all vmTestbas
On 2020/08/05 4:15, serguei.spit...@oracle.com wrote:
On 8/4/20 11:04, Chris Plummer wrote:
On 8/4/20 2:11 AM, serguei.spit...@oracle.com wrote:
Hi Yasumasa,
The fix looks good to me.
Thanks to Chris for discussing the details in previous emails.
Just one suggestion:
http://cr.openjdk.java.n
Hi Alex,
This looks good to me.
But do we need a CSR for this?
I understand that the intention is to comply with the TransportService
spec but the behavior is being changed.
How long did we have this behavior?
Thanks,
Serguei
On 8/4/20 16:32, Alex Menkov wrote:
Needs one more reviewer.
One
My Review still stands. :)
Thanks,
David
On 5/08/2020 1:10 am, jiefu(傅杰) wrote:
Forward it to serviceability-dev since this issue in the JBS has been
moved from hotspot/runtime to core-svc/java.lang.management.
Please review it.
Thanks.
Best regards,
Jie
*From: *"jiefu(傅杰)"
*Date: *Tues
Thanks Chris and David for your review.
Will push it later.
Best regards,
Jie
From: David Holmes
Sent: Wednesday, August 5, 2020 9:03 AM
To: jiefu(傅杰); serviceability-dev@openjdk.java.net
Subject: Re: FW: 8251031: Some vmTestbase/nsk/monitoring/RuntimeMXBean
Hi Jie,
Could you, please, split the format string in two shorter lines?
Otherwise, it looks okay.
There is no need in another webrev.
Thanks,
Serguei
On 8/4/20 18:38, jiefu(傅杰) wrote:
Thanks Chris and Davi
Thanks Serguei for your review.
I'll try to split it.
Best regards,
Jie
From: serguei.spit...@oracle.com
Sent: Wednesday, August 5, 2020 10:10 AM
To: jiefu(傅杰); chris.plum...@oracle.com; David Holmes
Cc: serviceability-dev@openjdk.java.net
Subject: Re: FW: 8
Hi Igor,
It looks okay to me.
At least, I've not noticed any issues.
Thanks,
Serguei
On 8/4/20 16:59, Igor Ignatyev wrote:
ping?
-- Igor
On Jul 31, 2020, at 1:24 PM, Igor Ignatyev wrote:
http://cr.openjdk.java.net/~iignatyev//8249030/webrev.00
2258 lines changed: 0 ins; 1144 del; 1114 mo
That was a hard slog :)
But looks okay to me.
Thanks,
David
On 5/08/2020 9:59 am, Igor Ignatyev wrote:
ping?
-- Igor
On Jul 31, 2020, at 1:24 PM, Igor Ignatyev wrote:
http://cr.openjdk.java.net/~iignatyev//8249030/webrev.00
2258 lines changed: 0 ins; 1144 del; 1114 mod;
Hi all,
could y
Serguei, David,
thank you for your reviews. pushed.
-- Igor
> On Aug 4, 2020, at 7:26 PM, David Holmes wrote:
>
> That was a hard slog :)
>
> But looks okay to me.
>
> Thanks,
> David
>
> On 5/08/2020 9:59 am, Igor Ignatyev wrote:
>> ping?
>> -- Igor
>>> On Jul 31, 2020, at 1:24 PM, Igor Ig
Hi Lin,
https://cr.openjdk.java.net/~lzang/jmap-8214535/8215624/webrev_10/src/hotspot/share/memory/heapInspection.cpp.udiff.html
+class KlassInfoTableMergeClosure : public KlassInfoClosure {
+private:
+ KlassInfoTable* _dest;
+ bool _success;
+public:
+ KlassInfoTableMerg
Oh, sorry for the confusion, please,
skip my question. :)
C++ does not have the '&&=' operator.
Thanks,
Serguei
On 8/4/20 21:56, serguei.spit...@oracle.com wrote:
Hi Lin,
https://cr.openjdk.java.net/~lzang/jmap-
Hi Lin,
On 8/4/20 22:22, linzang(臧琳) wrote:
Hi Serguei,
No problem, Thanks for
your reviewing :)
I wll upload a new
webrev later, so may I ask your help to review it again?
28 matches
Mail list logo