Re: RFR(L): 8215624: add parallel heap inspection support for jmap histo(G1)(Internet mail)

2020-08-07 Thread serguei.spit...@oracle.com
Hi Lin, Not sure, I fully understand the spec update and the options processing in the file: http://cr.openjdk.java.net/~lzang/jmap-8214535/8215624/webrev_11/src/jdk.jcmd/share/classes/sun/tools/jmap/JMap.java.frames.html The spec says nothing if th

Re: RFR(L): 8215624: add parallel heap inspection support for jmap histo(G1)(Internet mail)

2020-08-07 Thread serguei.spit...@oracle.com
On 8/7/20 00:24, serguei.spit...@oracle.com wrote: Hi Lin, Not sure, I fully understand the spec update and the options processing in the file: http://cr.openjdk.java.net/~lzang/jmap-8214535/8215624/webrev_11/src/jdk.jcmd/sh

RFR(XXS): 8241951: ClhsdbCDSCore.java failed to find core file

2020-08-07 Thread Chris Plummer
Hello, Please review the following: https://bugs.openjdk.java.net/browse/JDK-8241951 http://cr.openjdk.java.net/~cjplummer/8241951/webrev.00/index.html We need to disable SA core file testing on OSX 10.15.* and later when the binary is signed because OSX will no longer produce core files with

RFR: JDK-8234808: jdb quoted option parsing broken

2020-08-07 Thread Alex Menkov
Hi all, please review the fix for https://bugs.openjdk.java.net/browse/JDK-8234808 webrev: http://cr.openjdk.java.net/~amenkov/jdk16/jdb_options/webrev/ Some background: when jdb launches debuggee process it passes java options from "options" value for CommandLineLaunch connector and forward op

Re: RFR(XXS): 8241951: ClhsdbCDSCore.java failed to find core file

2020-08-07 Thread Daniel D. Daugherty
On 8/7/20 6:03 PM, Chris Plummer wrote: Hello, Please review the following: https://bugs.openjdk.java.net/browse/JDK-8241951 http://cr.openjdk.java.net/~cjplummer/8241951/webrev.00/index.html test/lib/jdk/test/lib/util/CoreUtils.java     L139:     if (Platform.getOsVersionMajor()

Re: RFR(XXS): 8241951: ClhsdbCDSCore.java failed to find core file

2020-08-07 Thread Chris Plummer
On 8/7/20 3:11 PM, Daniel D. Daugherty wrote: On 8/7/20 6:03 PM, Chris Plummer wrote: Hello, Please review the following: https://bugs.openjdk.java.net/browse/JDK-8241951 http://cr.openjdk.java.net/~cjplummer/8241951/webrev.00/index.html test/lib/jdk/test/lib/util/CoreUtils.java     L139:   

Re: RFR(XXS): 8241951: ClhsdbCDSCore.java failed to find core file

2020-08-07 Thread Daniel D. Daugherty
On 8/7/20 6:25 PM, Chris Plummer wrote: On 8/7/20 3:22 PM, Chris Plummer wrote: On 8/7/20 3:11 PM, Daniel D. Daugherty wrote: On 8/7/20 6:03 PM, Chris Plummer wrote: Hello, Please review the following: https://bugs.openjdk.java.net/browse/JDK-8241951 http://cr.openjdk.java.net/~cjplummer/

Re: RFR(XXS): 8241951: ClhsdbCDSCore.java failed to find core file

2020-08-07 Thread Chris Plummer
On 8/7/20 3:22 PM, Chris Plummer wrote: On 8/7/20 3:11 PM, Daniel D. Daugherty wrote: On 8/7/20 6:03 PM, Chris Plummer wrote: Hello, Please review the following: https://bugs.openjdk.java.net/browse/JDK-8241951 http://cr.openjdk.java.net/~cjplummer/8241951/webrev.00/index.html test/lib/jdk/

Re: RFR(XXS): 8241951: ClhsdbCDSCore.java failed to find core file

2020-08-07 Thread Chris Plummer
On 8/7/20 3:26 PM, Daniel D. Daugherty wrote: On 8/7/20 6:25 PM, Chris Plummer wrote: On 8/7/20 3:22 PM, Chris Plummer wrote: On 8/7/20 3:11 PM, Daniel D. Daugherty wrote: On 8/7/20 6:03 PM, Chris Plummer wrote: Hello, Please review the following: https://bugs.openjdk.java.net/browse/JDK-

Re: RFR(XXS): 8241951: ClhsdbCDSCore.java failed to find core file

2020-08-07 Thread Alex Menkov
LGTM --alex On 08/07/2020 15:34, Chris Plummer wrote: On 8/7/20 3:26 PM, Daniel D. Daugherty wrote: On 8/7/20 6:25 PM, Chris Plummer wrote: On 8/7/20 3:22 PM, Chris Plummer wrote: On 8/7/20 3:11 PM, Daniel D. Daugherty wrote: On 8/7/20 6:03 PM, Chris Plummer wrote: Hello, Please review