> This patch implements asynchronous handshake, which changes how handshakes
> works by default. Asynchronous handshakes
> are target only executed, which they may never be executed. (target may block
> on socket for the rest of VM lifetime)
> Since we have several use-cases for them we can have
On Thu, 24 Sep 2020 06:54:32 GMT, Robbin Ehn wrote:
>> Hi Robbin,
>> I've looked more at the Serviceability files.
>> The fix looks good in general. Nice refactoring and simplification with the
>> JvmtiHandshakeClosure.
>> It is a little unexpected that the do_thread can be executed by
>> non-J
> This PR the implementation of "JEP 376: ZGC: Concurrent Thread-Stack
> Processing" (cf.
> https://openjdk.java.net/jeps/376).
> Basically, this patch modifies the epilog safepoint when returning from a
> frame (supporting interpreter frames, c1, c2,
> and native wrapper frames), to compare the
On Wed, 23 Sep 2020 15:45:12 GMT, Albert Mingkun Yang wrote:
>> Marked as reviewed by stefank (Reviewer).
>
> Given names like `StackWatermarkSet::lowest_watermark`, I wonder if some
> diagrams could be provided in the code
> comments for `class StackWatermarks` so that readers will have the cor
On Thu, 24 Sep 2020 08:55:03 GMT, Erik Österlund wrote:
>> This PR the implementation of "JEP 376: ZGC: Concurrent Thread-Stack
>> Processing" (cf.
>> https://openjdk.java.net/jeps/376).
>> Basically, this patch modifies the epilog safepoint when returning from a
>> frame (supporting interprete
On Thu, 24 Sep 2020 08:55:03 GMT, Erik Österlund wrote:
>> This PR the implementation of "JEP 376: ZGC: Concurrent Thread-Stack
>> Processing" (cf.
>> https://openjdk.java.net/jeps/376).
>> Basically, this patch modifies the epilog safepoint when returning from a
>> frame (supporting interprete
On Thu, 24 Sep 2020 12:23:50 GMT, Erik Österlund wrote:
> Looks good.
Thanks for the review Robbin.
-
PR: https://git.openjdk.java.net/jdk/pull/296
On Thu, 24 Sep 2020 11:29:36 GMT, Per Liden wrote:
> I had also pre-reviewed, but did a final semi-quick review. Looks good
> overall. Just found a couple of minor nitpicks.
Thansk for the review Per. I uploaded fixes to your nitpicks.
-
PR: https://git.openjdk.java.net/jdk/pull/2
> This PR the implementation of "JEP 376: ZGC: Concurrent Thread-Stack
> Processing" (cf.
> https://openjdk.java.net/jeps/376).
> Basically, this patch modifies the epilog safepoint when returning from a
> frame (supporting interpreter frames, c1, c2,
> and native wrapper frames), to compare the
On Wed, 23 Sep 2020 03:34:29 GMT, Vicente Romero wrote:
>> Co-authored-by: Vicente Romero
>> Co-authored-by: Harold Seigel
>> Co-authored-by: Jonathan Gibbons
>> Co-authored-by: Brian Goetz
>> Co-authored-by: Maurizio Cimadamore
>> Co-authored-by: Joe Darcy
>> Co-authored-by: Chris Hegarty
On Thu, 24 Sep 2020 12:32:36 GMT, Nils Eliasson wrote:
> I did a pre-reviewed of the compiler parts, and have now done a second
> reading.
>
> The compiler parts looks good!
Thanks for the review, Nils.
-
PR: https://git.openjdk.java.net/jdk/pull/296
On Thu, 24 Sep 2020 12:27:42 GMT, Erik Österlund wrote:
>> This PR the implementation of "JEP 376: ZGC: Concurrent Thread-Stack
>> Processing" (cf.
>> https://openjdk.java.net/jeps/376).
>> Basically, this patch modifies the epilog safepoint when returning from a
>> frame (supporting interprete
On Thu, 24 Sep 2020 12:24:40 GMT, Erik Österlund wrote:
>>> I had also pre-reviewed, but did a final semi-quick review. Looks good
>>> overall. Just found a couple of minor nitpicks.
>>
>> Thansk for the review Per. I uploaded fixes to your nitpicks.
>
>> Looks good.
>
> Thanks for the review
On Thu, 24 Sep 2020 12:27:42 GMT, Erik Österlund wrote:
>> This PR the implementation of "JEP 376: ZGC: Concurrent Thread-Stack
>> Processing" (cf.
>> https://openjdk.java.net/jeps/376).
>> Basically, this patch modifies the epilog safepoint when returning from a
>> frame (supporting interprete
On Thu, 24 Sep 2020 12:27:42 GMT, Erik Österlund wrote:
>> This PR the implementation of "JEP 376: ZGC: Concurrent Thread-Stack
>> Processing" (cf.
>> https://openjdk.java.net/jeps/376).
>> Basically, this patch modifies the epilog safepoint when returning from a
>> frame (supporting interprete
On Thu, 24 Sep 2020 12:45:00 GMT, Coleen Phillimore wrote:
>> Erik Österlund has updated the pull request with a new target base due to a
>> merge or a rebase. The pull request now
>> contains seven commits:
>> - Review: Per CR 1
>> - Merge branch 'master' into 8253180_conc_stack_scanning
>>
> This is a continuation of
> https://mail.openjdk.java.net/pipermail/aarch64-port-dev/2020-August/009566.html
>
> Changes since then:
> * We've improved the write barrier as suggested by Andrew [1]
> * The define-guards around R18 have been changed to `R18_RESERVED`. This will
> be enabled for
> Hi,
>
> this is the continuation of the review of the implementation for:
>
> https://bugs.openjdk.java.net/browse/JDK-8227745
> https://bugs.openjdk.java.net/browse/JDK-8233915
>
> It allows for JIT optimizations based on escape analysis even if JVMTI agents
> acquire capabilities to access
On Mon, 14 Sep 2020 05:02:42 GMT, David Holmes wrote:
>> Richard Reingruber has updated the pull request incrementally with one
>> additional commit since the last revision:
>>
>> Changes based on dholmes' feedback.
>>
>> EscapeBarrier::sync_and_suspend_all():
>>
>> - Set suspend
On Mon, 14 Sep 2020 05:08:39 GMT, David Holmes wrote:
>> Richard Reingruber has updated the pull request incrementally with one
>> additional commit since the last revision:
>>
>> Changes based on dholmes' feedback.
>>
>> EscapeBarrier::sync_and_suspend_all():
>>
>> - Set suspend
On Thu, 24 Sep 2020 12:49:06 GMT, Coleen Phillimore wrote:
>> Erik Österlund has updated the pull request with a new target base due to a
>> merge or a rebase. The pull request now
>> contains seven commits:
>> - Review: Per CR 1
>> - Merge branch 'master' into 8253180_conc_stack_scanning
>>
> This PR the implementation of "JEP 376: ZGC: Concurrent Thread-Stack
> Processing" (cf.
> https://openjdk.java.net/jeps/376).
> Basically, this patch modifies the epilog safepoint when returning from a
> frame (supporting interpreter frames, c1, c2,
> and native wrapper frames), to compare the
On Thu, 24 Sep 2020 14:25:15 GMT, Erik Österlund wrote:
>> This PR the implementation of "JEP 376: ZGC: Concurrent Thread-Stack
>> Processing" (cf.
>> https://openjdk.java.net/jeps/376).
>> Basically, this patch modifies the epilog safepoint when returning from a
>> frame (supporting interprete
On Thu, 24 Sep 2020 04:45:16 GMT, David Holmes wrote:
>> Monica Beckwith has updated the pull request incrementally with one
>> additional commit since the last revision:
>>
>> Update orderAccess_windows_aarch64.hpp
>>
>> changing from Acq-reL to Sequential Consistency to avoid compiler
> This is a continuation of
> https://mail.openjdk.java.net/pipermail/aarch64-port-dev/2020-August/009566.html
>
> Changes since then:
> * We've improved the write barrier as suggested by Andrew [1]
> * The define-guards around R18 have been changed to `R18_RESERVED`. This will
> be enabled for
On Thu, 24 Sep 2020 04:52:22 GMT, David Holmes wrote:
>> Monica Beckwith has updated the pull request incrementally with one
>> additional commit since the last revision:
>>
>> Update orderAccess_windows_aarch64.hpp
>>
>> changing from Acq-reL to Sequential Consistency to avoid compiler
On Thu, 24 Sep 2020 14:04:22 GMT, Monica Beckwith wrote:
>> This is a continuation of
>> https://mail.openjdk.java.net/pipermail/aarch64-port-dev/2020-August/009566.html
>>
>> Changes since then:
>> * We've improved the write barrier as suggested by Andrew [1]
>> * The define-guards around R18
On Thu, 24 Sep 2020 12:23:13 GMT, Coleen Phillimore wrote:
>> Vicente Romero has updated the pull request incrementally with three
>> additional commits since the last revision:
>>
>> - Merge pull request #1 from ChrisHegarty/record-serial-tests
>>
>>Remove preview args from JDK tests
> Co-authored-by: Vicente Romero
> Co-authored-by: Harold Seigel
> Co-authored-by: Jonathan Gibbons
> Co-authored-by: Brian Goetz
> Co-authored-by: Maurizio Cimadamore
> Co-authored-by: Joe Darcy
> Co-authored-by: Chris Hegarty
> Co-authored-by: Jan Lahoda
Vicente Romero has updated the pu
On Thu, 24 Sep 2020 14:28:44 GMT, Coleen Phillimore wrote:
> To be clear, my comments about boolean parameters to vframeStream/RegMap can
> be addressed in a follow up RFE. That
> would be better.
Thanks for reviewing Coleen!
-
PR: https://git.openjdk.java.net/jdk/pull/296
> Co-authored-by: Vicente Romero
> Co-authored-by: Harold Seigel
> Co-authored-by: Jonathan Gibbons
> Co-authored-by: Brian Goetz
> Co-authored-by: Maurizio Cimadamore
> Co-authored-by: Joe Darcy
> Co-authored-by: Chris Hegarty
> Co-authored-by: Jan Lahoda
Vicente Romero has updated the pu
On Wed, 23 Sep 2020 05:35:29 GMT, Aleksey Shipilev wrote:
>> the patch
>> - removes `PropertyResolvingWrapper` from `vmTestbase/nsk/aod` tests
>> - updates `AODRunnerArgParser` to remove surrounding `"` symbols from
>> `javaOpts` option values
>> - updates vmTestbase/nsk/aod test descriptions to
On Tue, 22 Sep 2020 21:13:53 GMT, Igor Ignatyev wrote:
> the patch
> - removes `PropertyResolvingWrapper` from `vmTestbase/nsk/aod` tests
> - updates `AODRunnerArgParser` to remove surrounding `"` symbols from
> `javaOpts` option values
> - updates vmTestbase/nsk/aod test descriptions to have `"
> Hi,
>
> this is the continuation of the review of the implementation for:
>
> https://bugs.openjdk.java.net/browse/JDK-8227745
> https://bugs.openjdk.java.net/browse/JDK-8233915
>
> It allows for JIT optimizations based on escape analysis even if JVMTI agents
> acquire capabilities to access
On Sat, 19 Sep 2020 20:24:14 GMT, Vipin Sharma wrote:
>> Updated @exception with @throws for core-libs, it fixes all open sub-tasks
>> of JDK-8252536.
>>
>> Open Subtasks part of this fix are:
>> 1. JDK-8252537
>> 2. JDK-8252539
>> 3. JDK-8252540
>> 4. JDK-8252541
>>
>> Previous conversation o
On Thu, 24 Sep 2020 17:30:52 GMT, Lance Andersen wrote:
> Overall the changes look OK. in the java.sql set of classes, please updated
> the modified statements to also use {@code}
Hi @LanceAndersen, it was suggested by @RogerRiggs also. I have created a
separate bug JDK-8253612 to fix this for
On Thu, 24 Sep 2020 18:20:15 GMT, Vipin Sharma wrote:
> > Overall the changes look OK. in the java.sql set of classes, please updated
> > the modified statements to also use {@code}
>
> Hi @LanceAndersen, it was suggested by @RogerRiggs also. I have created a
> separate bug JDK-8253612 to fix
On Thu, 24 Sep 2020 15:49:36 GMT, Erik Österlund wrote:
>> To be clear, my comments about boolean parameters to vframeStream/RegMap can
>> be addressed in a follow up RFE. That
>> would be better.
>
>> To be clear, my comments about boolean parameters to vframeStream/RegMap can
>> be addressed
On Thu, 24 Sep 2020 15:43:10 GMT, Chris Plummer wrote:
>> Monica Beckwith has updated the pull request with a new target base due to a
>> merge or a rebase. The incremental webrev
>> excludes the unrelated changes brought in by the merge/rebase. The pull
>> request contains 17 additional commit
> Co-authored-by: Vicente Romero
> Co-authored-by: Harold Seigel
> Co-authored-by: Jonathan Gibbons
> Co-authored-by: Brian Goetz
> Co-authored-by: Maurizio Cimadamore
> Co-authored-by: Joe Darcy
> Co-authored-by: Chris Hegarty
> Co-authored-by: Jan Lahoda
Vicente Romero has updated the pu
the patch
- removes `PropertyResolvingWrapper` from `vmTestbase/nsk/jdb` tests
- updates `JdbArgumentHandler` to remove `"` from `jdb.option` option
- reformats code
testing:
✅ `vmTestbase/nsk/jdb` on {macosx,linux,windows}-x64
-
Commit messages:
- reformat code
- 8252000: remove u
Hi Chris, Monica,
On 25/09/2020 1:47 am, Chris Plummer wrote:
As for the copyright in the new SA files, I believe it is incorrect and needs
to include Oracle. There are a number of
other non-SA files that are new and also have the same copyright issue.
If a file was created completely from sc
On Thu, 24 Sep 2020 15:45:22 GMT, Vicente Romero wrote:
>> The classfile parser changes look good to me.
>
> I have modified the `@since`: 14 -> 16
[CSR: Record Classes](https://bugs.openjdk.java.net/browse/JDK-8253605)
-
PR: https://git.openjdk.java.net/jdk/pull/290
the patch removes `PropertyResolvingWrapper` from `vmTestbase/nsk/jdwp` tests
and cleans up/reformats the touched files.
testing: ✅ `vmTestbase/nsk/jdwp` on `{linux,windows,macos}-x64`
-
Commit messages:
- reformat/clean up the code
- removed TEST.properties
- removed explicit @
On Thu, 24 Sep 2020 23:55:15 GMT, Igor Ignatyev wrote:
> the patch
> - removes `PropertyResolvingWrapper` from `vmTestbase/nsk/jdb` tests
> - updates `JdbArgumentHandler` to remove `"` from `jdb.option` option
> - reformats code
>
> testing:
> ✅ `vmTestbase/nsk/jdb` on {macosx,linux,windows}-x64
45 matches
Mail list logo
