Hi all,
could you please review the patch which removes `PropertyResolvingWrapper` from
`vmTestbase/nsk/jvmti` tests? as
`jtreg` doesn't support spaces in the arguments and doesn't handle `"` in any
special ways, the patch also:
- `s/"-javaOpts=/-javaOpts="/`
- makes `nsk.jvmti.scenarios.gener
On Fri, 25 Sep 2020 02:38:01 GMT, Vicente Romero wrote:
>> I have modified the `@since`: 14 -> 16
>
> [CSR: Record Classes](https://bugs.openjdk.java.net/browse/JDK-8253605)
Hi @vicente-romero-oracle , note that besides tests, there is also a JMH
benchmark that measures the performance of
recor
> the patch
> - removes `PropertyResolvingWrapper` from `vmTestbase/nsk/jdb` tests
> - updates `JdbArgumentHandler` to remove `"` from `jdb.option` option
> - reformats code
>
> testing:
> ✅ `vmTestbase/nsk/jdb` on {macosx,linux,windows}-x64
Igor Ignatyev has updated the pull request incrementall
On Fri, 25 Sep 2020 05:38:08 GMT, Aleksey Shipilev wrote:
>> Igor Ignatyev has updated the pull request incrementally with three
>> additional commits since the last revision:
>>
>> - realign table in locals002
>> - updated copyright year
>> - move var declarations closer to the 1st use
>>
On Fri, 25 Sep 2020 05:38:08 GMT, Aleksey Shipilev wrote:
> The changes look good, but I think the practice of doing a massive cleanup in
> "remove usage of PropertyResolvingWrapper
> in vmTestbase/nsk/jdb" PR is misleading. Better to split this in two issues
> (at least next time)?
o/c I can
On Thu, 24 Sep 2020 15:15:45 GMT, Monica Beckwith wrote:
>> This is a continuation of
>> https://mail.openjdk.java.net/pipermail/aarch64-port-dev/2020-August/009566.html
>>
>> Changes since then:
>> * We've improved the write barrier as suggested by Andrew [1]
>> * The define-guards around R18
On Fri, 25 Sep 2020 10:44:53 GMT, David Holmes wrote:
>
>
> The minor updates in response to my comments are fine.
>
> The more major updates ... I can't really comment on.
Thanks for looking at the changes and for giving feedback.
-
PR: https://git.openjdk.java.net/jdk/pull/119
On Thu, 24 Sep 2020 16:59:03 GMT, Richard Reingruber wrote:
>> Hi,
>>
>> this is the continuation of the review of the implementation for:
>>
>> https://bugs.openjdk.java.net/browse/JDK-8227745
>> https://bugs.openjdk.java.net/browse/JDK-8233915
>>
>> It allows for JIT optimizations based on e
