Re: RFR: 6606767: resexhausted00[34] fail assert(!thread->owns_locks(), "must release all locks when leaving VM")

2020-10-14 Thread Serguei Spitsyn
On Wed, 14 Oct 2020 22:25:34 GMT, Alex Menkov wrote: > Please review the fix for JDK-6606767. > The original issue is not reproducible. > The fix: > - resexhausted003 and resexhausted004 are un-problemlisted > - resexhausted004 is problemlisted on linux due JDK-8253916 (resexhausted004 > execute

RFR: 6606767: resexhausted00[34] fail assert(!thread->owns_locks(), "must release all locks when leaving VM")

2020-10-14 Thread Alex Menkov
Please review the fix for JDK-6606767. The original issue is not reproducible. The fix: - resexhausted003 and resexhausted004 are un-problemlisted - resexhausted004 is problemlisted on linux due JDK-8253916 (resexhausted004 executes resexhausted001/resexhausted002/resexhausted003 randomly, and r

Re: RFR: 8254125: Assertion in cppVtables.cpp during builds on 32bit Windows [v3]

2020-10-14 Thread Ioi Lam
On Wed, 14 Oct 2020 20:42:44 GMT, Calvin Cheung wrote: >> Ioi Lam has updated the pull request with a new target base due to a merge >> or a rebase. The incremental webrev excludes >> the unrelated changes brought in by the merge/rebase. The pull request >> contains four additional commits sinc

Integrated: 8254777: Remove unimplemented Management::get_loaded_classes

2020-10-14 Thread Aleksey Shipilev
On Wed, 14 Oct 2020 15:04:32 GMT, Aleksey Shipilev wrote: > There seems to be no definition of `Management::get_loaded_classes` anywhere > in current tip or history prior the > initial load. Can be removed. > Testing: > - [x] Linux x86_64 build > - [x] Text search for `get_loaded_classes` in `

Integrated: 8254780: EnterInterpOnlyModeClosure::completed() always returns true

2020-10-14 Thread Aleksey Shipilev
On Wed, 14 Oct 2020 15:16:54 GMT, Aleksey Shipilev wrote: > JDK-8238761 introduced this funky code: > > class EnterInterpOnlyModeClosure : public HandshakeClosure { > private: > bool _completed; > public: > EnterInterpOnlyModeClosure() : HandshakeClosure("EnterInterpOnlyMode"), > _complet

Integrated: 8254781: Remove unimplemented ClassFieldMap::compute_field_count

2020-10-14 Thread Aleksey Shipilev
On Wed, 14 Oct 2020 15:27:26 GMT, Aleksey Shipilev wrote: > There is no definition of `ClassFieldMap::compute_field_count` in current tip > or any history after the initial load. > Can be removed. > Testing: > - [x] Linux x86_64 build > - [x] Text searches for `compute_field_count` in `src/hot

Re: RFR: 8227745: Enable Escape Analysis for Better Performance in the Presence of JVMTI Agents [v10]

2020-10-14 Thread Richard Reingruber
On Wed, 14 Oct 2020 00:25:14 GMT, Vladimir Kozlov wrote: > > > Good. Thanks for the review, Vladimir (@vnkozlov)! I'm still (stress) testing adaptations to lazy/concurrent thread stack processing for ZGC. --Richard. - PR: https://git.openjdk.java.net/jdk/pull/119

Re: RFR: 8254125: Assertion in cppVtables.cpp during builds on 32bit Windows [v3]

2020-10-14 Thread Calvin Cheung
On Tue, 13 Oct 2020 06:46:27 GMT, Ioi Lam wrote: >> **Problem:** when iterating over the cloned vtables, the original code >> assumes that they are laid out consecutively in >> memory. However, since >> [JDK-8224509](https://bugs.openjdk.java.net/browse/JDK-8224509), the memory >> allocated

Re: RFR: 8254780: EnterInterpOnlyModeClosure::completed() always returns true

2020-10-14 Thread Robbin Ehn
On Wed, 14 Oct 2020 15:16:54 GMT, Aleksey Shipilev wrote: > JDK-8238761 introduced this funky code: > > class EnterInterpOnlyModeClosure : public HandshakeClosure { > private: > bool _completed; > public: > EnterInterpOnlyModeClosure() : HandshakeClosure("EnterInterpOnlyMode"), > _complet

Integrated: 8249623: test @ignore-d due to 7013634 should be returned back to execution

2020-10-14 Thread Alex Menkov
On Wed, 7 Oct 2020 20:07:56 GMT, Alex Menkov wrote: > - updated timeout/stressTime for resexhausted001 test so on Windows we get > "can't reproduce OOME" instead of timeout; > - updated resexhausted001 cleanup code (to terminate all threads); > - intermittent resexhausted001 failure on linux is

Integrated: 8254345: com/sun/jdi/JdwpAttachTest.java reports error incorrectly

2020-10-14 Thread Alex Menkov
On Mon, 12 Oct 2020 21:03:55 GMT, Alex Menkov wrote: > Please review a trivial fix for JdwpAttachTest This pull request has now been integrated. Changeset: b7daf842 Author:Alex Menkov URL: https://git.openjdk.java.net/jdk/commit/b7daf842 Stats: 4 lines in 1 file changed: 0 ins; 0

Re: RFR: 8254781: Remove unimplemented ClassFieldMap::compute_field_count

2020-10-14 Thread Serguei Spitsyn
On Wed, 14 Oct 2020 15:27:26 GMT, Aleksey Shipilev wrote: > There is no definition of `ClassFieldMap::compute_field_count` in current tip > or any history after the initial load. > Can be removed. > Testing: > - [x] Linux x86_64 build > - [x] Text searches for `compute_field_count` in `src/hot

Re: RFR: 8254780: EnterInterpOnlyModeClosure::completed() always returns true

2020-10-14 Thread Serguei Spitsyn
On Wed, 14 Oct 2020 15:16:54 GMT, Aleksey Shipilev wrote: > JDK-8238761 introduced this funky code: > > class EnterInterpOnlyModeClosure : public HandshakeClosure { > private: > bool _completed; > public: > EnterInterpOnlyModeClosure() : HandshakeClosure("EnterInterpOnlyMode"), > _complet

Re: RFR: 8254777: Remove unimplemented Management::get_loaded_classes

2020-10-14 Thread Serguei Spitsyn
On Wed, 14 Oct 2020 15:04:32 GMT, Aleksey Shipilev wrote: > There seems to be no definition of `Management::get_loaded_classes` anywhere > in current tip or history prior the > initial load. Can be removed. > Testing: > - [x] Linux x86_64 build > - [x] Text search for `get_loaded_classes` in `

Re: RFR: 8254781: Remove unimplemented ClassFieldMap::compute_field_count

2020-10-14 Thread Paul Hohensee
On Wed, 14 Oct 2020 15:27:26 GMT, Aleksey Shipilev wrote: > There is no definition of `ClassFieldMap::compute_field_count` in current tip > or any history after the initial load. > Can be removed. > Testing: > - [x] Linux x86_64 build > - [x] Text searches for `compute_field_count` in `src/hot

RFR: 8254781: Remove unimplemented ClassFieldMap::compute_field_count

2020-10-14 Thread Aleksey Shipilev
There is no definition of `ClassFieldMap::compute_field_count` in current tip or any history after the initial load. Can be removed. Testing: - [x] Linux x86_64 build - [x] Text searches for `compute_field_count` in `src/hotspot` - Commit messages: - 8254781: Remove unimplemented

RFR: 8254780: EnterInterpOnlyModeClosure::completed() always returns true

2020-10-14 Thread Aleksey Shipilev
JDK-8238761 introduced this funky code: class EnterInterpOnlyModeClosure : public HandshakeClosure { private: bool _completed; public: EnterInterpOnlyModeClosure() : HandshakeClosure("EnterInterpOnlyMode"), _completed(false) { } void do_thread(Thread* th) { ... _completed = true

RFR: 8254777: Remove unimplemented Management::get_loaded_classes

2020-10-14 Thread Aleksey Shipilev
There seems to be no definition of `Management::get_loaded_classes` anywhere in current tip or history prior the initial load. Can be removed. Testing: - [x] Linux x86_64 build - [x] Text search for `get_loaded_classes` in `src/hotspot` - Commit messages: - 8254777: Remove unimpl

RFR: 8253525: Implement getInstanceSize/sizeOf intrinsics

2020-10-14 Thread Aleksey Shipilev
This is fork off the SizeOf JEP, JDK-8249196. There is already the entry point in JDK that can use the intrinsic like this: `Instrumentation.getInstanceSize`. Therefore, we can implement the C1/C2 intrinsic now, hook it up to `Instrumentation`, and let the tools use that fast path today. With th

Integrated: 8254668: JVMTI process frames on thread without started processing

2020-10-14 Thread Stefan Karlsson
On Tue, 13 Oct 2020 09:25:55 GMT, Stefan Karlsson wrote: > I hit the following assert in some tests runs that I've been doing: > # Internal Error > (/home/stefank/git/alt/open/src/hotspot/share/runtime/stackWatermark.inline.hpp:67), > pid=828170, > tid=828734 # assert(processing_started()) fail