On 20/10/2020 4:18 pm, Robbin Ehn wrote:
On Tue, 20 Oct 2020 02:14:56 GMT, David Holmes wrote:
The main point of this change-set is to make it easier to implement S/R on top
of handshakes.
Which is a prerequisite for removing _suspend_flag (which duplicates the
handshake functionality).
But
On Tue, 20 Oct 2020 02:14:56 GMT, David Holmes wrote:
>> The main point of this change-set is to make it easier to implement S/R on
>> top of handshakes.
>> Which is a prerequisite for removing _suspend_flag (which duplicates the
>> handshake functionality).
>> But we also remove some complicat
On Wed, 14 Oct 2020 14:57:20 GMT, Aleksey Shipilev wrote:
> `LowMemoryDetector::check_memory_usage` seems declared but not implemented.
> Current history does not show any
> definitions since the initial load. Can be removed.
> Testing:
> - [x] Linux x86_64 build
> - [x] Test search for `check
On Mon, 19 Oct 2020 09:59:34 GMT, Robbin Ehn wrote:
> The main point of this change-set is to make it easier to implement S/R on
> top of handshakes.
> Which is a prerequisite for removing _suspend_flag (which duplicates the
> handshake functionality).
> But we also remove some complicated S/R
On Tue, 20 Oct 2020 00:04:16 GMT, Igor Ignatyev wrote:
>> test/hotspot/jtreg/vmTestbase/nsk/jdb/caught_exception/caught_exception002/caught_exception002.java
>> line 87:
>>
>>> 85: static final String DEBUGGEE_CLASS = TEST_CLASS + "a";
>>> 86: static final String FIRST_BREAK = DEBUGGEE_
On Mon, 19 Oct 2020 23:56:00 GMT, Chris Plummer wrote:
>> b/c you get indentation unit for each block, 1st block is `fields001` class
>> definition, next block is the array
>> initializations (start at L#86 and L#99 for `checkedFields1` and
>> `checkedFields2` respecitively)
>
> I don't follow
On Mon, 19 Oct 2020 18:37:58 GMT, Chris Plummer wrote:
>> Igor Ignatyev has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> update copyright years
>
> test/hotspot/jtreg/vmTestbase/nsk/jdb/caught_exception/caught_exception002/caught_exceptio
On Mon, 19 Oct 2020 20:55:01 GMT, Igor Ignatyev wrote:
>> test/hotspot/jtreg/vmTestbase/nsk/jdb/fields/fields001/fields001.java line
>> 108:
>>
>>> 106: "ii_aa", "oi_aa",
>>> 107: "ii_aaa", "oi_aaa"
>>> 108: };
>>
>> Why are these indented 8 instead of 4?
>
> b/c yo
On Mon, 19 Oct 2020 20:49:14 GMT, Igor Ignatyev wrote:
>> test/hotspot/jtreg/vmTestbase/nsk/jdb/caught_exception/caught_exception002/caught_exception002a.java
>> line 42:
>>
>>> 40: }
>>> 41:
>>> 42: public int runIt(String[] args, PrintStream out) {
>>
>> Is there a style guide that s
On Mon, 19 Oct 2020 18:51:15 GMT, Chris Plummer wrote:
>> Igor Ignatyev has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> update copyright years
>
> test/hotspot/jtreg/vmTestbase/nsk/jdb/fields/fields001/fields001.java line
> 108:
>
>> 1
On Mon, 19 Oct 2020 18:44:56 GMT, Chris Plummer wrote:
>> Igor Ignatyev has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> update copyright years
>
> test/hotspot/jtreg/vmTestbase/nsk/jdb/caught_exception/caught_exception002/caught_exceptio
On Wed, 14 Oct 2020 20:50:45 GMT, Richard Reingruber wrote:
>> Good.
>
>>
>>
>> Good.
>
> Thanks for the review, Vladimir (@vnkozlov)!
> I'm still (stress) testing adaptations to lazy/concurrent thread stack
> processing for ZGC.
> --Richard.
Thanks once more @TheRealMDoerr, @GoeLin, @dholm
On Thu, 15 Oct 2020 23:25:25 GMT, Igor Ignatyev wrote:
>> Hi all,
>>
>> could you please review this patch which reformats/cleans up the code of
>> vmTestbase/nsk/jdb tests?
>>
>> the part of this patch is a spinoff from #350.
>>
>> testing:
>> * [x] `vmTestbase/nsk/jdb` tests on `linux-x64-d
> Hi,
>
> this is the continuation of the review of the implementation for:
>
> https://bugs.openjdk.java.net/browse/JDK-8227745
> https://bugs.openjdk.java.net/browse/JDK-8233915
>
> It allows for JIT optimizations based on escape analysis even if JVMTI agents
> acquire capabilities to access
On Mon, 19 Oct 2020 06:23:16 GMT, Aleksey Shipilev wrote:
>> `LowMemoryDetector::check_memory_usage` seems declared but not implemented.
>> Current history does not show any
>> definitions since the initial load. Can be removed.
>> Testing:
>> - [x] Linux x86_64 build
>> - [x] Test search for
On Mon, 19 Oct 2020 06:57:24 GMT, Aleksey Shipilev wrote:
>> This is fork off the SizeOf JEP, JDK-8249196. There is already the entry
>> point in JDK that can use the intrinsic like
>> this: `Instrumentation.getInstanceSize`. Therefore, we can implement the
>> C1/C2 intrinsic now, hook it up to
On Mon, 19 Oct 2020 06:23:16 GMT, Aleksey Shipilev wrote:
>> `LowMemoryDetector::check_memory_usage` seems declared but not implemented.
>> Current history does not show any
>> definitions since the initial load. Can be removed.
>> Testing:
>> - [x] Linux x86_64 build
>> - [x] Test search for
On Thu, 15 Oct 2020 22:47:43 GMT, Igor Ignatyev wrote:
> Hi all,
>
> could you please review this patch which reformats/cleans up the code of
> vmTestbase/nsk/jdb tests?
>
> the part of this patch is a spinoff from #350.
>
> testing:
> * [x] `vmTestbase/nsk/jdb` tests on `linux-x64-debug`
pi
> - Parallel heap iteration support for PSS
> - JBS: https://bugs.openjdk.java.net/browse/JDK-8252103
Lin Zang has refreshed the contents of this pull request, and previous commits
have been removed. The incremental views
will show differences compared to the previous content of the PR. The pull
On Fri, 9 Oct 2020 14:23:31 GMT, Lin Zang wrote:
>> Hi @kstefanj, Thanks a lot for your comments.
>> I think there can be a reclaimer that treat eden space, from space, to space
>> and "blocks" in old space as parallel
>> iteration candidates, then every workers try to claim their ownership of t
> - Parallel heap iteration support for PSS
> - JBS: https://bugs.openjdk.java.net/browse/JDK-8252103
Lin Zang has refreshed the contents of this pull request, and previous commits
have been removed. The incremental views
will show differences compared to the previous content of the PR. The pull
> - Parallel heap iteration support for PSS
> - JBS: https://bugs.openjdk.java.net/browse/JDK-8252103
Lin Zang has refreshed the contents of this pull request, and previous commits
have been removed. The incremental views
will show differences compared to the previous content of the PR. The pull
The main point of this change-set is to make it easier to implement S/R on top
of handshakes.
Which is a prerequisite for removing _suspend_flag (which duplicates the
handshake functionality).
But we also remove some complicated S/R methods.
We basically just put in everything in the handshake c
On Fri, 16 Oct 2020 22:30:14 GMT, Markus Grönlund wrote:
> Greetings,
>
> JDK-8243962 has been a large effort to chase down intermittent timeouts for
> certain JVMTI tests when run on Windows
> debug builds in combination with JFR. The background is long, included in
> JDK-8243962.
> In short,
On Sun, 18 Oct 2020 20:12:31 GMT, Chris Plummer wrote:
>> Markus Grönlund has updated the pull request with a new target base due to a
>> merge or a rebase. The incremental webrev
>> excludes the unrelated changes brought in by the merge/rebase. The pull
>> request contains three additional com
On Fri, 16 Oct 2020 14:29:46 GMT, Stefan Karlsson wrote:
> The cm03t001 test creates a local JNI handle in the prepare function. It
> later uses that handle from a callback
> function, from another thread. When the callback runs, ZGC applies a load
> barrier to that handle and self-heals it in
On Sat, 17 Oct 2020 08:38:10 GMT, Per Liden wrote:
>> The cm03t001 test creates a local JNI handle in the prepare function. It
>> later uses that handle from a callback
>> function, from another thread. When the callback runs, ZGC applies a load
>> barrier to that handle and self-heals it in
>>
> This is fork off the SizeOf JEP, JDK-8249196. There is already the entry
> point in JDK that can use the intrinsic like
> this: `Instrumentation.getInstanceSize`. Therefore, we can implement the
> C1/C2 intrinsic now, hook it up to
> `Instrumentation`, and let the tools use that fast path today
28 matches
Mail list logo
