> Please review the fix for BadHandshakeTest.
> Summary:
> The test verifies that bad (testcase1) or incomplete (testcase2) handshake
> does not cause debuggee termination.
> To check this it tries to attach to the debuggee again (connect in testcase2
> is also verification for testcase1)
>
>
On Thu, 22 Oct 2020 00:00:17 GMT, Alex Menkov wrote:
> Please review the fix for BadHandshakeTest.
> Summary:
> The test verifies that bad (testcase1) or incomplete (testcase2) handshake
> does not cause debuggee termination.
> To check this it tries to attach to the debuggee again (connect in
> Test only change. With
> [JDK-8253435](https://bugs.openjdk.java.net/browse/JDK-8253435) a test has
> been added on the hotspot side, but nothing for the Java Metrics code. Same
> for [JDK-8252359](https://bugs.openjdk.java.net/browse/JDK-8252359).
>
> When JDK-8217766 got fixed cgroup
> Test only change. With
> [JDK-8253435](https://bugs.openjdk.java.net/browse/JDK-8253435) a test has
> been added on the hotspot side, but nothing for the Java Metrics code. Same
> for [JDK-8252359](https://bugs.openjdk.java.net/browse/JDK-8252359). This
> patch alleviates that.
>
>
On Fri, 23 Oct 2020 08:15:34 GMT, Chris Plummer wrote:
>>>
>>>
>>> Looks good.
>>
>> Thank you. I'll wait for a second review assuming it's required.
>
>> Thank you. I'll wait for a second review assuming it's required.
>
> You might want to add the compiler and/or gc teams to the review
On Fri, 23 Oct 2020 08:00:49 GMT, Richard Reingruber wrote:
> Thank you. I'll wait for a second review assuming it's required.
You might want to add the compiler and/or gc teams to the review
-
PR: https://git.openjdk.java.net/jdk/pull/775
On Thu, 22 Oct 2020 23:06:10 GMT, Chris Plummer wrote:
>
>
> Looks good.
Thank you. I'll wait for a second review assuming it's required.
-
PR: https://git.openjdk.java.net/jdk/pull/775