Re: RFR: 8252117: com/sun/jdi/BadHandshakeTest.java failed with "ConnectException: Connection refused: connect" [v2]

2020-10-23 Thread Alex Menkov
> Please review the fix for BadHandshakeTest. > Summary: > The test verifies that bad (testcase1) or incomplete (testcase2) handshake > does not cause debuggee termination. > To check this it tries to attach to the debuggee again (connect in testcase2 > is also verification for testcase1) > >

Re: RFR: 8252117: com/sun/jdi/BadHandshakeTest.java failed with "ConnectException: Connection refused: connect"

2020-10-23 Thread Chris Plummer
On Thu, 22 Oct 2020 00:00:17 GMT, Alex Menkov wrote: > Please review the fix for BadHandshakeTest. > Summary: > The test verifies that bad (testcase1) or incomplete (testcase2) handshake > does not cause debuggee termination. > To check this it tries to attach to the debuggee again (connect in

Re: RFR: 8253939: [TESTBUG] Increase coverage of the cgroups detection code [v3]

2020-10-23 Thread Severin Gehwolf
> Test only change. With > [JDK-8253435](https://bugs.openjdk.java.net/browse/JDK-8253435) a test has > been added on the hotspot side, but nothing for the Java Metrics code. Same > for [JDK-8252359](https://bugs.openjdk.java.net/browse/JDK-8252359). > > When JDK-8217766 got fixed cgroup

Re: RFR: 8253939: [TESTBUG] Increase coverage of the cgroups detection code for Java [v2]

2020-10-23 Thread Severin Gehwolf
> Test only change. With > [JDK-8253435](https://bugs.openjdk.java.net/browse/JDK-8253435) a test has > been added on the hotspot side, but nothing for the Java Metrics code. Same > for [JDK-8252359](https://bugs.openjdk.java.net/browse/JDK-8252359). This > patch alleviates that. > >

Re: RFR: 8255072: [TESTBUG] com/sun/jdi/EATests.java should not fail if expected VMOutOfMemoryException is not thrown [v3]

2020-10-23 Thread Richard Reingruber
On Fri, 23 Oct 2020 08:15:34 GMT, Chris Plummer wrote: >>> >>> >>> Looks good. >> >> Thank you. I'll wait for a second review assuming it's required. > >> Thank you. I'll wait for a second review assuming it's required. > > You might want to add the compiler and/or gc teams to the review

Re: RFR: 8255072: [TESTBUG] com/sun/jdi/EATests.java should not fail if expected VMOutOfMemoryException is not thrown [v3]

2020-10-23 Thread Chris Plummer
On Fri, 23 Oct 2020 08:00:49 GMT, Richard Reingruber wrote: > Thank you. I'll wait for a second review assuming it's required. You might want to add the compiler and/or gc teams to the review - PR: https://git.openjdk.java.net/jdk/pull/775

Re: RFR: 8255072: [TESTBUG] com/sun/jdi/EATests.java should not fail if expected VMOutOfMemoryException is not thrown [v3]

2020-10-23 Thread Richard Reingruber
On Thu, 22 Oct 2020 23:06:10 GMT, Chris Plummer wrote: > > > Looks good. Thank you. I'll wait for a second review assuming it's required. - PR: https://git.openjdk.java.net/jdk/pull/775