Re: RFR: 8254723: add diagnostic command to write Linux perf map file [v5]

2020-10-26 Thread Nick Gasson
> When using the Linux "perf" tool to do system profiling, symbol names of > running Java methods cannot be decoded, resulting in unhelpful output > such as: > > 10.52% [JIT] tid 236748 [.] 0x7f6fdb75d223 > > Perf can read a simple text file format describing the mapping between > address r

Re: RFR: 8254723: add diagnostic command to write Linux perf map file [v4]

2020-10-26 Thread Nick Gasson
On Tue, 27 Oct 2020 01:07:04 GMT, Serguei Spitsyn wrote: >> Nick Gasson has updated the pull request with a new target base due to a >> merge or a rebase. The pull request now contains four commits: >> >> - Merge master >> - Add -XX:+DumpPerfMapAtExit option >> - Update for review comments >

Re: RFR: 8254723: add diagnostic command to write Linux perf map file [v4]

2020-10-26 Thread Serguei Spitsyn
On Mon, 26 Oct 2020 06:06:47 GMT, Nick Gasson wrote: >> When using the Linux "perf" tool to do system profiling, symbol names of >> running Java methods cannot be decoded, resulting in unhelpful output >> such as: >> >> 10.52% [JIT] tid 236748 [.] 0x7f6fdb75d223 >> >> Perf can read a simp

Re: RFR: 8255072: [TESTBUG] com/sun/jdi/EATests.java should not fail if expected VMOutOfMemoryException is not thrown [v3]

2020-10-26 Thread Serguei Spitsyn
On Thu, 22 Oct 2020 20:35:29 GMT, Richard Reingruber wrote: >> The following test cases try to provoke VMOutOfMemoryException during object >> reallocation because of JVMTI PopFrame / ForceEarlyReturn: >> >> EAPopFrameNotInlinedReallocFailure >> EAPopInlinedMethodWithScalarReplacedObjectsReallo

Re: RFR: 8252117: com/sun/jdi/BadHandshakeTest.java failed with "ConnectException: Connection refused: connect" [v2]

2020-10-26 Thread Serguei Spitsyn
On Fri, 23 Oct 2020 22:44:50 GMT, Alex Menkov wrote: >> Please review the fix for BadHandshakeTest. >> Summary: >> The test verifies that bad (testcase1) or incomplete (testcase2) handshake >> does not cause debuggee termination. >> To check this it tries to attach to the debuggee again (connect

Re: RFR: 8252103: Parallel heap inspection for ParallelScavengeHeap [v4]

2020-10-26 Thread Lin Zang
On Thu, 22 Oct 2020 08:54:58 GMT, Stefan Johansson wrote: >> Lin Zang has refreshed the contents of this pull request, and previous >> commits have been removed. The incremental views will show differences >> compared to the previous content of the PR. > > Took a second look today and found two

Re: RFR: 8252103: Parallel heap inspection for ParallelScavengeHeap [v5]

2020-10-26 Thread Lin Zang
> - Parallel heap iteration support for PSS > - JBS: https://bugs.openjdk.java.net/browse/JDK-8252103 Lin Zang has updated the pull request incrementally with one additional commit since the last revision: Refine HeapBlockClaimer implementation - Changes: - all: https://git.op

Re: RFR: 8254723: add diagnostic command to write Linux perf map file [v2]

2020-10-26 Thread David Holmes
On Mon, 26 Oct 2020 06:10:52 GMT, Nick Gasson wrote: >>> >>> 1. Like Alexey, I would really wish for an print-at-exit switch. The >>> common naming seems to be xxxAtExit (so not, OnExit). "PrintXxx" seems to >>> be printing stuff out to tty, "DumpXxxx" for writing separate files (e.g. >>>