On Wed, 11 Nov 2020 22:53:08 GMT, Daniel D. Daugherty
wrote:
>> test/hotspot/jtreg/vmTestbase/nsk/jvmti/GetCurrentContendedMonitor/contmon002.java
>> line 61:
>>
>>> 59:
>>> 60: public static int run(String argv[], PrintStream ref) {
>>> 61: doSleep(); // If it would do any class
On Wed, 11 Nov 2020 22:43:49 GMT, Daniel D. Daugherty
wrote:
>> As the stack trace in the bug shows, we cannot load classes, since we may
>> take a monitor.
>> Resulting in an unexpected result to GetCurrentContendedMonitor().
>> Trying to use some decent primitive, e.g. Wicket/Semaphore/.., wi
On Wed, 11 Nov 2020 22:55:16 GMT, Daniel D. Daugherty
wrote:
>> As the stack trace in the bug shows, we cannot load classes, since we may
>> take a monitor.
>> Resulting in an unexpected result to GetCurrentContendedMonitor().
>> Trying to use some decent primitive, e.g. Wicket/Semaphore/.., wi
On Fri, 6 Nov 2020 12:54:28 GMT, Lin Zang wrote:
> The implementation of jmap tool depends on the implementation of object
> iteration by different GC heap.
> This patch extend the BasicJMapTest to cover differet GC Heap.
This pull request has now been integrated.
Changeset: 14e25e20
Author:
On Mon, 19 Oct 2020 01:32:45 GMT, Yasumasa Suenaga wrote:
>>> * Q1: Is it necessary to call the Agent_OnUnload()?
>>
>> [JVMTI spec of
>> Agent_OnUnload()](https://docs.oracle.com/en/java/javase/15/docs/specs/jvmti.html#onunload)
>> says this function will be called when the agent library will
On Wed, 11 Nov 2020 15:38:10 GMT, Thomas Schatzl wrote:
>> Hi all,
>>
>> can I get reviews for this change that removes the "Allocation of old
>> generation of Java heap on alternate memory devices" functionality
>> introduced with JDK 12 with
>> [JDK-8202286](https://bugs.openjdk.java.net/
On 12/11/2020 8:57 am, Daniel D.Daugherty wrote:
On Wed, 11 Nov 2020 20:33:15 GMT, Robbin Ehn wrote:
As the stack trace in the bug shows, we cannot load classes, since we may take
a monitor.
Resulting in an unexpected result to GetCurrentContendedMonitor().
Trying to use some decent primitive
On Wed, 11 Nov 2020 20:33:15 GMT, Robbin Ehn wrote:
> As the stack trace in the bug shows, we cannot load classes, since we may
> take a monitor.
> Resulting in an unexpected result to GetCurrentContendedMonitor().
> Trying to use some decent primitive, e.g. Wicket/Semaphore/.., without being
>
On Wed, 11 Nov 2020 22:33:57 GMT, Patricio Chilano Mateo
wrote:
>> As the stack trace in the bug shows, we cannot load classes, since we may
>> take a monitor.
>> Resulting in an unexpected result to GetCurrentContendedMonitor().
>> Trying to use some decent primitive, e.g. Wicket/Semaphore/..,
On Wed, 11 Nov 2020 20:33:15 GMT, Robbin Ehn wrote:
> As the stack trace in the bug shows, we cannot load classes, since we may
> take a monitor.
> Resulting in an unexpected result to GetCurrentContendedMonitor().
> Trying to use some decent primitive, e.g. Wicket/Semaphore/.., without being
>
On Wed, 11 Nov 2020 20:33:15 GMT, Robbin Ehn wrote:
> As the stack trace in the bug shows, we cannot load classes, since we may
> take a monitor.
> Resulting in an unexpected result to GetCurrentContendedMonitor().
> Trying to use some decent primitive, e.g. Wicket/Semaphore/.., without being
>
On Wed, 11 Nov 2020 20:33:15 GMT, Robbin Ehn wrote:
> As the stack trace in the bug shows, we cannot load classes, since we may
> take a monitor.
> Resulting in an unexpected result to GetCurrentContendedMonitor().
> Trying to use some decent primitive, e.g. Wicket/Semaphore/.., without being
>
On 11/11/2020 7:51 am, Daniel D.Daugherty wrote:
On Tue, 10 Nov 2020 21:16:33 GMT, Robbin Ehn wrote:
So if I narrow the scope around the ThreadBlockInVM, then it would be fine?
{
// Honor block request.
ThreadBlockInVM tbivm(self);
}
I can make that change before I integrate...
Yes t
On 12/11/2020 2:39 am, Daniel D.Daugherty wrote:
On Wed, 11 Nov 2020 05:12:21 GMT, David Holmes wrote:
Daniel D. Daugherty has updated the pull request incrementally with one
additional commit since the last revision:
resolve more robehn and coleenp comments.
One change requested in rel
On Wed, 11 Nov 2020 20:33:15 GMT, Robbin Ehn wrote:
> As the stack trace in the bug shows, we cannot load classes, since we may
> take a monitor.
> Resulting in an unexpected result to GetCurrentContendedMonitor().
> Trying to use some decent primitive, e.g. Wicket/Semaphore/.., without being
>
As the stack trace in the bug shows, we cannot load classes, since we may take
a monitor.
Resulting in an unexpected result to GetCurrentContendedMonitor().
Trying to use some decent primitive, e.g. Wicket/Semaphore/.., without being
implementation dependent means we must warm up every possible s
On Tue, 10 Nov 2020 20:13:41 GMT, Serguei Spitsyn wrote:
> One more nit, I forgot to list in my previous comment, is uneeded '()' around
> comparisons:
> `+ static final int REF_SIZE = ((compressedOops == null) || (compressedOops
> == true)) ? 4 : 8;`
Right. Fixed that. Thanks!
-
On Wed, 11 Nov 2020 15:38:10 GMT, Thomas Schatzl wrote:
>> Hi all,
>>
>> can I get reviews for this change that removes the "Allocation of old
>> generation of Java heap on alternate memory devices" functionality
>> introduced with JDK 12 with
>> [JDK-8202286](https://bugs.openjdk.java.net/
On Wed, 11 Nov 2020 15:19:05 GMT, Albert Mingkun Yang wrote:
>> Thomas Schatzl has updated the pull request incrementally with one
>> additional commit since the last revision:
>>
>> ayang review
>
> A general comment for future PRs: I think it's best to isolate mechanical
> changes into the
On Wed, 11 Nov 2020 16:16:19 GMT, Erik Österlund wrote:
>> @coleenp - Nice catch on the missing 'static'.
>
> I typically use size_t for entities that can scale with the size of the
> machine's memory, so I don't have to think about whether there are enough
> bits. Could AvgMonitorsPerThreadEst
On Wed, 11 Nov 2020 05:12:21 GMT, David Holmes wrote:
>> Daniel D. Daugherty has updated the pull request incrementally with one
>> additional commit since the last revision:
>>
>> resolve more robehn and coleenp comments.
>
> One change requested in relation to use of jint instead of size_t.
On Wed, 11 Nov 2020 16:18:41 GMT, Robbin Ehn wrote:
>> Daniel D. Daugherty has updated the pull request with a new target base due
>> to a merge or a rebase. The pull request now contains ten commits:
>>
>> - @dholmes-ora, @robehn and @coleenp CR - a few more minor tweaks.
>> - Merge branch '
On Tue, 13 Oct 2020 20:31:44 GMT, Daniel D. Daugherty
wrote:
> Changes from @fisk and @dcubed-ojdk to:
>
> - simplify ObjectMonitor list management
> - get rid of Type-Stable Memory (TSM)
>
> This change has been tested with Mach5 Tier[1-3],4,5,6,7,8; no new
> regressions.
> Aurora Perf runs
On Wed, 11 Nov 2020 16:01:15 GMT, Daniel D. Daugherty
wrote:
>> Changes from @fisk and @dcubed-ojdk to:
>>
>> - simplify ObjectMonitor list management
>> - get rid of Type-Stable Memory (TSM)
>>
>> This change has been tested with Mach5 Tier[1-3],4,5,6,7,8; no new
>> regressions.
>> Aurora Pe
On Wed, 11 Nov 2020 15:23:15 GMT, Daniel D. Daugherty
wrote:
>> Our int types are really confused. AvgMonitorsPerThreadEstimate is defined
>> as an intx which is intptr_t and the range of it is 0..max_jint which is 0
>> .. 0x7fff . jint is long on windows (the problematic type) and int on
> Changes from @fisk and @dcubed-ojdk to:
>
> - simplify ObjectMonitor list management
> - get rid of Type-Stable Memory (TSM)
>
> This change has been tested with Mach5 Tier[1-3],4,5,6,7,8; no new
> regressions.
> Aurora Perf runs have also been done (DaCapo-h2, Quick Startup/Footprint,
> SPECj
On Wed, 11 Nov 2020 15:10:54 GMT, Igor Ignatyev wrote:
>> Lin Zang has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> Add test id
>
> Hi @linzang ,
>
> it all looks good to me, I'd, however, keep `@build` tags as they were
> before, this
On Wed, 11 Nov 2020 15:09:44 GMT, Albert Mingkun Yang wrote:
>> Thomas Schatzl has updated the pull request incrementally with one
>> additional commit since the last revision:
>>
>> ayang review
>
> test/hotspot/jtreg/TEST.ROOT line 78:
>
>> 76: vm.musl \
>> 77: docker.support \
>>
> The implementation of jmap tool depends on the implementation of object
> iteration by different GC heap.
> This patch extend the BasicJMapTest to cover differet GC Heap.
Lin Zang has updated the pull request incrementally with one additional commit
since the last revision:
recover build ta
On Wed, 11 Nov 2020 15:42:36 GMT, Lin Zang wrote:
>> The implementation of jmap tool depends on the implementation of object
>> iteration by different GC heap.
>> This patch extend the BasicJMapTest to cover differet GC Heap.
>
> Lin Zang has updated the pull request incrementally with one addit
> Hi all,
>
> can I get reviews for this change that removes the "Allocation of old
> generation of Java heap on alternate memory devices" functionality introduced
> with JDK 12 with
> [JDK-8202286](https://bugs.openjdk.java.net/browse/JDK-8202286) due to being
>
> - not used by anyone
> - n
On Wed, 11 Nov 2020 13:50:08 GMT, Coleen Phillimore wrote:
>> src/hotspot/share/runtime/synchronizer.cpp line 246:
>>
>>> 244: //
>>> 245: // Start the ceiling with the estimate for one thread:
>>> 246: jint _in_use_list_ceiling = AvgMonitorsPerThreadEstimate;
>>
>> Why is this a jint when you
On Wed, 11 Nov 2020 11:11:25 GMT, Thomas Schatzl wrote:
> Hi all,
>
> can I get reviews for this change that removes the "Allocation of old
> generation of Java heap on alternate memory devices" functionality introduced
> with JDK 12 with
> [JDK-8202286](https://bugs.openjdk.java.net/browse
On Wed, 11 Nov 2020 05:12:21 GMT, David Holmes wrote:
>> Daniel D. Daugherty has updated the pull request incrementally with one
>> additional commit since the last revision:
>>
>> resolve more robehn and coleenp comments.
>
> One change requested in relation to use of jint instead of size_t.
On Wed, 11 Nov 2020 13:50:08 GMT, Coleen Phillimore wrote:
>> src/hotspot/share/runtime/synchronizer.cpp line 246:
>>
>>> 244: //
>>> 245: // Start the ceiling with the estimate for one thread:
>>> 246: jint _in_use_list_ceiling = AvgMonitorsPerThreadEstimate;
>>
>> Why is this a jint when you
On Wed, 11 Nov 2020 11:24:08 GMT, Lin Zang wrote:
>> The implementation of jmap tool depends on the implementation of object
>> iteration by different GC heap.
>> This patch extend the BasicJMapTest to cover differet GC Heap.
>
> Lin Zang has updated the pull request incrementally with one addit
On Wed, 11 Nov 2020 08:26:14 GMT, Robbin Ehn wrote:
>> Daniel D. Daugherty has updated the pull request incrementally with one
>> additional commit since the last revision:
>>
>> resolve more robehn and coleenp comments.
>
> src/hotspot/share/runtime/synchronizer.cpp line 1226:
>
>> 1224:
On Wed, 11 Nov 2020 04:50:52 GMT, David Holmes wrote:
>> Daniel D. Daugherty has updated the pull request incrementally with one
>> additional commit since the last revision:
>>
>> resolve more robehn and coleenp comments.
>
> src/hotspot/share/runtime/synchronizer.cpp line 153:
>
>> 151:
Hi Thomas,
I think this makes sense. Just a question, how are your thoughts about
JEP316? Do you consider AllocateHeapAt similarly unused?
Cheers, Thomas
On Wed, Nov 11, 2020 at 2:17 PM Thomas Schatzl
wrote:
> Hi all,
>
> can I get reviews for this change that removes the "Allocation of old
On Tue, 10 Nov 2020 23:24:24 GMT, Daniel D. Daugherty
wrote:
>> Changes from @fisk and @dcubed-ojdk to:
>>
>> - simplify ObjectMonitor list management
>> - get rid of Type-Stable Memory (TSM)
>>
>> This change has been tested with Mach5 Tier[1-3],4,5,6,7,8; no new
>> regressions.
>> Aurora Pe
On Wed, 11 Nov 2020 05:11:10 GMT, David Holmes wrote:
>> Daniel D. Daugherty has updated the pull request incrementally with one
>> additional commit since the last revision:
>>
>> resolve more robehn and coleenp comments.
>
> src/hotspot/share/runtime/synchronizer.cpp line 246:
>
>> 244: //
On Tue, 10 Nov 2020 23:24:24 GMT, Daniel D. Daugherty
wrote:
>> Changes from @fisk and @dcubed-ojdk to:
>>
>> - simplify ObjectMonitor list management
>> - get rid of Type-Stable Memory (TSM)
>>
>> This change has been tested with Mach5 Tier[1-3],4,5,6,7,8; no new
>> regressions.
>> Aurora Pe
Hi all,
can I get reviews for this change that removes the "Allocation of old
generation of Java heap on alternate memory devices" functionality introduced
with JDK 12 with
[JDK-8202286](https://bugs.openjdk.java.net/browse/JDK-8202286) due to being
- not used by anyone
- not maintained by a
On Wed, 11 Nov 2020 11:13:29 GMT, Aleksey Shipilev wrote:
>> Lin Zang has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> Refine the test configuration.
>
> I think it is fine to omit Epsilon from this testing. There is another trick
> you
> The implementation of jmap tool depends on the implementation of object
> iteration by different GC heap.
> This patch extend the BasicJMapTest to cover differet GC Heap.
Lin Zang has updated the pull request incrementally with one additional commit
since the last revision:
Add test id
---
On Wed, 11 Nov 2020 10:48:12 GMT, Lin Zang wrote:
>> The implementation of jmap tool depends on the implementation of object
>> iteration by different GC heap.
>> This patch extend the BasicJMapTest to cover differet GC Heap.
>
> Lin Zang has updated the pull request incrementally with one addit
On Tue, 10 Nov 2020 17:50:26 GMT, Aleksey Shipilev wrote:
>> Lin Zang has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> Refine the test configuration.
>
> I believe this would fail when some GCs are not available. For example, in
> Minima
> The implementation of jmap tool depends on the implementation of object
> iteration by different GC heap.
> This patch extend the BasicJMapTest to cover differet GC Heap.
Lin Zang has updated the pull request incrementally with one additional commit
since the last revision:
Refine the test
> This is fork off the SizeOf JEP, JDK-8249196. There is already the entry
> point in JDK that can use the intrinsic like this:
> `Instrumentation.getInstanceSize`. Therefore, we can implement the C1/C2
> intrinsic now, hook it up to `Instrumentation`, and let the tools use that
> fast path tod
> The implementation of jmap tool depends on the implementation of object
> iteration by different GC heap.
> This patch extend the BasicJMapTest to cover differet GC Heap.
Lin Zang has updated the pull request with a new target base due to a merge or
a rebase. The incremental webrev excludes th
On Tue, 10 Nov 2020 23:24:24 GMT, Daniel D. Daugherty
wrote:
>> Changes from @fisk and @dcubed-ojdk to:
>>
>> - simplify ObjectMonitor list management
>> - get rid of Type-Stable Memory (TSM)
>>
>> This change has been tested with Mach5 Tier[1-3],4,5,6,7,8; no new
>> regressions.
>> Aurora Pe
51 matches
Mail list logo
