Re: RFR: 8252657: JVMTI agent is not unloaded when Agent_OnAttach is failed

2020-11-23 Thread Yasumasa Suenaga
On Thu, 12 Nov 2020 01:34:33 GMT, Yasumasa Suenaga wrote: >> If we can change the spec that agent library would not be unloaded when >> `Agent_OnAttach()` failed, we can change like >> [webrev.00](https://cr.openjdk.java.net/~ysuenaga/JDK-8252657/webrev.00/). >> It is simple, and similar behav

Re: RFR: 8252657: JVMTI agent is not unloaded when Agent_OnAttach is failed [v2]

2020-11-23 Thread Yasumasa Suenaga
> If `Agent_OnAttach()` in JVMTI agent which is attempted to load via > JVMTI.agent_load dcmd is failed, it would not be unloaded. > We've [discussed it on > serviceability-dev](https://mail.openjdk.java.net/pipermail/serviceability-dev/2020-September/032839.html). > This PR is a continuation

Re: RFR: 8254001: [Metrics] Enhance parsing of cgroup interface files for version detection

2020-11-23 Thread Severin Gehwolf
On Mon, 23 Nov 2020 19:39:18 GMT, Poonam Bajaj wrote: > With respect to JDK-8255908, the changes look good to me. Thanks! - PR: https://git.openjdk.java.net/jdk/pull/1393

Re: RFR: 8254001: [Metrics] Enhance parsing of cgroup interface files for version detection

2020-11-23 Thread Severin Gehwolf
On Mon, 23 Nov 2020 19:56:56 GMT, Severin Gehwolf wrote: >> With respect to JDK-8255908, the changes look good to me. > >> With respect to JDK-8255908, the changes look good to me. > > Thanks! @bobvandette Please review when you've got some cycles to spare. Much appreciated! - PR

Re: RFR: 8254001: [Metrics] Enhance parsing of cgroup interface files for version detection

2020-11-23 Thread Poonam Bajaj
On Mon, 23 Nov 2020 15:50:18 GMT, Severin Gehwolf wrote: >> This is an enhancement which solves two issues: >> >> 1. Multiple reads of relevant cgroup interface files. Now interface files >> are only read once per file (just like Hotspot). >> 2. Proxies creation of the impl specific subsystem v

Re: RFR: 8254001: [Metrics] Enhance parsing of cgroup interface files for version detection

2020-11-23 Thread Severin Gehwolf
On Mon, 23 Nov 2020 15:46:56 GMT, Severin Gehwolf wrote: > This is an enhancement which solves two issues: > > 1. Multiple reads of relevant cgroup interface files. Now interface files are > only read once per file (just like Hotspot). > 2. Proxies creation of the impl specific subsystem via `d

Re: RFR: 8254001: [Metrics] Enhance parsing of cgroup interface files for version detection

2020-11-23 Thread Severin Gehwolf
On Mon, 23 Nov 2020 15:46:56 GMT, Severin Gehwolf wrote: > This is an enhancement which solves two issues: > > 1. Multiple reads of relevant cgroup interface files. Now interface files are > only read once per file (just like Hotspot). > 2. Proxies creation of the impl specific subsystem via `d

RFR: 8254001: [Metrics] Enhance parsing of cgroup interface files for version detection

2020-11-23 Thread Severin Gehwolf
This is an enhancement which solves two issues: 1. Multiple reads of relevant cgroup interface files. Now interface files are only read once per file (just like Hotspot). 2. Proxies creation of the impl specific subsystem via `determineType()` as before, but now reads all relevant interface file

Integrated: 8256741: Reduce footprint of compiler interface data structures

2020-11-23 Thread Claes Redestad
On Fri, 20 Nov 2020 12:19:48 GMT, Claes Redestad wrote: > A few data structure in the ci allocate unconditionally created > GrowableArrays out-of-line, have fields that are newer updated/read, or are > unnecessarily cached. By cleaning this up we can slightly reduce memory used > for JIT compi

Re: RFR: 8256741: Reduce footprint of compiler interface data structures

2020-11-23 Thread Claes Redestad
On Fri, 20 Nov 2020 22:51:23 GMT, Chris Plummer wrote: >> A few data structure in the ci allocate unconditionally created >> GrowableArrays out-of-line, have fields that are newer updated/read, or are >> unnecessarily cached. By cleaning this up we can slightly reduce memory used >> for JIT co