Re: RFR: 8256718: Obsolete the long term deprecated and aliased Trace flags [v3]

2020-12-02 Thread David Holmes
On Wed, 2 Dec 2020 18:44:08 GMT, Harold Seigel wrote: >> Please review this change to obsolete the deprecated and aliased Trace >> flags. The now empty aliased_logging_flags support was left in >> arguments.cpp for use by trace flags that get deprecated and aliased in the >> future. >> >> Wi

Re: RFR: 8256718: Obsolete the long term deprecated and aliased Trace flags [v3]

2020-12-02 Thread Ioi Lam
On Wed, 2 Dec 2020 18:44:08 GMT, Harold Seigel wrote: >> Please review this change to obsolete the deprecated and aliased Trace >> flags. The now empty aliased_logging_flags support was left in >> arguments.cpp for use by trace flags that get deprecated and aliased in the >> future. >> >> Wi

Integrated: 8257623: vmTestbase/nsk/jvmti/ResourceExhausted/resexhausted001/TestDescription.java shouldn't use timeout

2020-12-02 Thread Leonid Mesnik
On Wed, 2 Dec 2020 19:13:50 GMT, Leonid Mesnik wrote: > The test is manual and shouldn't use the timeout This pull request has now been integrated. Changeset: 3e89981d Author:Leonid Mesnik URL: https://git.openjdk.java.net/jdk/commit/3e89981d Stats: 1 line in 1 file changed: 0 in

Re: RFR: 8257623: vmTestbase/nsk/jvmti/ResourceExhausted/resexhausted001/TestDescription.java shouldn't use timeout

2020-12-02 Thread Daniel D . Daugherty
On Wed, 2 Dec 2020 19:13:50 GMT, Leonid Mesnik wrote: > The test is manual and shouldn't use the timeout Thumbs up. This is a trivial change and does not need to wait 24 hours. - Marked as reviewed by dcubed (Reviewer). PR: https://git.openjdk.java.net/jdk/pull/1573

Re: RFR: 8256718: Obsolete the long term deprecated and aliased Trace flags [v3]

2020-12-02 Thread Serguei Spitsyn
On Wed, 2 Dec 2020 18:44:08 GMT, Harold Seigel wrote: >> Please review this change to obsolete the deprecated and aliased Trace >> flags. The now empty aliased_logging_flags support was left in >> arguments.cpp for use by trace flags that get deprecated and aliased in the >> future. >> >> Wi

Re: RFR: 8257623: vmTestbase/nsk/jvmti/ResourceExhausted/resexhausted001/TestDescription.java shouldn't use timeout

2020-12-02 Thread Serguei Spitsyn
On Wed, 2 Dec 2020 19:13:50 GMT, Leonid Mesnik wrote: > The test is manual and shouldn't use the timeout Hi Leonid, It looks good. Thanks, Serguei - Marked as reviewed by sspitsyn (Reviewer). PR: https://git.openjdk.java.net/jdk/pull/1573

RFR: 8257623: vmTestbase/nsk/jvmti/ResourceExhausted/resexhausted001/TestDescription.java shouldn't use timeout

2020-12-02 Thread Leonid Mesnik
The test is manual and shouldn't use the timeout - Commit messages: - 8257623: vmTestbase/nsk/jvmti/ResourceExhausted/resexhausted001/TestDescription.java shoudln't use timeout Changes: https://git.openjdk.java.net/jdk/pull/1573/files Webrev: https://webrevs.openjdk.java.net/?rep

Re: RFR: 8256718: Obsolete the long term deprecated and aliased Trace flags [v2]

2020-12-02 Thread Harold Seigel
On Wed, 2 Dec 2020 02:42:18 GMT, David Holmes wrote: >> Harold Seigel has updated the pull request incrementally with one additional >> commit since the last revision: >> >> 8256718: Obsolete the long term deprecated and aliased Trace flags > > I'm still pushing for treating all flags the sam

Re: RFR: 8256718: Obsolete the long term deprecated and aliased Trace flags [v3]

2020-12-02 Thread Harold Seigel
On Tue, 1 Dec 2020 12:02:57 GMT, Coleen Phillimore wrote: >> Harold Seigel has updated the pull request incrementally with one additional >> commit since the last revision: >> >> 8256718: Obsolete the long term deprecated and aliased Trace flags > > src/hotspot/share/runtime/arguments.cpp lin

Re: RFR: 8256718: Obsolete the long term deprecated and aliased Trace flags [v3]

2020-12-02 Thread Harold Seigel
> Please review this change to obsolete the deprecated and aliased Trace flags. > The now empty aliased_logging_flags support was left in arguments.cpp for > use by trace flags that get deprecated and aliased in the future. > > With this change, users will get the following example messages whe

Integrated: 8257140: Crash in JvmtiTagMap::flush_object_free_events()

2020-12-02 Thread Coleen Phillimore
On Tue, 1 Dec 2020 12:44:24 GMT, Coleen Phillimore wrote: > The JvmtiTagMap can be deleted while it is posting. The JvmtiEnv is still on > the list but the env is "disposed" of and the tag_map is deleted to save > memory until the JvmtiEnv can be reclaimed at a safepoint and taken off the > l

Re: RFR: 8257140: Crash in JvmtiTagMap::flush_object_free_events() [v2]

2020-12-02 Thread Kim Barrett
On Tue, 1 Dec 2020 14:19:15 GMT, Coleen Phillimore wrote: >> The JvmtiTagMap can be deleted while it is posting. The JvmtiEnv is still >> on the list but the env is "disposed" of and the tag_map is deleted to save >> memory until the JvmtiEnv can be reclaimed at a safepoint and taken off the

Re: RFR: 8257140: Crash in JvmtiTagMap::flush_object_free_events() [v2]

2020-12-02 Thread Coleen Phillimore
On Wed, 2 Dec 2020 14:07:31 GMT, Kim Barrett wrote: >> Coleen Phillimore has updated the pull request with a new target base due to >> a merge or a rebase. The incremental webrev excludes the unrelated changes >> brought in by the merge/rebase. The pull request contains three additional >> com

Integrated: 8253916: ResourceExhausted/resexhausted001 crashes on Linux-x64

2020-12-02 Thread Coleen Phillimore
On Tue, 1 Dec 2020 12:55:05 GMT, Coleen Phillimore wrote: > Give an error message rather than logging the error and then crashing later > because the JVM can't detect stack overflow. In a resource exhausted > situation, thread creation is also failing. This is the > vm_exit_out_of_memory mes

Re: RFR: 8253916: ResourceExhausted/resexhausted001 crashes on Linux-x64 [v2]

2020-12-02 Thread Coleen Phillimore
On Wed, 2 Dec 2020 04:49:12 GMT, Leonid Mesnik wrote: >> These tests are unreliable and this change will simply give a better error >> message when they fail. > > Sorry, I've missed the answer to the same question. Thanks Leonid, I didn't really have a better thing to do with these tests becau