Integrated: 8259627: Potential memory leaks in JVMTI after JDK-8227745

2021-01-14 Thread Richard Reingruber
On Tue, 12 Jan 2021 19:09:43 GMT, Richard Reingruber wrote: > This change eliminates memory leaks in the JVMTI implementation reported by > SonarCloud. > > The leaks occur when the Java heap is exhausted. This pull request has now been integrated. Changeset: 6d4a593f Author:Richard

RFR: 8065773: JDI: UOE is not thrown, when redefineClasses changes a class modifier

2021-01-14 Thread Leonid Mesnik
The test failed because it expects that public/protected/default/private and static modifiers differ on the JVM level like in Java source code. However, only the ACC_PUBLIC modifier has an effect on interfaces. Here is my proposal from bug comments: I looked at the test and checked bytecode

Integrated: 8252657: JVMTI agent is not unloaded when Agent_OnAttach is failed

2021-01-14 Thread Yasumasa Suenaga
On Sat, 5 Sep 2020 14:26:17 GMT, Yasumasa Suenaga wrote: > If `Agent_OnAttach()` in JVMTI agent which is attempted to load via > JVMTI.agent_load dcmd is failed, it would not be unloaded. > We've [discussed it on >

Re: RFR: 8252657: JVMTI agent is not unloaded when Agent_OnAttach is failed [v3]

2021-01-14 Thread Serguei Spitsyn
On Thu, 14 Jan 2021 03:08:19 GMT, Yasumasa Suenaga wrote: >> If `Agent_OnAttach()` in JVMTI agent which is attempted to load via >> JVMTI.agent_load dcmd is failed, it would not be unloaded. >> We've [discussed it on >>

Integrated: 8258652: Assert in JvmtiThreadState::cur_stack_depth() can noticeably slow down debugging single stepping

2021-01-14 Thread Chris Plummer
On Fri, 18 Dec 2020 02:01:28 GMT, Chris Plummer wrote: > There is an assert in `JvmtiThreadState::cur_stack_depth()` that tends to > slow down single stepping a lot when running the debuggee with a debug jvm. > See CR for details. The fix is to allow disabling of this assert using the > new

Re: RFR: 8259799: vmTestbase/nsk/jvmti/Breakpoint/breakpoint001 is incorrect [v2]

2021-01-14 Thread Chris Plummer
On Thu, 14 Jan 2021 20:32:17 GMT, Leonid Mesnik wrote: >> est vmTestbase/nsk/jvmti/Breakpoint/breakpoint001 has incorrect check of >> strcmp results here: >> >> for (i=0; i> if (strcmp(methNam,METHODS[i][0]) && >> strcmp(methSig,METHODS[i][1])) { >>

Re: RFR: 8252657: JVMTI agent is not unloaded when Agent_OnAttach is failed [v3]

2021-01-14 Thread David Holmes
On 14/01/2021 6:29 pm, Yasumasa Suenaga wrote: On Thu, 14 Jan 2021 07:19:06 GMT, David Holmes wrote: Hi Yasumasa, Spec update looks good. VM tweak to call dll_unload on failure looks good. Thanks! I don't understand the test change though. To check the agent is unloaded, call

Re: RFR: 8259799: vmTestbase/nsk/jvmti/Breakpoint/breakpoint001 is incorrect [v2]

2021-01-14 Thread Serguei Spitsyn
On Thu, 14 Jan 2021 20:32:17 GMT, Leonid Mesnik wrote: >> est vmTestbase/nsk/jvmti/Breakpoint/breakpoint001 has incorrect check of >> strcmp results here: >> >> for (i=0; i> if (strcmp(methNam,METHODS[i][0]) && >> strcmp(methSig,METHODS[i][1])) { >>

Integrated: 8259350: Add some internal debugging APIs to the debug agent

2021-01-14 Thread Chris Plummer
On Thu, 7 Jan 2021 04:28:19 GMT, Chris Plummer wrote: > This PR adds some APIs that are useful when debugging the debug agent. They > can be called from gdb or from other parts of the debug agent. They mostly do > things like dumping internal data structures that are tedious to dump or >

Re: RFR: 8259799: vmTestbase/nsk/jvmti/Breakpoint/breakpoint001 is incorrect [v2]

2021-01-14 Thread Igor Ignatyev
On Thu, 14 Jan 2021 20:32:17 GMT, Leonid Mesnik wrote: >> est vmTestbase/nsk/jvmti/Breakpoint/breakpoint001 has incorrect check of >> strcmp results here: >> >> for (i=0; i> if (strcmp(methNam,METHODS[i][0]) && >> strcmp(methSig,METHODS[i][1])) { >>

Re: RFR: 8259799: vmTestbase/nsk/jvmti/Breakpoint/breakpoint001 is incorrect [v2]

2021-01-14 Thread Leonid Mesnik
On Thu, 14 Jan 2021 19:22:07 GMT, Igor Ignatyev wrote: >> Leonid Mesnik has updated the pull request incrementally with one additional >> commit since the last revision: >> >> copyrights and ident fixed > > test/hotspot/jtreg/vmTestbase/nsk/jvmti/Breakpoint/breakpoint001/breakpoint001.cpp >

Re: RFR: 8259799: vmTestbase/nsk/jvmti/Breakpoint/breakpoint001 is incorrect [v2]

2021-01-14 Thread Leonid Mesnik
> est vmTestbase/nsk/jvmti/Breakpoint/breakpoint001 has incorrect check of > strcmp results here: > > for (i=0; i if (strcmp(methNam,METHODS[i][0]) && > strcmp(methSig,METHODS[i][1])) { > printf("CHECK PASSED: method name: "%s"\tsignature: "%s" %d\n", >

Fwd: CSR: 8259798: Add jcmd option to dump CDS

2021-01-14 Thread Yumin Qi
Oops, push send too soon. Thanks Yumin Forwarded Message Subject:CSR: 8259798: Add jcmd option to dump CDS Date: Thu, 14 Jan 2021 12:03:38 -0800 From: Yumin Qi To: hotspot-runtime-...@openjdk.java.net Hi, All   I have created bug and CSR for this issue

Re: RFR: 8258652: Assert in JvmtiThreadState::cur_stack_depth() can noticeably slow down debugging single stepping

2021-01-14 Thread Alex Menkov
On Fri, 18 Dec 2020 02:01:28 GMT, Chris Plummer wrote: > There is an assert in `JvmtiThreadState::cur_stack_depth()` that tends to > slow down single stepping a lot when running the debuggee with a debug jvm. > See CR for details. The fix is to allow disabling of this assert using the > new

Re: RFR: 8259350: Add some internal debugging APIs to the debug agent

2021-01-14 Thread Alex Menkov
On Thu, 7 Jan 2021 04:28:19 GMT, Chris Plummer wrote: > This PR adds some APIs that are useful when debugging the debug agent. They > can be called from gdb or from other parts of the debug agent. They mostly do > things like dumping internal data structures that are tedious to dump or >

Re: RFR: 8259799: vmTestbase/nsk/jvmti/Breakpoint/breakpoint001 is incorrect

2021-01-14 Thread Igor Ignatyev
On Thu, 14 Jan 2021 19:09:59 GMT, Leonid Mesnik wrote: > est vmTestbase/nsk/jvmti/Breakpoint/breakpoint001 has incorrect check of > strcmp results here: > > for (i=0; i if (strcmp(methNam,METHODS[i][0]) && > strcmp(methSig,METHODS[i][1])) { > printf("CHECK

RFR: 8259799: vmTestbase/nsk/jvmti/Breakpoint/breakpoint001 is incorrect

2021-01-14 Thread Leonid Mesnik
est vmTestbase/nsk/jvmti/Breakpoint/breakpoint001 has incorrect check of strcmp results here: for (i=0; ihttps://git.openjdk.java.net/jdk/pull/2084/files Webrev: https://webrevs.openjdk.java.net/?repo=jdk=2084=00 Issue: https://bugs.openjdk.java.net/browse/JDK-8259799 Stats: 3 lines in 1

Re: RFR: 8252657: JVMTI agent is not unloaded when Agent_OnAttach is failed [v3]

2021-01-14 Thread Yasumasa Suenaga
On Thu, 14 Jan 2021 07:19:06 GMT, David Holmes wrote: > Hi Yasumasa, > > Spec update looks good. > > VM tweak to call dll_unload on failure looks good. Thanks! > I don't understand the test change though. To check the agent is unloaded, call VM.dynlibs dcmd and check whether agent path is