Re: RFR: 8259008: ArithmeticException was thrown at "Monitor Cache Dump" on HSDB

2021-01-18 Thread David Holmes
On Wed, 30 Dec 2020 13:51:04 GMT, Yasumasa Suenaga wrote: > I saw the exception as following when I chose "Monitor Cache Dump" menu on > HSDB: > > Exception in thread "AWT-EventQueue-0" java.lang.ExceptionInInitializerError > at > jdk.hotspot.agent/sun.jvm.hotspot.ui.MonitorCacheDumpPa

Re: RFR: 8257234 : Add gz option to SA jmap to write a gzipped heap dump [v3]

2021-01-18 Thread Lin Zang
On Fri, 8 Jan 2021 13:21:21 GMT, Lin Zang wrote: >> Changes requested by cjplummer (Reviewer). > > Hi @plummercj , > Thanks very much for reviewing! > Sorry that I got stuck on other work and didn't read review message timely. > I will go through your suggestions carefully and try to fix all is

Re: RFR: 8257234 : Add gz option to SA jmap to write a gzipped heap dump [v6]

2021-01-18 Thread Lin Zang
> 8257234 : Add gz option to SA jmap to write a gzipped heap dump Lin Zang has updated the pull request incrementally with one additional commit since the last revision: code refine - Changes: - all: https://git.openjdk.java.net/jdk/pull/1712/files - new: https://git.openjdk.

Re: RFR: 8257234 : Add gz option to SA jmap to write a gzipped heap dump [v5]

2021-01-18 Thread Lin Zang
> 8257234 : Add gz option to SA jmap to write a gzipped heap dump Lin Zang has updated the pull request with a new target base due to a merge or a rebase. The incremental webrev excludes the unrelated changes brought in by the merge/rebase. The pull request contains five additional commits since

Re: RFR: 8259008: ArithmeticException was thrown at "Monitor Cache Dump" on HSDB

2021-01-18 Thread Yasumasa Suenaga
On Wed, 30 Dec 2020 13:51:04 GMT, Yasumasa Suenaga wrote: > I saw the exception as following when I chose "Monitor Cache Dump" menu on > HSDB: > > Exception in thread "AWT-EventQueue-0" java.lang.ExceptionInInitializerError > at > jdk.hotspot.agent/sun.jvm.hotspot.ui.MonitorCacheDumpPa

Re: RFR: 8258836: JNI local refs exceed capacity getDiagnosticCommandInfo

2021-01-18 Thread David Holmes
On Mon, 18 Jan 2021 14:10:56 GMT, Severin Gehwolf wrote: > This patch adds some explicit capacity for local refs. New regression test > fails prior and passes after the patch. > > Thoughts? src/jdk.management/share/native/libmanagement_ext/DiagnosticCommandImpl.c line 189: > 187:

Re: RFR: 8257234 : Add gz option to SA jmap to write a gzipped heap dump [v4]

2021-01-18 Thread Lin Zang
> 8257234 : Add gz option to SA jmap to write a gzipped heap dump Lin Zang has updated the pull request incrementally with one additional commit since the last revision: refine segment heap dump - Changes: - all: https://git.openjdk.java.net/jdk/pull/1712/files - new: https:/

[PING] RFR: 8259383: AsyncGetCallTrace() crashes sporadically

2021-01-18 Thread Schmidt, Lutz
Dear All, I would like to bring this RFR back to your attention. Thank you, Lutz On 11.01.21, 19:45, "hotspot-dev on behalf of Lutz Schmidt" wrote: Hi, may I please ask the community to review this small fix? It closes another hole in AsyncGetCallTrace(). Thanks a lot! Lut

RFR: 8258836: JNI local refs exceed capacity getDiagnosticCommandInfo

2021-01-18 Thread Severin Gehwolf
This patch adds some explicit capacity for local refs. New regression test fails prior and passes after the patch. Thoughts? - Commit messages: - 8258836: JNI local refs exceed capacity getDiagnosticCommandInfo Changes: https://git.openjdk.java.net/jdk/pull/2130/files Webrev: http

Re: RFR: 8257733: Move module-specific data from make to respective module

2021-01-18 Thread Magnus Ihse Bursie
On 2021-01-15 19:27, mark.reinh...@oracle.com wrote: Feature JEPs are living documents until such time as they are delivered. In this case it would not be appropriate to update JEP 201, which is as much about the transition from the old source-code layout as it is about the new layout as of 2014.