On Mon, 8 Feb 2021 02:35:17 GMT, Chris Plummer wrote:
>> Hamlin Li has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> improve jcmd GC.class_histogram to support parallel
>
> Marked as reviewed by cjplummer (Reviewer).
Hi Chris, Would you m
On Sun, 7 Feb 2021 08:20:10 GMT, Lin Zang wrote:
>> 8257234 : Add gz option to SA jmap to write a gzipped heap dump
>
> Lin Zang has updated the pull request incrementally with two additional
> commits since the last revision:
>
> - add test in HeapDumpTest and fix in argument parsing
> - rev
On Sun, 7 Feb 2021 12:38:55 GMT, Hamlin Li wrote:
>> parallel -histo of jmap was added by JDK-8214535, it's better to support
>> parallel for jcmd GC.class_histogram too.
>
> Hamlin Li has updated the pull request incrementally with one additional
> commit since the last revision:
>
> improv
On Tue, 2 Feb 2021 23:37:21 GMT, Yasumasa Suenaga wrote:
> We could see NPE on `LinuxCDebugger::loadObjectContainingPC` which is used
> mainly by the clhsdb `findpc` command. (See
> [JDK-8248876](https://bugs.openjdk.java.net/browse/JDK-8248876) for more
> details)
>
> It is caused by PIE exe
On Sun, 7 Feb 2021 03:29:36 GMT, Chris Plummer wrote:
> diagnosticCommand.hpp still needs a copyright update.
>
Thanks for pointing out.
> For heapRegionSet.cpp, sorry but you'll need to file a new CR to update its
> copyright. Among other things, fixing it here makes backports harder to get
>
> parallel -histo of jmap was added by JDK-8214535, it's better to support
> parallel for jcmd GC.class_histogram too.
Hamlin Li has updated the pull request incrementally with one additional commit
since the last revision:
improve jcmd GC.class_histogram to support parallel
-
C
> 8261131: jcmd jmap dump should not accept gz option with no value
Lin Zang has updated the pull request with a new target base due to a merge or
a rebase. The incremental webrev excludes the unrelated changes brought in by
the merge/rebase. The pull request contains three additional commits si
On Thu, 4 Feb 2021 03:54:26 GMT, Chris Plummer wrote:
>> Lin Zang has updated the pull request incrementally with two additional
>> commits since the last revision:
>>
>> - fix an issue of double printing error message.
>> - fix jcmd jmap issue and add test in BascJMapTest and code refine
>
>
> 8257234 : Add gz option to SA jmap to write a gzipped heap dump
Lin Zang has updated the pull request incrementally with two additional commits
since the last revision:
- add test in HeapDumpTest and fix in argument parsing
- revert changes in jcmd jmap
Another PR has been created for
