Re: RFR: 8241403: JavaThread::get_thread_name() should be ThreadSMR-aware

2021-02-11 Thread Robbin Ehn
On Thu, 11 Feb 2021 22:04:53 GMT, Daniel D. Daugherty wrote: > A minor fix to add a new function: > > bool Thread::is_JavaThread_protected(const JavaThread* p) > > that returns true when the target JavaThread* is protected and false > otherwise. Update JavaThread::get_thread_name() to crea

Re: RFR: JDK-8261034: improve jcmd GC.class_histogram to support parallel

2021-02-11 Thread Chris Plummer
On Fri, 12 Feb 2021 01:03:28 GMT, Lin Zang wrote: > So maybe we have two choice here: > * Add a new command for argument extension. so jcmd and jmap could be > consisitent. > * Remove the "parallel" option in jmap, and leave the control to jcmd. Yes, I suppose we can still do the `dum

Re: RFR: JDK-8261034: improve jcmd GC.class_histogram to support parallel

2021-02-11 Thread Lin Zang
On Thu, 11 Feb 2021 22:50:50 GMT, Chris Plummer wrote: >> Dear All, >> I took the liberity to create a PR (#2519) for the "noparallel" option. >> Maybe we could discuss there. And I also found @Hamlin-Li has created a CSR >> for that. Thanks a lot! >> >> BRs, >> Lin > > There is still one mi

Re: RFR: 8252842: Extend jmap to support parallel heap dump [v6]

2021-02-11 Thread Lin Zang
> 8252842: Extend jmap to support parallel heap dump Lin Zang has updated the pull request incrementally with one additional commit since the last revision: Add dumpheapext command for extra argument passing - Changes: - all: https://git.openjdk.java.net/jdk/pull/2261/files -

Re: RFR: 8247514: Improve clhsdb 'findpc' ability to determine what an address points to by improving PointerFinder and PointerLocation classes [v3]

2021-02-11 Thread Chris Plummer
On Tue, 2 Feb 2021 23:21:50 GMT, Yasumasa Suenaga wrote: >> Chris Plummer has updated the pull request incrementally with one additional >> commit since the last revision: >> >> Fix issue with parsing 'examine' output when there is unexecptected output >> due to CDS logging or -Xcheck:jni wa

Re: RFR: 8247514: Improve clhsdb 'findpc' ability to determine what an address points to by improving PointerFinder and PointerLocation classes [v3]

2021-02-11 Thread Chris Plummer
> See the bug for most details. A few notes here about some implementation > details: > > In the `PointerLocation` class, I added more consistency w.r.t. whether or > not a newline is printed. It used to for some address types, but not others. > Now it always does. And if you see a comment some

Integrated: 8260431: com/sun/jdi/JdbOptions.java failed with "RuntimeException: 'prop[boo] = >foo<' missing from stdout/stderr"

2021-02-11 Thread Alex Menkov
On Sat, 30 Jan 2021 00:15:04 GMT, Alex Menkov wrote: > The test expects debuggee output in jdb output stream. > But jdb redirects debuggee output asynchronously so sometimes it's incomplete > or mixed with jdb output. > The fix updates debuggee to print output to file and read/analyze it after

Re: RFR: 8260431: com/sun/jdi/JdbOptions.java failed with "RuntimeException: 'prop[boo] = >foo<' missing from stdout/stderr" [v3]

2021-02-11 Thread Chris Plummer
On Thu, 4 Feb 2021 00:36:57 GMT, Alex Menkov wrote: >> The test expects debuggee output in jdb output stream. >> But jdb redirects debuggee output asynchronously so sometimes it's >> incomplete or mixed with jdb output. >> The fix updates debuggee to print output to file and read/analyze it afte

Re: RFR: 8260431: com/sun/jdi/JdbOptions.java failed with "RuntimeException: 'prop[boo] = >foo<' missing from stdout/stderr" [v2]

2021-02-11 Thread Chris Plummer
On Wed, 3 Feb 2021 23:28:50 GMT, Chris Plummer wrote: >> Alex Menkov has updated the pull request incrementally with one additional >> commit since the last revision: >> >> separated debuggee class name and args > > test/jdk/com/sun/jdi/JdbOptions.java line 91: > >> 89: // the simple

Re: RFR: 8260431: com/sun/jdi/JdbOptions.java failed with "RuntimeException: 'prop[boo] = >foo<' missing from stdout/stderr" [v2]

2021-02-11 Thread Alex Menkov
On Wed, 3 Feb 2021 23:28:50 GMT, Chris Plummer wrote: >> Alex Menkov has updated the pull request incrementally with one additional >> commit since the last revision: >> >> separated debuggee class name and args > > test/jdk/com/sun/jdi/JdbOptions.java line 91: > >> 89: // the simple

Re: RFR: JDK-8261034: improve jcmd GC.class_histogram to support parallel

2021-02-11 Thread Chris Plummer
On Thu, 11 Feb 2021 02:39:55 GMT, Lin Zang wrote: >> I'm in favor of just having a `noparallel` option (default to using >> parallel) instead of using `parallel=`. This would be for both the histo >> and heap dump features, and for both the `jmap` and `jcmd` support of these >> features. >> >

Re: RFR: 8241403: JavaThread::get_thread_name() should be ThreadSMR-aware

2021-02-11 Thread Daniel D . Daugherty
On Thu, 11 Feb 2021 22:07:22 GMT, Daniel D. Daugherty wrote: >> A minor fix to add a new function: >> >> bool Thread::is_JavaThread_protected(const JavaThread* p) >> >> that returns true when the target JavaThread* is protected and false >> otherwise. Update JavaThread::get_thread_name() t

Re: RFR: 8241403: JavaThread::get_thread_name() should be ThreadSMR-aware

2021-02-11 Thread Daniel D . Daugherty
On Thu, 11 Feb 2021 22:04:53 GMT, Daniel D. Daugherty wrote: > A minor fix to add a new function: > > bool Thread::is_JavaThread_protected(const JavaThread* p) > > that returns true when the target JavaThread* is protected and false > otherwise. Update JavaThread::get_thread_name() to crea

RFR: 8241403: JavaThread::get_thread_name() should be ThreadSMR-aware

2021-02-11 Thread Daniel D . Daugherty
A minor fix to add a new function: bool Thread::is_JavaThread_protected(const JavaThread* p) that returns true when the target JavaThread* is protected and false otherwise. Update JavaThread::get_thread_name() to create a ThreadsListHandle and use the new is_JavaThread_protected(). Also updat

Re: RFR: 8254001: [Metrics] Enhance parsing of cgroup interface files for version detection [v4]

2021-02-11 Thread Harold Seigel
On Tue, 9 Feb 2021 13:31:25 GMT, Severin Gehwolf wrote: >> This is an enhancement which solves two issues: >> >> 1. Multiple reads of relevant cgroup interface files. Now interface files >> are only read once per file (just like Hotspot). >> 2. Proxies creation of the impl specific subsystem vi

Integrated: 8261431: SA: Add comments about load address of executable

2021-02-11 Thread Yasumasa Suenaga
On Tue, 9 Feb 2021 12:22:00 GMT, Yasumasa Suenaga wrote: > I removed the comment about load address of executable in > [JDK-8248876](https://bugs.openjdk.java.net/browse/JDK-8248876) (#2366), but > it contained useful information for maintenance. > > So I re-add them, and add comment for the c

Re: RFR: 8247514: Improve clhsdb 'findpc' ability to determine what an address points to by improving PointerFinder and PointerLocation classes [v2]

2021-02-11 Thread Kevin Walls
On Wed, 10 Feb 2021 21:12:19 GMT, Chris Plummer wrote: >> src/jdk.hotspot.agent/share/classes/sun/jvm/hotspot/utilities/PointerLocation.java >> line 247: >> >>> 245:stackThread.getStackBase(), >>> stackThread.lastSPDbg(), >>> 246: >>> stackThread