Re: RFR: 8080272 Refactor I/O stream copying to use InputStream.transferTo/readAllBytes and Files.copy [v11]

2021-02-15 Thread Alan Bateman
On Mon, 15 Feb 2021 19:47:00 GMT, Andrey Turbanov wrote: >> 8080272 Refactor I/O stream copying to use >> InputStream.transferTo/readAllBytes and Files.copy > > Andrey Turbanov has updated the pull request incrementally with one > additional commit since the last revision: > > 8080272: Ref

RFR: 8261269: When using clhsdb to "inspect" a java object, clhsdb prints "Oop for..." twice

2021-02-15 Thread Chris Plummer
See CR for details. In brief, fixed the `inspect` command to remove duplicate output: hsdb> inspect 0x0007fef00770 instance of Oop for java/lang/Class @ 0x0007fef00770 @ 0x0007fef00770 (size = 160) in: Oop for java/io/BufferedInputStream @ 0x82005b08 Oop for java/io/Buffered

Re: RFR: 8253795: Implementation of JEP 391: macOS/AArch64 Port [v8]

2021-02-15 Thread Vladimir Kempik
On Mon, 15 Feb 2021 19:07:40 GMT, Andrew Haley wrote: >> Hello, we have updated PR, now this bailout is used only by the code which >> can handle it (native wrapper generator), for the rest it will cause >> guarantee failed if this bailout is triggered > > This is when passing a float, yes? In

Re: RFR: 8261710: SA DSO objects have sizes that are too large

2021-02-15 Thread Chris Plummer
On Tue, 16 Feb 2021 01:37:15 GMT, Yasumasa Suenaga wrote: >> These changes look good, but it would be nice to fix OSX too. Fortunately it >> should be easier. As part of the fix for >> [JDK-8247515](https://bugs.openjdk.java.net/browse/JDK-8247515), I added a >> `lib_info->memsz` field. I thin

Re: RFR: 8261710: SA DSO objects have sizes that are too large

2021-02-15 Thread Yasumasa Suenaga
On Mon, 15 Feb 2021 06:43:30 GMT, Chris Plummer wrote: >> This PR relates to >> [JDK-8261702](https://bugs.openjdk.java.net/browse/JDK-8261702) ( #2562 ) >> When SA creates a DSO object, which is used to represent a shared object >> file (.so), it initializes the "size" to be the size of the sh

Re: RFR: 8261098: Add clhsdb "findsym" command [v2]

2021-02-15 Thread Chris Plummer
On Mon, 15 Feb 2021 23:15:46 GMT, Alex Menkov wrote: >> Chris Plummer has updated the pull request incrementally with one additional >> commit since the last revision: >> >> Fix issue with findsym on windows build that doesn't have symbolic >> information. > > src/jdk.hotspot.agent/linux/nat

Re: RFR: 8261607: SA attach is exceeding JNI Local Refs capacity [v3]

2021-02-15 Thread Alex Menkov
On Mon, 15 Feb 2021 20:10:02 GMT, Chris Plummer wrote: >> Delete some localrefs to avoid -Xcheck:jni warnings. See CR for details. > > Chris Plummer has updated the pull request incrementally with one additional > commit since the last revision: > > Fix comment Marked as reviewed by amenkov

Re: RFR: 8261098: Add clhsdb "findsym" command [v2]

2021-02-15 Thread Alex Menkov
On Mon, 15 Feb 2021 20:19:51 GMT, Chris Plummer wrote: >> Add "findsym" to clhsdb. See the CR and CSR for details. The >> [CSR](https://bugs.openjdk.java.net/browse/JDK-8261101) still needs a >> reviewer. >> >> There is a fix in LinuxDebuggerLocal_lookupByName0() to allow passing in >> NULL f

Re: RFR: 8261098: Add clhsdb "findsym" command [v2]

2021-02-15 Thread Chris Plummer
> Add "findsym" to clhsdb. See the CR and CSR for details. The > [CSR](https://bugs.openjdk.java.net/browse/JDK-8261101) still needs a > reviewer. > > There is a fix in LinuxDebuggerLocal_lookupByName0() to allow passing in NULL > for the dso name. This is allowed, and in fact even not null it

Re: RFR: 8261607: SA attach is exceeding JNI Local Refs capacity [v3]

2021-02-15 Thread Chris Plummer
On Mon, 15 Feb 2021 18:09:45 GMT, Severin Gehwolf wrote: >> Although no Clhsdb test is explicitly always runs with `-Xcheck:jni`, the >> option can be added to any test run. For example: >> >> `$ make test TEST=open/test/hotspot/jtreg/serviceability/sa/ >> TEST_VM_OPTS="-Xcheck:jni"` >> >> T

Re: RFR: 8261607: SA attach is exceeding JNI Local Refs capacity [v3]

2021-02-15 Thread Chris Plummer
> Delete some localrefs to avoid -Xcheck:jni warnings. See CR for details. Chris Plummer has updated the pull request incrementally with one additional commit since the last revision: Fix comment - Changes: - all: https://git.openjdk.java.net/jdk/pull/2568/files - new: https:

Re: RFR: 8080272 Refactor I/O stream copying to use InputStream.transferTo/readAllBytes and Files.copy [v10]

2021-02-15 Thread Andrey Turbanov
On Mon, 15 Feb 2021 19:23:16 GMT, Alan Bateman wrote: >> Andrey Turbanov has updated the pull request incrementally with one >> additional commit since the last revision: >> >> 8080272: Refactor I/O stream copying to use java.io.InputStream.transferTo >> revert changes from MimeLauncher > >

Re: RFR: 8080272 Refactor I/O stream copying to use InputStream.transferTo/readAllBytes and Files.copy [v11]

2021-02-15 Thread Andrey Turbanov
> 8080272 Refactor I/O stream copying to use > InputStream.transferTo/readAllBytes and Files.copy Andrey Turbanov has updated the pull request incrementally with one additional commit since the last revision: 8080272: Refactor I/O stream copying to use java.io.InputStream.transferTo remove

Re: RFR: 8261692: Bugs in clhsdb history support

2021-02-15 Thread Alex Menkov
On Sun, 14 Feb 2021 08:45:26 GMT, Chris Plummer wrote: > See the CR for a description of the 3 issues fixed. There's also a new test > added. I'll explain the fix related to quoting the '!' here since it's not > that obvious how it works. > > There's a complex pattern called `historyPattern` t

Re: RFR: 8261711: Clhsdb "versioncheck true" throws NPE every time

2021-02-15 Thread Alex Menkov
On Sun, 14 Feb 2021 09:14:43 GMT, Chris Plummer wrote: > See CR for details. There's no test for `versioncheck`, and I don't think > it's worth adding, especially for this trivial fix. Here's how I tested: > hsdb> versioncheck > versioncheck is true > hsdb> versioncheck false > hsdb> versionchec

Re: RFR: 8080272 Refactor I/O stream copying to use InputStream.transferTo/readAllBytes and Files.copy [v10]

2021-02-15 Thread Alan Bateman
On Mon, 15 Feb 2021 18:33:00 GMT, Andrey Turbanov wrote: >> 8080272 Refactor I/O stream copying to use >> InputStream.transferTo/readAllBytes and Files.copy > > Andrey Turbanov has updated the pull request incrementally with one > additional commit since the last revision: > > 8080272: Ref

Re: RFR: 8261607: SA attach is exceeding JNI Local Refs capacity [v2]

2021-02-15 Thread Severin Gehwolf
On Mon, 15 Feb 2021 17:53:58 GMT, Chris Plummer wrote: >> Delete some localrefs to avoid -Xcheck:jni warnings. See CR for details. > > Chris Plummer has updated the pull request incrementally with one additional > commit since the last revision: > > Fix comment Other than the comment suggest

Re: RFR: 8253795: Implementation of JEP 391: macOS/AArch64 Port [v8]

2021-02-15 Thread Andrew Haley
On Mon, 15 Feb 2021 18:00:50 GMT, Vladimir Kempik wrote: >> src/hotspot/cpu/aarch64/sharedRuntime_aarch64.cpp line 839: >> >>> 837: // The code unable to handle this, bailout. >>> 838: return -1; >>> 839: #endif >> >> This looks like a bug to me. The caller doesn't necessari

Re: RFR: 8080272 Refactor I/O stream copying to use InputStream.transferTo/readAllBytes and Files.copy [v10]

2021-02-15 Thread Maurizio Cimadamore
On Mon, 15 Feb 2021 18:33:00 GMT, Andrey Turbanov wrote: >> 8080272 Refactor I/O stream copying to use >> InputStream.transferTo/readAllBytes and Files.copy > > Andrey Turbanov has updated the pull request incrementally with one > additional commit since the last revision: > > 8080272: Ref

Re: RFR: 8080272 Refactor I/O stream copying to use InputStream.transferTo/readAllBytes and Files.copy [v10]

2021-02-15 Thread Andrey Turbanov
> 8080272 Refactor I/O stream copying to use > InputStream.transferTo/readAllBytes and Files.copy Andrey Turbanov has updated the pull request incrementally with one additional commit since the last revision: 8080272: Refactor I/O stream copying to use java.io.InputStream.transferTo revert

Re: RFR: 8261447: MethodInvocationCounters frequently run into overflow [v3]

2021-02-15 Thread Lutz Schmidt
On Fri, 12 Feb 2021 11:58:47 GMT, Lutz Schmidt wrote: >> I introduced the *64 suffixes to not break anything that still uses the old >> calls. As old uses disappear step by step, I'm more than happy to remove the >> suffixes. I will have a look into SA and try to make it 64bit counter ready. >

Re: RFR: 8253795: Implementation of JEP 391: macOS/AArch64 Port [v17]

2021-02-15 Thread Anton Kozlov
> Please review the implementation of JEP 391: macOS/AArch64 Port. > > It's heavily based on existing ports to linux/aarch64, macos/x86_64, and > windows/aarch64. > > Major changes are in: > * src/hotspot/cpu/aarch64: support of the new calling convention (subtasks > JDK-8253817, JDK-8253818)

Re: RFR: 8080272 Refactor I/O stream copying to use InputStream.transferTo/readAllBytes and Files.copy [v8]

2021-02-15 Thread Julia Boes
On Sat, 13 Feb 2021 10:56:32 GMT, Andrey Turbanov wrote: >> This fours tests pass without problems, when I run them separately. >> >> ## sun/security/tools/jarsigner/TimestampCheck.java >> ## sun/security/tools/keytool/DefaultOptions.java >> ## sanity/client/SwingSet/src/ColorChooserDemoTest.ja

Re: RFR: 8261607: SA attach is exceeding JNI Local Refs capacity [v2]

2021-02-15 Thread Severin Gehwolf
On Mon, 15 Feb 2021 17:47:47 GMT, Chris Plummer wrote: >> test/hotspot/jtreg/serviceability/sa/ClhsdbLauncher.java line 149: >> >>> 147: // Make sure no -Xcheck:jni failures. WARNING: JNI local refs >>> 148: oa.shouldNotMatch("^WARNING: JNI local refs:.*$"); >>> 149: oa.s

Re: RFR: 8253795: Implementation of JEP 391: macOS/AArch64 Port [v16]

2021-02-15 Thread Anton Kozlov
> Please review the implementation of JEP 391: macOS/AArch64 Port. > > It's heavily based on existing ports to linux/aarch64, macos/x86_64, and > windows/aarch64. > > Major changes are in: > * src/hotspot/cpu/aarch64: support of the new calling convention (subtasks > JDK-8253817, JDK-8253818)

Re: RFR: 8261447: MethodInvocationCounters frequently run into overflow [v3]

2021-02-15 Thread Lutz Schmidt
> Dear community, > may I please request reviews for this fix, improving the usefulness of method > invocation counters. > - aggregation counters are retyped as uint64_t, shifting the overflow > probability way out (185 days in case of a 1 GHz counter update frequency). > - counters for individua

Re: RFR: 8253795: Implementation of JEP 391: macOS/AArch64 Port [v9]

2021-02-15 Thread Anton Kozlov
On Wed, 3 Feb 2021 20:08:41 GMT, Anton Kozlov wrote: > I'm going to do as much refactoring as needed before this patch under > JDK-8261071 The recent merge resolves inconsitency between pass_byte/pass_short and other methods. - PR: https://git.openjdk.java.net/jdk/pull/2200

Re: RFR: 8253795: Implementation of JEP 391: macOS/AArch64 Port [v8]

2021-02-15 Thread Vladimir Kempik
On Mon, 1 Feb 2021 18:44:48 GMT, Andrew Haley wrote: >> Anton Kozlov has updated the pull request with a new target base due to a >> merge or a rebase. The pull request now contains 62 commits: >> >> - Merge branch 'master' into jdk-macos >> - Update copyright year for BsdAARCH64ThreadContext

Re: RFR: 8253795: Implementation of JEP 391: macOS/AArch64 Port [v9]

2021-02-15 Thread Vladimir Kempik
On Tue, 2 Feb 2021 21:52:47 GMT, Daniel D. Daugherty wrote: >> Anton Kozlov has updated the pull request incrementally with one additional >> commit since the last revision: >> >> support macos_aarch64 in hsdis > > src/hotspot/cpu/aarch64/sharedRuntime_aarch64.cpp line 810: > >> 808: #ifdef

Re: RFR: 8261607: SA attach is exceeding JNI Local Refs capacity [v2]

2021-02-15 Thread Chris Plummer
> Delete some localrefs to avoid -Xcheck:jni warnings. See CR for details. Chris Plummer has updated the pull request incrementally with one additional commit since the last revision: Fix comment - Changes: - all: https://git.openjdk.java.net/jdk/pull/2568/files - new: https:

Re: RFR: 8261607: SA attach is exceeding JNI Local Refs capacity [v2]

2021-02-15 Thread Chris Plummer
On Mon, 15 Feb 2021 13:21:39 GMT, Severin Gehwolf wrote: >> Chris Plummer has updated the pull request incrementally with one additional >> commit since the last revision: >> >> Fix comment > > test/hotspot/jtreg/serviceability/sa/ClhsdbLauncher.java line 149: > >> 147: // Make sure

Re: RFR: 8253795: Implementation of JEP 391: macOS/AArch64 Port [v15]

2021-02-15 Thread Anton Kozlov
On Sun, 31 Jan 2021 20:08:01 GMT, Vladimir Kempik wrote: >> I'm not sure it can wait. This change turns already-messy code into >> something significantly messier, to the extent that it's not really good >> enough to go into mainline. > > Hello > Does this look like something in the right direc

Re: RFR: 8253795: Implementation of JEP 391: macOS/AArch64 Port [v15]

2021-02-15 Thread Anton Kozlov
> Please review the implementation of JEP 391: macOS/AArch64 Port. > > It's heavily based on existing ports to linux/aarch64, macos/x86_64, and > windows/aarch64. > > Major changes are in: > * src/hotspot/cpu/aarch64: support of the new calling convention (subtasks > JDK-8253817, JDK-8253818)

Re: RFR: 8253795: Implementation of JEP 391: macOS/AArch64 Port [v14]

2021-02-15 Thread Anton Kozlov
> Please review the implementation of JEP 391: macOS/AArch64 Port. > > It's heavily based on existing ports to linux/aarch64, macos/x86_64, and > windows/aarch64. > > Major changes are in: > * src/hotspot/cpu/aarch64: support of the new calling convention (subtasks > JDK-8253817, JDK-8253818)

Re: RFR: 8253795: Implementation of JEP 391: macOS/AArch64 Port [v9]

2021-02-15 Thread Bernhard Urban-Forster
On Fri, 12 Feb 2021 12:22:09 GMT, Vladimir Kempik wrote: >> Where did this come from - some snippet/example/tech note code? Maybe other >> people can help figure it out if we provide more info. > > This is the version of w^x on-demand switch implemented by microsoft guys. > This is enabled only

Re: RFR: 8261607: SA attach is exceeding JNI Local Refs capacity

2021-02-15 Thread Severin Gehwolf
On Mon, 15 Feb 2021 06:00:29 GMT, Chris Plummer wrote: > Delete some localrefs to avoid -Xcheck:jni warnings. See CR for details. test/hotspot/jtreg/serviceability/sa/ClhsdbLauncher.java line 149: > 147: // Make sure no -Xcheck:jni failures. WARNING: JNI local refs > 148: oa.sho

Re: RFR: 8080272 Refactor I/O stream copying to use InputStream.transferTo/readAllBytes and Files.copy [v8]

2021-02-15 Thread Alan Bateman
On Sat, 13 Feb 2021 10:56:32 GMT, Andrey Turbanov wrote: >> This fours tests pass without problems, when I run them separately. >> >> ## sun/security/tools/jarsigner/TimestampCheck.java >> ## sun/security/tools/keytool/DefaultOptions.java >> ## sanity/client/SwingSet/src/ColorChooserDemoTest.ja