On Thu, 25 Feb 2021 23:14:01 GMT, Daniel D. Daugherty
wrote:
>> A minor fix to add a new function:
>>
>> bool Thread::is_JavaThread_protected(const JavaThread* p)
>>
>> that returns true when the target JavaThread* is protected and false
>> otherwise. Update JavaThread::get_thread_name() t
Thanks Dan!
ping!
Regards
Hui
-邮件原件-
发件人: daniel.daughe...@oracle.com
发送时间: 2021年2月23日 2:17
收件人: kalinshi(施慧) ; hotspot-...@openjdk.java.net;
hotspot-runtime-...@openjdk.java.net; serviceability-dev@openjdk.java.net
主题: Re: JvmtiExport::can_walk_any_space() usage in hotspot(Interne
On Thu, 25 Feb 2021 23:37:31 GMT, David Holmes wrote:
>> Daniel D. Daugherty has updated the pull request incrementally with one
>> additional commit since the last revision:
>>
>> Address dholmes-ora CR4 comments.
>
> Looks good!
>
> Thanks,
> David
@dholmes-ora - Thanks for yet another re
On Thu, 25 Feb 2021 23:14:01 GMT, Daniel D. Daugherty
wrote:
>> A minor fix to add a new function:
>>
>> bool Thread::is_JavaThread_protected(const JavaThread* p)
>>
>> that returns true when the target JavaThread* is protected and false
>> otherwise. Update JavaThread::get_thread_name() t
> A minor fix to add a new function:
>
> bool Thread::is_JavaThread_protected(const JavaThread* p)
>
> that returns true when the target JavaThread* is protected and false
> otherwise. Update JavaThread::get_thread_name() to create a
> ThreadsListHandle and use the new is_JavaThread_protected
On Thu, 25 Feb 2021 22:44:07 GMT, Daniel D. Daugherty
wrote:
>> A minor fix to add a new function:
>>
>> bool Thread::is_JavaThread_protected(const JavaThread* p)
>>
>> that returns true when the target JavaThread* is protected and false
>> otherwise. Update JavaThread::get_thread_name() t
On Thu, 25 Feb 2021 22:49:32 GMT, David Holmes wrote:
>> Daniel D. Daugherty has updated the pull request incrementally with one
>> additional commit since the last revision:
>>
>> Address dholmes-ora CR3 comments.
>
> src/hotspot/share/compiler/compileBroker.cpp line 1028:
>
>> 1026:
On Thu, 25 Feb 2021 22:47:21 GMT, David Holmes wrote:
>> Daniel D. Daugherty has updated the pull request incrementally with one
>> additional commit since the last revision:
>>
>> Address dholmes-ora CR3 comments.
>
> src/hotspot/share/runtime/thread.cpp line 520:
>
>> 518: guarantee(fals
On Thu, 25 Feb 2021 22:44:07 GMT, Daniel D. Daugherty
wrote:
>> A minor fix to add a new function:
>>
>> bool Thread::is_JavaThread_protected(const JavaThread* p)
>>
>> that returns true when the target JavaThread* is protected and false
>> otherwise. Update JavaThread::get_thread_name() t
> A minor fix to add a new function:
>
> bool Thread::is_JavaThread_protected(const JavaThread* p)
>
> that returns true when the target JavaThread* is protected and false
> otherwise. Update JavaThread::get_thread_name() to create a
> ThreadsListHandle and use the new is_JavaThread_protected
On Thu, 25 Feb 2021 17:49:43 GMT, Daniel D. Daugherty
wrote:
>> Daniel D. Daugherty has updated the pull request with a new target base due
>> to a merge or a rebase. The incremental webrev excludes the unrelated
>> changes brought in by the merge/rebase. The pull request contains six
>> addi
On 26/02/2021 3:52 am, Daniel D.Daugherty wrote:
On Wed, 24 Feb 2021 00:42:11 GMT, David Holmes wrote:
Holding the Threads_lock is no longer being considered as
proper protection for the JavaThread::get_thread_name() call
so I had to change the code to use a JavaThreadIteratorWithHandle
so tha
On Thu, 25 Feb 2021 12:18:55 GMT, Lin Zang wrote:
> Do you think it is ok if I change the help message of `parallel` option
> `jmap -histo` in this PR together?
Yes, I think that would be ok.
-
PR: https://git.openjdk.java.net/jdk/pull/2261
On Wed, 24 Feb 2021 00:42:11 GMT, David Holmes wrote:
>> Holding the Threads_lock is no longer being considered as
>> proper protection for the JavaThread::get_thread_name() call
>> so I had to change the code to use a JavaThreadIteratorWithHandle
>> so that we have the protection of the TLH. Tha
On Tue, 23 Feb 2021 23:52:15 GMT, Daniel D. Daugherty
wrote:
>> A minor fix to add a new function:
>>
>> bool Thread::is_JavaThread_protected(const JavaThread* p)
>>
>> that returns true when the target JavaThread* is protected and false
>> otherwise. Update JavaThread::get_thread_name() t
On Wed, 24 Feb 2021 00:36:28 GMT, David Holmes wrote:
>> Daniel D. Daugherty has updated the pull request with a new target base due
>> to a merge or a rebase. The incremental webrev excludes the unrelated
>> changes brought in by the merge/rebase. The pull request contains six
>> additional c
On Wed, 17 Feb 2021 12:36:10 GMT, Anton Kozlov wrote:
>> Please review the implementation of JEP 391: macOS/AArch64 Port.
>>
>> It's heavily based on existing ports to linux/aarch64, macos/x86_64, and
>> windows/aarch64.
>>
>> Major changes are in:
>> * src/hotspot/cpu/aarch64: support of the
Fails prior the patch of JDK-8257746, passes after. As expected.
Thoughts?
-
Commit messages:
- 8262379: Add regression test for JDK-8257746
Changes: https://git.openjdk.java.net/jdk/pull/2725/files
Webrev: https://webrevs.openjdk.java.net/?repo=jdk&pr=2725&range=00
Issue: https
On Wed, 24 Feb 2021 04:12:13 GMT, Chris Plummer wrote:
>>> It's too bad that the `dumpheap` command in previous JDKs has a slot for a
>>> 3rd argument, but doesn't look at it. Maybe that was intentional to allow
>>> for a new argument without causing a failure. What it means is if we want a
>>
On Wed, 9 Dec 2020 08:51:48 GMT, Lin Zang wrote:
> 8257234 : Add gz option to SA jmap to write a gzipped heap dump
This pull request has now been integrated.
Changeset: c54724da
Author:Lin Zang
Committer: Jie Fu
URL: https://git.openjdk.java.net/jdk/commit/c54724da
Stats: 657 li
On Thu, 4 Feb 2021 07:11:19 GMT, Lin Zang wrote:
> 8261131: jcmd jmap dump should not accept gz option with no value
This pull request has now been integrated.
Changeset: aa35b423
Author:Lin Zang
Committer: Jie Fu
URL: https://git.openjdk.java.net/jdk/commit/aa35b423
Stats: 28 l
On Wed, 24 Feb 2021 04:12:13 GMT, Chris Plummer wrote:
>>> It's too bad that the `dumpheap` command in previous JDKs has a slot for a
>>> 3rd argument, but doesn't look at it. Maybe that was intentional to allow
>>> for a new argument without causing a failure. What it means is if we want a
>>
On Sat, 20 Feb 2021 11:35:18 GMT, Lin Zang wrote:
>> Marked as reviewed by cjplummer (Reviewer).
>
> Mark it as ready for pushing. Thanks @plummercj @sspitsyn and @YaSuenag for
> help reviewing!
Dear All，
May I ask your help to push this PR as it is ready.
Thanks!
Lin
-
PR: https
On Tue, 9 Feb 2021 05:49:51 GMT, Serguei Spitsyn wrote:
>> Lin Zang has updated the pull request with a new target base due to a merge
>> or a rebase. The incremental webrev excludes the unrelated changes brought
>> in by the merge/rebase. The pull request contains three additional commits
>>
On Thu, 25 Feb 2021 09:01:10 GMT, Lutz Schmidt wrote:
>> Dear community,
>> may I please request reviews for this fix, improving the usefulness of
>> method invocation counters.
>> - aggregation counters are retyped as uint64_t, shifting the overflow
>> probability way out (> 500 years in case
Hi Chris,
> Are you saying they are all pseudo files that
> already exist and can't be deleted, and therefore you currently
> can't dump the heap to them?
Yes, these are pseudo files and have to be created by special calls.
But you can open and write to them using the usual file APIs, so
No big
> Dear community,
> may I please request reviews for this fix, improving the usefulness of method
> invocation counters.
> - aggregation counters are retyped as uint64_t, shifting the overflow
> probability way out (> 500 years in case of a 1 GHz counter update frequency).
> - counters for indivi
On Wed, 24 Feb 2021 22:28:15 GMT, Martin Doerr wrote:
>> Lutz Schmidt has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> update copyright year
>
> src/hotspot/share/runtime/java.cpp line 100:
>
>> 98: int compare_methods(Method** a, Method
28 matches
Mail list logo
