On Tue, 2 Mar 2021 12:34:35 GMT, Matthias Baesken wrote:
> There is an early return in
> Java_sun_jvm_hotspot_debugger_linux_amd64_DwarfParser_createDwarfContext that
> misses to delete the non-parsable parser object.
> see also the Sonar finding :
> https://sonarcloud.io/project/issues?id=ship
8262386: resourcehogs/serviceability/sa/TestHeapDumpForLargeArray.java timed out
-
Commit messages:
- code refine
- 8262386: resourcehogs/serviceability/sa/TestHeapDumpForLargeArray.java timed
out
Changes: https://git.openjdk.java.net/jdk/pull/2803/files
Webrev: https://webrevs.o
On Tue, 2 Mar 2021 22:24:17 GMT, Chris Plummer wrote:
>> Yasumasa Suenaga has updated the pull request incrementally with one
>> additional commit since the last revision:
>>
>> Fix comments
>
> src/jdk.hotspot.agent/share/classes/sun/jvm/hotspot/HSDB.java line 100:
>
>> 98: execPath = n
On Tue, 2 Mar 2021 21:48:30 GMT, Chris Plummer wrote:
>> Yasumasa Suenaga has updated the pull request incrementally with one
>> additional commit since the last revision:
>>
>> Fix comments
>
> src/jdk.hotspot.agent/doc/clhsdb.html line 39:
>
>> 37: Available commands:
>> 38: assert true
> `attach` command on CLHSDB supports to attach live process (PID) and
> coredump, but it cannot connect to debug server. CLHSDB does not have a
> command to connect to debug server.
>
> Other jhsdb commands (jstack, jmap, etc...) can connect debug server via
> `--connect` option, so CLHSDB sho
On Tue, 2 Mar 2021 22:31:22 GMT, Chris Plummer wrote:
> This pre-existing code in CLHSDB.java is a little concerning:
>
> ```
> 127 private void doUsage() {
> 128 System.out.println("Usage: java CLHSDB [[pid] |
> [path-to-java-executable [path-to-corefile]] | help ]");
> 129
On Tue, 2 Mar 2021 21:08:38 GMT, Lutz Schmidt wrote:
>> I see that you've fixed the types since the last comment, but it think it's
>> still broken (and has been before).
>> How about:
>> int64_t diff = ((*b)->compiled_invocation_count() -
>> (*a)->compiled_invocation_count()) + ((*b)->invocat
On Tue, 2 Mar 2021 21:19:18 GMT, Anton Kozlov wrote:
>> Please review the implementation of JEP 391: macOS/AArch64 Port.
>>
>> It's heavily based on existing ports to linux/aarch64, macos/x86_64, and
>> windows/aarch64.
>>
>> Major changes are in:
>> * src/hotspot/cpu/aarch64: support of the
On Tue, 2 Mar 2021 12:55:04 GMT, Yasumasa Suenaga wrote:
>> `attach` command on CLHSDB supports to attach live process (PID) and
>> coredump, but it cannot connect to debug server. CLHSDB does not have a
>> command to connect to debug server.
>>
>> Other jhsdb commands (jstack, jmap, etc...) c
On Tue, 2 Mar 2021 21:15:46 GMT, Igor Veresov wrote:
>> When you increment (2^31-1), you get 2^31 which is 0x8000. When
>> interpreted as signed int, it is MIN_INT. I don't want that. I want to treat
>> the value as positive number - what it actually is. There is no negative
>> count!
>
>
On Thu, 4 Feb 2021 22:58:39 GMT, Gerard Ziemski wrote:
>> Anton Kozlov has updated the pull request incrementally with six additional
>> commits since the last revision:
>>
>> - Merge remote-tracking branch 'origin/jdk/jdk-macos' into jdk-macos
>> - Add comments to WX transitions
>>
>>
> Please review the implementation of JEP 391: macOS/AArch64 Port.
>
> It's heavily based on existing ports to linux/aarch64, macos/x86_64, and
> windows/aarch64.
>
> Major changes are in:
> * src/hotspot/cpu/aarch64: support of the new calling convention (subtasks
> JDK-8253817, JDK-8253818)
On Fri, 12 Feb 2021 15:21:06 GMT, Vladimir Kempik wrote:
>> src/hotspot/os_cpu/bsd_aarch64/os_bsd_aarch64.cpp line 302:
>>
>>> 300: const uint64_t *detail_msg_ptr
>>> 301: = (uint64_t*)(pc + NativeInstruction::instruction_size);
>>> 302: const char *detail_msg = (const
On Tue, 2 Mar 2021 20:43:53 GMT, Lutz Schmidt wrote:
>> So, why do we need the casts to unsigned in this method?
>
> When you increment (2^31-1), you get 2^31 which is 0x8000. When
> interpreted as signed int, it is MIN_INT. I don't want that. I want to treat
> the value as positive number
On Tue, 2 Mar 2021 20:46:01 GMT, Igor Veresov wrote:
>> src/hotspot/share/runtime/java.cpp line 100:
>>
>>> 98: int compare_methods(Method** a, Method** b) {
>>> 99: return (int32_t)(((uint32_t)(*b)->invocation_count() +
>>> (*b)->compiled_invocation_count())
>>> 100: - ((uin
On Tue, 2 Mar 2021 20:59:46 GMT, Igor Veresov wrote:
>> Then it will never happen. These values come from
>> ```InvocationCounter::count()```. And it will never return a value > 2^31 -
>> 1.
>
> Sorry, it can return 2^31. Which would be an indication of a counter overflow
> (InvocationCounter:
On Tue, 2 Mar 2021 20:55:50 GMT, Igor Veresov wrote:
>> With overflow I do not mean "counter overflow" as it is used to trigger
>> compiler activities but plain simple "range of singed int exceeded". Should
>> I use different wording? E.g. "counter in signed int overflow"?
>
> Then it will neve
On Tue, 2 Mar 2021 20:47:25 GMT, Lutz Schmidt wrote:
>> I'd be better to change the logic to check if the counter is ```>=
>> InvocationCounter::count_limit``` then it's in overflow.
>
> With overflow I do not mean "counter overflow" as it is used to trigger
> compiler activities but plain simp
On Tue, 2 Mar 2021 18:50:24 GMT, Igor Veresov wrote:
>> Will change.
>
> I'd be better to change the logic to check if the counter is ```>=
> InvocationCounter::count_limit``` then it's in overflow.
With overflow I do not mean "counter overflow" as it is used to trigger
compiler activities but
On Thu, 25 Feb 2021 16:36:38 GMT, Igor Veresov wrote:
>> Lutz Schmidt has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> comment changes requested by TheRealMDoerr
>
> src/hotspot/share/runtime/java.cpp line 100:
>
>> 98: int compare_metho
On Thu, 25 Feb 2021 16:31:58 GMT, Igor Veresov wrote:
>> src/hotspot/share/oops/method.cpp line 516:
>>
>>> 514: // This is ok because counters are unsigned by nature, and it gives
>>> us
>>> 515: // another factor of 2 before the counter values become meaningless.
>>> 516: // Print a "ov
On Thu, 4 Feb 2021 22:34:16 GMT, Gerard Ziemski wrote:
>> Anton Kozlov has updated the pull request incrementally with six additional
>> commits since the last revision:
>>
>> - Merge remote-tracking branch 'origin/jdk/jdk-macos' into jdk-macos
>> - Add comments to WX transitions
>>
>>
On Thu, 25 Feb 2021 09:01:10 GMT, Lutz Schmidt wrote:
>> Dear community,
>> may I please request reviews for this fix, improving the usefulness of
>> method invocation counters.
>> - aggregation counters are retyped as uint64_t, shifting the overflow
>> probability way out (> 500 years in case
On Tue, 2 Mar 2021 17:30:47 GMT, Lutz Schmidt wrote:
>> src/hotspot/share/oops/method.cpp line 518:
>>
>>> 516: // Print a "overflow" notification to create awareness.
>>> 517: const char* addMsg;
>>> 518: unsigned int maxInt = (1U<<31) - 1;
>>
>> Why not use INT_MAX?
>
> Will change.
I'
On Thu, 11 Feb 2021 17:47:54 GMT, Lutz Schmidt wrote:
>> Dear community,
>> may I please request reviews for this fix, improving the usefulness of
>> method invocation counters.
>> - aggregation counters are retyped as uint64_t, shifting the overflow
>> probability way out (> 500 years in case
On Thu, 11 Feb 2021 21:14:04 GMT, Igor Veresov wrote:
>> Lutz Schmidt has refreshed the contents of this pull request, and previous
>> commits have been removed. The incremental views will show differences
>> compared to the previous content of the PR.
>
> src/hotspot/share/oops/method.cpp line
On Tue, 2 Mar 2021 19:25:26 GMT, Lutz Schmidt wrote:
>> No it was a different question. I see my comments try clicking on the "Files
>> changed" tab and scrolling down to method.cpp.
>> I also left a comment about your changes to ```compare_methods()``` I don't
>> think it's correct.
>
> Igor,
On Tue, 2 Mar 2021 18:53:47 GMT, Igor Veresov wrote:
>> @veresov I can't see your comment re. the casts. The only comment I see is
>> re. the *64 suffixes.
>> Anyway, is your question/comment directly related to Vladimir's annotations?
>> Or do you need further reasoning? Please let me know.
>
On Fri, 19 Feb 2021 23:04:59 GMT, Alex Menkov wrote:
>> Failures related to "no route to host" and "cannot bind to address" errors
>> are covered by https://git.openjdk.java.net/jdk/pull/2633
>>
>> This change fixes failures with listening on IPv6 loopback and attaching to
>> "localhost" (the
On Tue, 2 Mar 2021 17:35:18 GMT, Lutz Schmidt wrote:
>> I have few comments.
>
> @veresov I can't see your comment re. the casts. The only comment I see is
> re. the *64 suffixes.
> Anyway, is your question/comment directly related to Vladimir's annotations?
> Or do you need further reasoning?
On Tue, 2 Mar 2021 17:23:23 GMT, Lutz Schmidt wrote:
>> src/hotspot/cpu/x86/vtableStubs_x86_32.cpp line 159:
>>
>>> 157: return NULL;
>>> 158: }
>>> 159:
>>
>> Why you did not update asm instruction to update `nof_megamorphic_calls` in
>> this file?
>
> The reason is plain simple: there
On Tue, 2 Mar 2021 17:14:34 GMT, Vladimir Kozlov wrote:
>> Lutz Schmidt has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> comment changes requested by TheRealMDoerr
>
> I have few comments.
@veresov I can't see your comment re. the casts.
On Tue, 2 Mar 2021 16:44:44 GMT, Vladimir Kozlov wrote:
>> Lutz Schmidt has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> comment changes requested by TheRealMDoerr
>
> src/hotspot/share/oops/method.cpp line 530:
>
>> 528:
>> 529: if (
On Tue, 2 Mar 2021 16:34:26 GMT, Vladimir Kozlov wrote:
>> Lutz Schmidt has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> comment changes requested by TheRealMDoerr
>
> src/hotspot/cpu/x86/vtableStubs_x86_32.cpp line 159:
>
>> 157: re
On Thu, 25 Feb 2021 09:01:10 GMT, Lutz Schmidt wrote:
>> Dear community,
>> may I please request reviews for this fix, improving the usefulness of
>> method invocation counters.
>> - aggregation counters are retyped as uint64_t, shifting the overflow
>> probability way out (> 500 years in case
On Tue, 2 Mar 2021 08:34:29 GMT, Lutz Schmidt wrote:
>> Hi @RealLucy , I didn't do an actual review just made a passing comment.
>
> @dholmes-ora OK then. I just didn't want to ignore anyone's opinion.
> I plan to integrate the change before my EOB (GMT+1), provided there are no
> objections.
On Tue, 2 Mar 2021 12:34:35 GMT, Matthias Baesken wrote:
> There is an early return in
> Java_sun_jvm_hotspot_debugger_linux_amd64_DwarfParser_createDwarfContext that
> misses to delete the non-parsable parser object.
> see also the Sonar finding :
> https://sonarcloud.io/project/issues?id=ship
On Tue, 2 Mar 2021 12:34:35 GMT, Matthias Baesken wrote:
> There is an early return in
> Java_sun_jvm_hotspot_debugger_linux_amd64_DwarfParser_createDwarfContext that
> misses to delete the non-parsable parser object.
> see also the Sonar finding :
> https://sonarcloud.io/project/issues?id=ship
On Thu, 4 Feb 2021 22:15:47 GMT, Gerard Ziemski wrote:
>> Anton Kozlov has updated the pull request incrementally with six additional
>> commits since the last revision:
>>
>> - Merge remote-tracking branch 'origin/jdk/jdk-macos' into jdk-macos
>> - Add comments to WX transitions
>>
>>
On Tue, 2 Mar 2021 11:39:10 GMT, Kevin Walls wrote:
>>> @plummercj Ok, I try to add debug server support to `attach` clhsdb
>>> command. Then should we still need CSR?
>>
>> Pushed new commit to be implemented as `attach`. It works fine with
>> serviceability/sa jtreg tests on my Linux x64.
>>
> `attach` command on CLHSDB supports to attach live process (PID) and
> coredump, but it cannot connect to debug server. CLHSDB does not have a
> command to connect to debug server.
>
> Other jhsdb commands (jstack, jmap, etc...) can connect debug server via
> `--connect` option, so CLHSDB sho
There is an early return in
Java_sun_jvm_hotspot_debugger_linux_amd64_DwarfParser_createDwarfContext that
misses to delete the non-parsable parser object.
see also the Sonar finding :
https://sonarcloud.io/project/issues?id=shipilev_jdk&languages=cpp&open=AXck8Ca-BBG2CXpcnimn&resolved=false&sever
On Tue, 2 Mar 2021 08:30:06 GMT, Yasumasa Suenaga wrote:
>> `jhsdb` has `--pid`, `--core`, and `--connect` as the 3 ways to "attach" for
>> lack of a better word. It would have been nice if the clhsdb command did a
>> better job of copying these three command line arguments. You are suggesting
On Tue, 2 Feb 2021 23:10:17 GMT, Daniel D. Daugherty wrote:
> For platform files that were copied from other ports to this port, if the
> file wasn't
> changed I presume the copyright years are left alone. If the file required
> changes
> for this port, I expect the year to be updated to 2021.
On Tue, 2 Feb 2021 22:47:04 GMT, Daniel D. Daugherty wrote:
>> Anton Kozlov has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> support macos_aarch64 in hsdis
>
> src/hotspot/share/prims/nativeEntryPoint.cpp line 45:
>
>> 43: guarantee(st
On Tue, 2 Feb 2021 22:18:43 GMT, Daniel D. Daugherty wrote:
>> Anton Kozlov has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> support macos_aarch64 in hsdis
>
> src/hotspot/os_cpu/bsd_aarch64/thread_bsd_aarch64.cpp line 43:
>
>> 41: ass
On Mon, 1 Mar 2021 22:54:15 GMT, David Holmes wrote:
>> Thank you for your review, Tobias!
>> I'll delay integration for a while to give David and Igor a chance to react.
>
> Hi @RealLucy , I didn't do an actual review just made a passing comment.
@dholmes-ora OK then. I just didn't want to igno
> `attach` command on CLHSDB supports to attach live process (PID) and
> coredump, but it cannot connect to debug server. CLHSDB does not have a
> command to connect to debug server.
>
> Other jhsdb commands (jstack, jmap, etc...) can connect debug server via
> `--connect` option, so CLHSDB sho
On Tue, 2 Mar 2021 05:18:51 GMT, Chris Plummer wrote:
>>> You'll need a CSR for this.
>>
>> Ok, I will add it after this discussion ( `coonect` or `attach` )
>>
>>> Will `jhsdb clhsdb --connect debugserver` work? If not, it should to be
>>> consistent with the other commands.
>>
>> It does no
On Fri, 12 Feb 2021 13:32:52 GMT, Vladimir Kempik wrote:
>> src/hotspot/os_cpu/bsd_aarch64/os_bsd_aarch64.cpp line 486:
>>
>>> 484: }
>>> 485: }
>>> 486: }
>>
>> This appears to be a mix for Mavericks (10.9) and 10.12
>> work arounds. Is this code needed by this project?
>
> I
On Fri, 12 Feb 2021 12:40:09 GMT, Florian Weimer wrote:
>> only macos comiplers
>
> The comment is also wrong for glibc: The AArch64 ABI requires a 64 KiB guard
> region independently of page size, otherwise `-fstack-clash-protection` is
> not reliable.
Thanks, I deleted the comment. It descri
51 matches
Mail list logo
