On Wed, 17 Mar 2021 04:55:27 GMT, Chris Plummer wrote:
>>> If I understand correctly, this is very different than the way we normally
>>> implement remote debugging support. Normally pages are read in from the
>>> remote VM process and into the local SA client, where it can then implement
>>>
> jhsdb supports pmap (jhsdb jmap) and pstack (jhsdb jstack --mixed), and they
> work fine if they attach to live process or to coredump, however they do not
> work on debug server as following:
>
> $ jhsdb jmap --connect localhost
> Attaching to remote server localhost, please wait...
> Debugge
On Fri, 26 Feb 2021 22:46:07 GMT, Ioi Lam wrote:
>> Yumin Qi has updated the pull request with a new target base due to a merge
>> or a rebase. The incremental webrev excludes the unrelated changes brought
>> in by the merge/rebase. The pull request contains five additional commits
>> since th
On Fri, 26 Feb 2021 22:01:50 GMT, Calvin Cheung wrote:
>> Yumin Qi has updated the pull request with a new target base due to a merge
>> or a rebase. The incremental webrev excludes the unrelated changes brought
>> in by the merge/rebase. The pull request contains five additional commits
>> si
On Wed, 10 Mar 2021 04:28:04 GMT, Ioi Lam wrote:
>> Yumin Qi has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> Fix white space in CDS.java
>
> src/java.base/share/classes/jdk/internal/misc/CDS.java line 256:
>
>> 254:
>> 255:
On Sat, 27 Feb 2021 18:11:38 GMT, Ioi Lam wrote:
>> How would it overflow? But I agree, I would not add jsa extension if the
>> user did not specify one. I dislike when programs do that.
>
> `file_name` is user input that comes from the jcmd, so it can be arbitrarily
> long and exceed JVM_MAXPA
On Sat, 27 Feb 2021 05:12:25 GMT, Thomas Stuefe wrote:
>> src/hotspot/share/memory/metaspaceShared.cpp line 783:
>>
>>> 781: char* start = buffer + strlen(buffer);
>>> 782: snprintf(start, buff_len, "%s ", arg);
>>> 783: }
>>
>> Maybe move the above function to the StringUtils class under s
On Fri, 26 Feb 2021 21:39:48 GMT, Ioi Lam wrote:
>> Yumin Qi has updated the pull request with a new target base due to a merge
>> or a rebase. The incremental webrev excludes the unrelated changes brought
>> in by the merge/rebase. The pull request contains five additional commits
>> since th
On Wed, 17 Mar 2021 23:42:46 GMT, Alex Menkov wrote:
> The test requests NotifyFrame event from MethodEntry handler expecting that
> 1st MethodEntry event is generated for main thread.
> The fix adds a check that the thread is correct and skips event from other
> threads
The fix is good. Might
The test requests NotifyFrame event from MethodEntry handler expecting that 1st
MethodEntry event is generated for main thread.
The fix adds a check that the thread is correct and skips event from other
threads
-
Commit messages:
- JDK-8262083
Changes: https://git.openjdk.java.net
On Wed, 17 Mar 2021 22:23:43 GMT, Chris Plummer wrote:
> The test name has a typo (should be ClhsdbClasses - the 'b' is missing).
> Therefore it was not actually being excluded, and therefore it runs just fine
> with ZGC. This is expected since it is not a heap related test.
>
> I'd like to pu
On Wed, 17 Mar 2021 23:19:10 GMT, Daniel D. Daugherty
wrote:
>> The test name has a typo (should be ClhsdbClasses - the 'b' is missing).
>> Therefore it was not actually being excluded, and therefore it runs just
>> fine with ZGC. This is expected since it is not a heap related test.
>>
>> I'
On Wed, 17 Mar 2021 01:11:25 GMT, Serguei Spitsyn wrote:
> More clear message would be something like:
> "Thread is not expected, skipping XXX event: " + ...
To me this version does not look clearer :)
I suppose you want to see a note that the event is skipped.
What do you think about
log2("Got
On Wed, 17 Mar 2021 22:23:43 GMT, Chris Plummer wrote:
> The test name has a typo (should be ClhsdbClasses - the 'b' is missing).
> Therefore it was not actually being excluded, and therefore it runs just fine
> with ZGC. This is expected since it is not a heap related test.
>
> I'd like to pu
The test name has a typo (should be ClhsdbClasses - the 'b' is missing).
Therefore it was not actually being excluded, and therefore it runs just fine
with ZGC. This is expected since it is not a heap related test.
I'd like to push this as a trivial change.
-
Commit messages:
- re
On Wed, 17 Mar 2021 19:35:20 GMT, Chris Plummer wrote:
> I'd like to push this as a trivial change.
> serviceability/sa/ClhsdbSymbol.java was problem listed with the wrong CR.
> This PR will correct that and also put the entry in sorted order.
This pull request has now been integrated.
Change
> The fix updates ResetPeakThreadCount.java test - increases number of threads,
> but relaxes conditions so start/termination of system threads don't cause
> failures.
> Additional changes:
> - store threads in a list instead of array (we need only to start/terminate
> some number of threads, so
On Tue, 16 Mar 2021 12:01:30 GMT, Yasumasa Suenaga wrote:
> jhsdb supports pmap (jhsdb jmap) and pstack (jhsdb jstack --mixed), and they
> work fine if they attach to live process or to coredump, however they do not
> work on debug server as following:
>
> $ jhsdb jmap --connect localhost
> At
On Wed, 17 Mar 2021 19:35:20 GMT, Chris Plummer wrote:
> I'd like to push this as a trivial change.
> serviceability/sa/ClhsdbSymbol.java was problem listed with the wrong CR.
> This PR will correct that and also put the entry in sorted order.
Thumbs up.
I agree that this is a trivial change.
I'd like to push this as a trivial change. serviceability/sa/ClhsdbSymbol.java
was problem listed with the wrong CR. This PR will correct that and also put
the entry in sorted order.
-
Commit messages:
- Fix problemlist entry for serviceability/sa/ClhsdbSymbol.java
Changes: https:
On 3/17/21 7:55 AM, Daniel D.Daugherty wrote:
On Wed, 17 Mar 2021 14:49:39 GMT, Daniel D. Daugherty
wrote:
A trivial fix to ProblemList serviceability/sa/ClhsdbSymbol.java on ZGC in
order to reduce the noise in the JDK17 CI.
@YaSuenag and @plummercj - just a heads up that this new test isn't
On Wed, 17 Mar 2021 14:49:39 GMT, Daniel D. Daugherty
wrote:
> A trivial fix to ProblemList serviceability/sa/ClhsdbSymbol.java on ZGC in
> order to reduce the noise in the JDK17 CI.
This pull request has now been integrated.
Changeset: b63b5d4c
Author:Daniel D. Daugherty
URL: https
On Wed, 17 Mar 2021 15:08:16 GMT, Yasumasa Suenaga wrote:
>> A trivial fix to ProblemList serviceability/sa/ClhsdbSymbol.java on ZGC in
>> order to reduce the noise in the JDK17 CI.
>
> LGTM
>
> This problem has not appeared in tests on GitHub Actions.
> https://github.com/openjdk/jdk/pull/2863/
On Wed, 17 Mar 2021 14:49:39 GMT, Daniel D. Daugherty
wrote:
> A trivial fix to ProblemList serviceability/sa/ClhsdbSymbol.java on ZGC in
> order to reduce the noise in the JDK17 CI.
LGTM
This problem has not appeared in tests on GitHub Actions.
https://github.com/openjdk/jdk/pull/2863/commits
On Wed, 17 Mar 2021 14:49:39 GMT, Daniel D. Daugherty
wrote:
> A trivial fix to ProblemList serviceability/sa/ClhsdbSymbol.java on ZGC in
> order to reduce the noise in the JDK17 CI.
@YaSuenag and @plummercj - just a heads up that this new test isn't happy with
ZGC.
-
PR: https:/
A trivial fix to ProblemList serviceability/sa/ClhsdbSymbol.java on ZGC in
order to reduce the noise in the JDK17 CI.
-
Commit messages:
- 8263732: ProblemList serviceability/sa/ClhsdbSymbol.java on ZGC
Changes: https://git.openjdk.java.net/jdk/pull/3050/files
Webrev: https://webre
On Thu, 11 Mar 2021 11:02:43 GMT, Aleksey Shipilev wrote:
> SonarCloud reports the following problem in MethodComparator::methods_EMCP:
> "Address of stack memory associated with local variable 's_new' is still
> referred to by the global variable '_s_new' upon returning to the caller.
> This
On Tue, 16 Mar 2021 23:11:49 GMT, Chris Plummer wrote:
>> Chris,
>> New test looks okay to me.
>> How did you verify it is stable on all platforms?
>> Thanks,
>> Serguei
>
>> How did you verify it is stable on all platforms?
>
> I did 100s of runs on all our platforms with both product and debu
> 8262386: resourcehogs/serviceability/sa/TestHeapDumpForLargeArray.java timed
> out
Lin Zang has updated the pull request incrementally with one additional commit
since the last revision:
rename writeThrough to unbufferedMode and code refine
-
Changes:
- all: https://git.open
On Sun, 7 Mar 2021 10:43:34 GMT, Vipin Sharma wrote:
> JDK-8261095: Add test for clhsdb "symbol" command
This pull request has now been integrated.
Changeset: 086a66a0
Author:Vipin Sharma
Committer: Yasumasa Suenaga
URL: https://git.openjdk.java.net/jdk/commit/086a66a0
Stats: 10
On Wed, 17 Mar 2021 08:16:57 GMT, Vipin Sharma wrote:
>> Marked as reviewed by ysuenaga (Reviewer).
>
> This pull request is reviewed and ready to be integrated, please sponsor the
> request.
Ok, I will sponsor you.
-
PR: https://git.openjdk.java.net/jdk/pull/2863
On Wed, 10 Mar 2021 06:04:00 GMT, Yasumasa Suenaga wrote:
>> Vipin Sharma has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> Updated formatting and grammer changes
>
> Marked as reviewed by ysuenaga (Reviewer).
This pull request is reviewe
On Tue, 16 Mar 2021 08:07:39 GMT, Robbin Ehn wrote:
>> When returning from the last Java frame back to vm and hitting a safepoint
>> poll on that last return we sometimes have a last java frame but no vframe.
>> This seem to be a bug in itself, handled in: 8263576
>>
>> Other places which uses
On Mon, 15 Mar 2021 11:48:38 GMT, Robbin Ehn wrote:
> When returning from the last Java frame back to vm and hitting a safepoint
> poll on that last return we sometimes have a last java frame but no vframe.
> This seem to be a bug in itself, handled in: 8263576
>
> Other places which uses vfram
On Wed, 17 Mar 2021 06:40:33 GMT, Serguei Spitsyn wrote:
>> Hi Lin,
>>
>> One concern I have is the naming used in the fix.
>> First, the term write-through you use is unusual and confusing.
>> Would it better to say 'direct or unbuffered output' instead?
>>
>> 612 // Now the total siz
On Wed, 17 Mar 2021 06:35:34 GMT, Aleksey Shipilev wrote:
>> SonarCloud reports the following problem in MethodComparator::methods_EMCP:
>> "Address of stack memory associated with local variable 's_new' is still
>> referred to by the global variable '_s_new' upon returning to the caller.
>> T
On Tue, 9 Mar 2021 21:08:54 GMT, Daniel D. Daugherty wrote:
> Add three tests from JDK-4413752 ported to JVM/TI:
>
> - RawMonitorEnter() with SuspendThread()
> -
> test/hotspot/jtreg/serviceability/jvmti/SuspendWithRawMonitorEnter/SuspendWithRawMonitorEnter.java
> -
> test/hotspot/jtreg/se
On Tue, 2 Mar 2021 23:27:21 GMT, Igor Ignatyev wrote:
> resurrecting old
> [RFR](https://mail.openjdk.java.net/pipermail/hotspot-dev/2020-June/041981.html):
>
>> Hi all,
>>
>> could you please review the patch which introduces a new @requires property
>> to filter out the tests which ignore e
38 matches
Mail list logo
