Re: RFR: 8263895: Test nsk/jvmti/GetThreadGroupChildren/getthrdgrpchld001/getthrdgrpchld001.cpp uses incorrect indices [v2]

2021-03-19 Thread Leonid Mesnik
> 8263895: Test > nsk/jvmti/GetThreadGroupChildren/getthrdgrpchld001/getthrdgrpchld001.cpp uses > incorrect indices Leonid Mesnik has updated the pull request incrementally with one additional commit since the last revision: Copyright updated. - Changes: - all: https://git.op

Re: RFR: 8263670: pmap and pstack in jhsdb do not work on debug server [v2]

2021-03-19 Thread Yasumasa Suenaga
On Fri, 19 Mar 2021 20:33:26 GMT, Chris Plummer wrote: >> Yasumasa Suenaga has updated the pull request incrementally with one >> additional commit since the last revision: >> >> Update testcases > > The changes look good. Just curious though, why are all the debugd tests > excluded on windo

Re: RFR: 8263895: Test nsk/jvmti/GetThreadGroupChildren/getthrdgrpchld001/getthrdgrpchld001.cpp uses incorrect indices

2021-03-19 Thread Alex Menkov
On Fri, 19 Mar 2021 22:20:35 GMT, Leonid Mesnik wrote: > 8263895: Test > nsk/jvmti/GetThreadGroupChildren/getthrdgrpchld001/getthrdgrpchld001.cpp uses > incorrect indices Marked as reviewed by amenkov (Reviewer). - PR: https://git.openjdk.java.net/jdk/pull/3098

RFR: 8263895: Test nsk/jvmti/GetThreadGroupChildren/getthrdgrpchld001/getthrdgrpchld001.cpp uses incorrect indices

2021-03-19 Thread Leonid Mesnik
8263895: Test nsk/jvmti/GetThreadGroupChildren/getthrdgrpchld001/getthrdgrpchld001.cpp uses incorrect indices - Commit messages: - 8263895: Test nsk/jvmti/GetThreadGroupChildren/getthrdgrpchld001/getthrdgrpchld001.cpp uses incorrect indices Changes: https://git.openjdk.java.net/

Re: RFR: 8262881: port JVM/DI tests from JDK-4413752 to JVM/TI [v2]

2021-03-19 Thread Daniel D . Daugherty
> Add three tests from JDK-4413752 ported to JVM/TI: > > - RawMonitorEnter() with SuspendThread() > - > test/hotspot/jtreg/serviceability/jvmti/SuspendWithRawMonitorEnter/SuspendWithRawMonitorEnter.java > - > test/hotspot/jtreg/serviceability/jvmti/SuspendWithRawMonitorEnter/libSuspendWithRa

Re: RFR: 8263670: pmap and pstack in jhsdb do not work on debug server [v2]

2021-03-19 Thread Chris Plummer
On Thu, 18 Mar 2021 05:17:10 GMT, Yasumasa Suenaga wrote: >> jhsdb supports pmap (jhsdb jmap) and pstack (jhsdb jstack --mixed), and they >> work fine if they attach to live process or to coredump, however they do not >> work on debug server as following: >> >> $ jhsdb jmap --connect localhost

Re: RFR: 8262386: resourcehogs/serviceability/sa/TestHeapDumpForLargeArray.java timed out

2021-03-19 Thread Chris Plummer
On Wed, 17 Mar 2021 07:21:06 GMT, Lin Zang wrote: > IMO, it is better to dump all array object in `write-through` mode, because > it could avoid memory consumption and performance issue when dumping large > array. And the original implementation of object dump works like > `write-through`, so

Re: RFR: 8262881: port JVM/DI tests from JDK-4413752 to JVM/TI

2021-03-19 Thread Daniel D . Daugherty
On Wed, 17 Mar 2021 07:18:07 GMT, Serguei Spitsyn wrote: >> Add three tests from JDK-4413752 ported to JVM/TI: >> >> - RawMonitorEnter() with SuspendThread() >> - >> test/hotspot/jtreg/serviceability/jvmti/SuspendWithRawMonitorEnter/SuspendWithRawMonitorEnter.java >> - >> test/hotspot/jtre

Integrated: 8262083: vmTestbase/nsk/jvmti/SetEventNotificationMode/setnotif001/TestDescription.java failed with "No notification: event JVMTI_EVENT_FRAME_POP (61)"

2021-03-19 Thread Alex Menkov
On Wed, 17 Mar 2021 23:42:46 GMT, Alex Menkov wrote: > The test requests NotifyFrame event from MethodEntry handler expecting that > 1st MethodEntry event is generated for main thread. > The fix adds a check that the thread is correct and skips event from other > threads This pull request has

Integrated: 8262080: vmTestbase/nsk/jdi/Event/request/request001/TestDescription.java failed with "ERROR: new event is not ThreadStartEvent"

2021-03-19 Thread Alex Menkov
On Wed, 10 Mar 2021 23:12:47 GMT, Alex Menkov wrote: > The fix updates the test to skip ThreadStartEvent/ThreadDeathEvent from other > threads This pull request has now been integrated. Changeset: 57fc8e9b Author:Alex Menkov URL: https://git.openjdk.java.net/jdk/commit/57fc8e9b Stat

Re: RFR: 8252842: Extend jmap to support parallel heap dump [v10]

2021-03-19 Thread Chris Plummer
On Thu, 18 Mar 2021 14:40:57 GMT, Lin Zang wrote: > * Is it acceptable that `jmap -dump` and `jmap -histo` have different > behavior about the option of `parallel`, that is, `heapdump` does not use it > and `heaphisto` does. And just to further clarify, the parallel support for `jmap -histo` i

Re: RFR: 8263572: Output from jstack mixed mode is misaligned [v2]

2021-03-19 Thread Chris Plummer
On Tue, 16 Mar 2021 06:09:25 GMT, Koichi Sakata wrote: >> When running jstack with mixed option, the output of the lines that doesn't >> have an address are misaligned as followings. >> >> $ sudo jhsdb jstack --mixed --pid 8281 >> - 8330 - >> "event-handler" #20

Re: RFR: 8176026: SA: Huge heap sizes cause a negative value to be displayed in the jhisto heap total

2021-03-19 Thread Chris Plummer
On Fri, 19 Mar 2021 11:49:39 GMT, Koichi Sakata wrote: > When a heap is used more than about 2.1GB, clhsdb jhisto shows a negative > number in the total field. > > $ java -Xmx20g Sample > > $ jhsdb clhsdb --pid 5773 > Attaching to process 5773, please wait... > hsdb> jhisto > ... > 299:

Integrated: 8262271: SA: Add new stress test that tests getting the stack trace of an active thread

2021-03-19 Thread Chris Plummer
On Thu, 25 Feb 2021 03:54:35 GMT, Chris Plummer wrote: > This a new test that runs jstack on a process that is busy doing things. It > runs jstack 4 times as the process is starting up. This pull request has now been integrated. Changeset: ed701ea6 Author:Chris Plummer URL: https://

Integrated: 8263546: Add "findsym" command to clhsdb.html help file

2021-03-19 Thread Chris Plummer
On Sat, 13 Mar 2021 00:28:48 GMT, Chris Plummer wrote: > Added clhsdb help for findsym, which was missed when the findsym command was > recently added. Also fixed a very minor typo in the findpc help. This pull request has now been integrated. Changeset: 30da9bc3 Author:Chris Plummer URL:

Re: RFR: 8263855: Use the blessed modifier order in java.management/naming [v2]

2021-03-19 Thread Claes Redestad
On Fri, 19 Mar 2021 17:13:58 GMT, Alex Blewitt wrote: >> As with #2993 changing the order of `final static` to `static final` for the >> `java.management`, `java.management.rmi` and `java.naming` modules. > > Alex Blewitt has updated the pull request incrementally with one additional > commit

Re: RFR: 8263855: Use the blessed modifier order in java.management/naming [v2]

2021-03-19 Thread Alex Blewitt
> As with #2993 changing the order of `final static` to `static final` for the > `java.management`, `java.management.rmi` and `java.naming` modules. Alex Blewitt has updated the pull request incrementally with one additional commit since the last revision: Added more replacements of 'final pu

Re: RFR: 8263855: Use the blessed modifier order in java.management/naming

2021-03-19 Thread Claes Redestad
On Thu, 18 Mar 2021 18:26:20 GMT, Alex Blewitt wrote: > As with #2993 changing the order of `final static` to `static final` for the > `java.management`, `java.management.rmi` and `java.naming` modules. Overall good - found a few cases where the private modifier is in the wrong place that oug

Re: RFR: 8263855: Use the blessed modifier order in java.management/naming

2021-03-19 Thread Alex Blewitt
On Fri, 19 Mar 2021 13:28:12 GMT, Claes Redestad wrote: >> Thanks @cl4es -- do I need to update the git commit message as well, or is >> updating the title of the PR sufficient? I recall you suggesting not to do >> amend/rebases previously. > > No, the git commit messages here doesn't matter, t

Re: RFR: 8263855: Use the blessed modifier order in java.management/naming

2021-03-19 Thread Claes Redestad
On Fri, 19 Mar 2021 13:08:24 GMT, Alex Blewitt wrote: >> Created the subtask https://bugs.openjdk.java.net/browse/JDK-8263855 for >> this along with an umbrella RFE. > > Thanks @cl4es -- do I need to update the git commit message as well, or is > updating the title of the PR sufficient? I reca

Re: RFR: 8263855: Use the blessed modifier order in java.management/naming

2021-03-19 Thread Alex Blewitt
On Fri, 19 Mar 2021 11:01:45 GMT, Claes Redestad wrote: >> @cl4es would you mind creating a parent task of something like "Source code >> cleanups" and then another sub task for this change please? > > Created the subtask https://bugs.openjdk.java.net/browse/JDK-8263855 for this > along with an

Re: RFR: 8263855: Use the blessed modifier order in java.management/naming

2021-03-19 Thread Claes Redestad
On Fri, 19 Mar 2021 10:20:39 GMT, Alex Blewitt wrote: >> Would someone mind creating a bug for me? In addition, if it would help, we >> could create a parent bug for applying cleanups and associate #2993 and >> #2991. > > @cl4es would you mind creating a parent task of something like "Source

Re: RFR: 8263855: Use the blessed modifier order in java.management/naming

2021-03-19 Thread Alex Blewitt
On Thu, 18 Mar 2021 19:33:59 GMT, Alex Blewitt wrote: >> As with #2993 changing the order of `final static` to `static final` for the >> `java.management`, `java.management.rmi` and `java.naming` modules. > > Would someone mind creating a bug for me? In addition, if it would help, we > could c

RFR: 8263855: Use the blessed modifier order in java.management/naming

2021-03-19 Thread Alex Blewitt
As with #2993 changing the order of `final static` to `static final` for the `java.management`, `java.management.rmi` and `java.naming` modules. - Commit messages: - Use the blessed modifier order in java.management/naming Changes: https://git.openjdk.java.net/jdk/pull/3078/files

Re: RFR: 8263855: Use the blessed modifier order in java.management/naming

2021-03-19 Thread Alex Blewitt
On Thu, 18 Mar 2021 18:26:20 GMT, Alex Blewitt wrote: > As with #2993 changing the order of `final static` to `static final` for the > `java.management`, `java.management.rmi` and `java.naming` modules. Would someone mind creating a bug for me? In addition, if it would help, we could create a

RFR: 8176026: SA: Huge heap sizes cause a negative value to be displayed in the jhisto heap total

2021-03-19 Thread Koichi Sakata
When a heap is used more than about 2.1GB, clhsdb jhisto shows a negative number in the total field. $ java -Xmx20g Sample $ jhsdb clhsdb --pid 5773 Attaching to process 5773, please wait... hsdb> jhisto ... 299:1 16 jdk.internal.misc.Unsafe 300:34021073761

Re: RFR: 8263572: Output from jstack mixed mode is misaligned [v2]

2021-03-19 Thread Koichi Sakata
On Tue, 16 Mar 2021 23:29:31 GMT, Chris Plummer wrote: >> Thank you for your comment, @plummercj. >> >>> What testing have you done? >> >> I added the content of the test that I've done in the body text. >> >>> Please update the copyright to 2021. >> >> Sure! >> >>> I noticed that in you ori

Re: RFR: 8263342: Add --connect option to jhsdb hsdb/clhsdb [v2]

2021-03-19 Thread Yasumasa Suenaga
On Thu, 11 Mar 2021 03:11:32 GMT, Chris Plummer wrote: >> Yasumasa Suenaga has updated the pull request incrementally with one >> additional commit since the last revision: >> >> Update testcase name > > Marked as reviewed by cjplummer (Reviewer). PiNG: could you review this? I need one more