On Tue, 23 Mar 2021 15:06:02 GMT, Aleksey Shipilev wrote:
> SonarCloud reports field `_collecting_heap_roots` is not initialized after
> constructor ends. In fact, that field is not used anywhere. It was like that
> since the initial load. We can trivially remove it.
This pull request has now
On Tue, 23 Mar 2021 23:33:02 GMT, Chris Plummer wrote:
>> Lin Zang has updated the pull request incrementally with two additional
>> commits since the last revision:
>>
>> - remove parallel option and dumpheapext command
>> - Revert "hide the dumpheapext error message"
>>
>>This rever
On Tue, 23 Mar 2021 23:25:10 GMT, Chris Plummer wrote:
>> Dear Chris，
>>
>>> I guess I don't understand why you would want write-through for small
>>> arrays but not large objects.
>>
>> I think it is because that the current implementation does not have code
>> which could calculate the obje
On Wed, 24 Mar 2021 02:10:53 GMT, Coleen Phillimore wrote:
>> Removed the TRAPS in function declarations in jvmtiRedefineClasses and in
>> ConstantPool merging functions.
>> Tested with vmTestbase/nsk/jvmti and tier1 (in progress).
>
> Coleen Phillimore has updated the pull request incrementally
On Wed, 24 Mar 2021 04:04:50 GMT, Hao Sun wrote:
> You may want to enable the GitHub Actions. Please go to
> https://github.com/horizonzy/jdk/actions and then trigger the test workflow
> on your branch.
>
> It would be fine if you do not run the test for this PR since only typo
> errors are f
On Tue, 23 Mar 2021 11:35:45 GMT, 赵延
wrote:
>> Hi, I have submitted the bug for it:
>> https://bugs.openjdk.java.net/browse/JDK-8264028 -- please change the PR
>> synopsis to "8264028: Typo in
>> javax.management.relation.RelationService::purgeRelations" to get it
>> properly hooked to PR me
On Wed, 24 Mar 2021 03:22:05 GMT, Coleen Phillimore wrote:
>> This change removes the TRAPS parameter from compute_modifier_flags(),
>> lookup_instance_method_in_klasses and nest_host_error.
>>
>> There's a progressive effort to remove cases where the last parameter of a
>> function is THREAD,
On Wed, 24 Mar 2021 03:07:42 GMT, Coleen Phillimore wrote:
>> src/hotspot/share/oops/instanceKlass.hpp line 468:
>>
>>> 466: void set_nest_host_index(u2 i) { _nest_host_index = i; }
>>> 467: // dynamic nest member support
>>> 468: void set_nest_host(InstanceKlass* host, JavaThread* curren
> This change removes the TRAPS parameter from compute_modifier_flags(),
> lookup_instance_method_in_klasses and nest_host_error.
>
> There's a progressive effort to remove cases where the last parameter of a
> function is THREAD, and it's unclear why it is ignoring an exception or
> whether an
On Tue, 23 Mar 2021 21:07:02 GMT, Ioi Lam wrote:
>> Coleen Phillimore has updated the pull request incrementally with one
>> additional commit since the last revision:
>>
>> Fix load_new_class_versions and remove more traps.
>
> src/hotspot/share/prims/jvmtiRedefineClasses.cpp line 1389:
>
>
On Wed, 24 Mar 2021 02:45:29 GMT, David Holmes wrote:
>> This change removes the TRAPS parameter from compute_modifier_flags(),
>> lookup_instance_method_in_klasses and nest_host_error.
>>
>> There's a progressive effort to remove cases where the last parameter of a
>> function is THREAD, and
On Tue, 23 Mar 2021 16:40:44 GMT, Coleen Phillimore wrote:
> This change removes the TRAPS parameter from compute_modifier_flags(),
> lookup_instance_method_in_klasses and nest_host_error.
>
> There's a progressive effort to remove cases where the last parameter of a
> function is THREAD, and
On Wed, 24 Mar 2021 02:10:53 GMT, Coleen Phillimore wrote:
>> Removed the TRAPS in function declarations in jvmtiRedefineClasses and in
>> ConstantPool merging functions.
>> Tested with vmTestbase/nsk/jvmti and tier1 (in progress).
>
> Coleen Phillimore has updated the pull request incrementally
> Removed the TRAPS in function declarations in jvmtiRedefineClasses and in
> ConstantPool merging functions.
> Tested with vmTestbase/nsk/jvmti and tier1 (in progress).
Coleen Phillimore has updated the pull request incrementally with one
additional commit since the last revision:
Add Except
On Tue, 16 Mar 2021 02:39:02 GMT, Yasumasa Suenaga wrote:
>> Sorry. I was running an old jhsdb. So we already have --registryport 2000
>> --rmiport, and you can already specify [:] as part of the
>> debugserver. So what needs to be added is just --servernameprefix, and
>> better help for expla
On Mon, 22 Mar 2021 12:35:52 GMT, Lin Zang wrote:
>> 8252842: Extend jmap to support parallel heap dump
>
> Lin Zang has updated the pull request incrementally with two additional
> commits since the last revision:
>
> - remove parallel option and dumpheapext command
> - Revert "hide the dump
On Tue, 23 Mar 2021 16:08:59 GMT, Coleen Phillimore wrote:
>> Removed the TRAPS in function declarations in jvmtiRedefineClasses and in
>> ConstantPool merging functions.
>> Tested with vmTestbase/nsk/jvmti and tier1 (in progress).
>
> Coleen Phillimore has updated the pull request incrementally
On Mon, 22 Mar 2021 04:12:18 GMT, Lin Zang wrote:
> > I guess I don't understand why you would want write-through for small
> > arrays but not large objects.
>
> I think it is because that the current implementation does not have code
> which could calculate the object size before scan it. but
8264087: Use the blessed modifier order in jdk.jconsole
-
Commit messages:
- 8264087: Use the blessed modifier order in jdk.jconsole
Changes: https://git.openjdk.java.net/jdk/pull/3164/files
Webrev: https://webrevs.openjdk.java.net/?repo=jdk&pr=3164&range=00
Issue: https://bugs.o
On Tue, 23 Mar 2021 16:08:59 GMT, Coleen Phillimore wrote:
>> Removed the TRAPS in function declarations in jvmtiRedefineClasses and in
>> ConstantPool merging functions.
>> Tested with vmTestbase/nsk/jvmti and tier1 (in progress).
>
> Coleen Phillimore has updated the pull request incrementally
On Mon, 15 Mar 2021 07:29:16 GMT, Koichi Sakata wrote:
> When running jstack with mixed option, the output of the lines that doesn't
> have an address are misaligned as followings.
>
> $ sudo jhsdb jstack --mixed --pid 8281
> - 8330 -
> "event-handler" #20 daemo
On Tue, 23 Mar 2021 13:35:05 GMT, Koichi Sakata wrote:
>> When a heap is used more than about 2.1GB, clhsdb jhisto shows a negative
>> number in the total field.
>>
>> $ java -Xmx20g Sample
>>
>> $ jhsdb clhsdb --pid 5773
>> Attaching to process 5773, please wait...
>> hsdb> jhisto
>> ...
>> 2
On Tue, 23 Mar 2021 16:33:15 GMT, Daniel D. Daugherty
wrote:
>> Coleen Phillimore has updated the pull request incrementally with one
>> additional commit since the last revision:
>>
>> Fix load_new_class_versions and remove more traps.
>
> Looks good.
>
> You should also do JDI test runs
On Tue, 23 Mar 2021 16:40:44 GMT, Coleen Phillimore wrote:
> This change removes the TRAPS parameter from compute_modifier_flags(),
> lookup_instance_method_in_klasses and nest_host_error.
>
> There's a progressive effort to remove cases where the last parameter of a
> function is THREAD, and
On Tue, 23 Mar 2021 15:06:02 GMT, Aleksey Shipilev wrote:
> SonarCloud reports field `_collecting_heap_roots` is not initialized after
> constructor ends. In fact, that field is not used anywhere. It was like that
> since the initial load. We can trivially remove it.
Lgtm and trivial.
---
This change removes the TRAPS parameter from compute_modifier_flags(),
lookup_instance_method_in_klasses and nest_host_error.
There's a progressive effort to remove cases where the last parameter of a
function is THREAD, and it's unclear why it is ignoring an exception or whether
an exception i
On Tue, 23 Mar 2021 16:20:47 GMT, Ludovic Henry wrote:
>> Anton Kozlov has updated the pull request with a new target base due to a
>> merge or a rebase. The pull request now contains 115 commits:
>>
>> - Merge branch 'master' into jdk-macos
>> - JDK-8262491: bsd_aarch64 part
>> - JDK-826300
On Tue, 23 Mar 2021 13:39:06 GMT, Coleen Phillimore wrote:
>> I kind of thought these would make a long complicated expression and so the
>> single use variables is helpful. I don't think performance is important
>> here.
>
> {code}
> - match = compare_entry_to(recur1, cp2, recur2);
On Tue, 23 Mar 2021 16:08:59 GMT, Coleen Phillimore wrote:
>> Removed the TRAPS in function declarations in jvmtiRedefineClasses and in
>> ConstantPool merging functions.
>> Tested with vmTestbase/nsk/jvmti and tier1 (in progress).
>
> Coleen Phillimore has updated the pull request incrementally
On Mon, 22 Mar 2021 12:50:14 GMT, Anton Kozlov wrote:
>> Please review the implementation of JEP 391: macOS/AArch64 Port.
>>
>> It's heavily based on existing ports to linux/aarch64, macos/x86_64, and
>> windows/aarch64.
>>
>> Major changes are in:
>> * src/hotspot/cpu/aarch64: support of the
> Removed the TRAPS in function declarations in jvmtiRedefineClasses and in
> ConstantPool merging functions.
> Tested with vmTestbase/nsk/jvmti and tier1 (in progress).
Coleen Phillimore has updated the pull request incrementally with one
additional commit since the last revision:
Fix load_n
On Tue, 23 Mar 2021 15:36:02 GMT, Harold Seigel wrote:
>> Coleen Phillimore has updated the pull request incrementally with one
>> additional commit since the last revision:
>>
>> Fix some obvious single use variables.
>
> Latest changes look good.
> Thanks, Harold
In your comments above, th
On Tue, 23 Mar 2021 15:05:59 GMT, Coleen Phillimore wrote:
>> Removed the TRAPS in function declarations in jvmtiRedefineClasses and in
>> ConstantPool merging functions.
>> Tested with vmTestbase/nsk/jvmti and tier1 (in progress).
>
> Coleen Phillimore has updated the pull request incrementally
On Mon, 22 Mar 2021 12:50:14 GMT, Anton Kozlov wrote:
>> Please review the implementation of JEP 391: macOS/AArch64 Port.
>>
>> It's heavily based on existing ports to linux/aarch64, macos/x86_64, and
>> windows/aarch64.
>>
>> Major changes are in:
>> * src/hotspot/cpu/aarch64: support of the
On Tue, 23 Mar 2021 15:06:02 GMT, Aleksey Shipilev wrote:
> SonarCloud reports field `_collecting_heap_roots` is not initialized after
> constructor ends. In fact, that field is not used anywhere. It was like that
> since the initial load. We can trivially remove it.
SCCS says it was used once
SonarCloud reports field `_collecting_heap_roots` is not initialized after
constructor ends. In fact, that field is not used anywhere. It was like that
since the initial load. We can trivially remove it.
-
Commit messages:
- 8264050: Remove unused field VM_HeapWalkOperation::_colle
> Removed the TRAPS in function declarations in jvmtiRedefineClasses and in
> ConstantPool merging functions.
> Tested with vmTestbase/nsk/jvmti and tier1 (in progress).
Coleen Phillimore has updated the pull request incrementally with one
additional commit since the last revision:
Fix some o
On Sun, 21 Mar 2021 15:15:54 GMT, lyndseyBeil
wrote:
>> Daniel D. Daugherty has updated the pull request incrementally with one
>> additional commit since the last revision:
>>
>> sspitsyn - fix white space indents problems.
>
> test/hotspot/jtreg/serviceability/jvmti/SuspendWithObjectMonito
On Tue, 23 Mar 2021 14:01:12 GMT, Vladimir Kempik wrote:
> > > [ Back-porting this patch to JDK 11] depends on the will of openjdk11
> > > maintainers to accept this (and few other, like jep-388, as we depend on
> > > it) contribution.
> >
> >
> > To the extent that 11u has fixed policies :)
On Tue, 23 Mar 2021 01:47:45 GMT, Serguei Spitsyn wrote:
>> @robehn - Thanks for the review and for the suggested improvements to the
>> tests.
>> It will take me a bit of time to make and test these suggestions.
>
> Hi Dan,
>> I figured you would enjoy this 20 year old blast from the past!
> Ye
On Fri, 19 Mar 2021 19:40:13 GMT, Chris Plummer wrote:
>> Koichi Sakata has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> Fix the sort bug for huge bytes in jhisto
>
> I see another cast-to-int related bug, and it's visible in your jhisto
On Tue, 23 Mar 2021 13:58:03 GMT, Andrew Haley wrote:
> > [ Back-porting this patch to JDK 11] depends on the will of openjdk11
> > maintainers to accept this (and few other, like jep-388, as we depend on
> > it) contribution.
>
> To the extent that 11u has fixed policies :) we definitely have
On Tue, 23 Mar 2021 13:54:24 GMT, Andrew Haley wrote:
>> Anton Kozlov has updated the pull request with a new target base due to a
>> merge or a rebase. The pull request now contains 115 commits:
>>
>> - Merge branch 'master' into jdk-macos
>> - JDK-8262491: bsd_aarch64 part
>> - JDK-8263002
On Mon, 22 Mar 2021 12:50:14 GMT, Anton Kozlov wrote:
>> Please review the implementation of JEP 391: macOS/AArch64 Port.
>>
>> It's heavily based on existing ports to linux/aarch64, macos/x86_64, and
>> windows/aarch64.
>>
>> Major changes are in:
>> * src/hotspot/cpu/aarch64: support of the
On Tue, 23 Mar 2021 13:26:19 GMT, Anton Kozlov wrote:
>> Build changes still look good. Hope you can get this done now! :)
>
>> > No, no, no! I am not suggesting you change anything else, just that
>> > you do not define contentless macros. You might as well define it
>> > to be something, and tr
On Tue, 23 Mar 2021 13:33:49 GMT, Coleen Phillimore wrote:
>> src/hotspot/share/oops/constantPool.cpp line 1426:
>>
>>> 1424: bool match_entry = compare_entry_to(k1, cp2, k2);
>>> 1425: bool match_operand = compare_operand_to(i1, cp2, i2);
>>> 1426: return (match_entry && match_opera
On Tue, 23 Mar 2021 13:14:15 GMT, Harold Seigel wrote:
>> Coleen Phillimore has updated the pull request incrementally with one
>> additional commit since the last revision:
>>
>> missed THREAD that should be CHECK_false argument.
>
> src/hotspot/share/oops/constantPool.cpp line 1426:
>
>> 1
On Tue, 23 Mar 2021 01:22:56 GMT, Coleen Phillimore wrote:
>> Removed the TRAPS in function declarations in jvmtiRedefineClasses and in
>> ConstantPool merging functions.
>> Tested with vmTestbase/nsk/jvmti and tier1 (in progress).
>
> Coleen Phillimore has updated the pull request incrementally
> When a heap is used more than about 2.1GB, clhsdb jhisto shows a negative
> number in the total field.
>
> $ java -Xmx20g Sample
>
> $ jhsdb clhsdb --pid 5773
> Attaching to process 5773, please wait...
> hsdb> jhisto
> ...
> 299:1 16 jdk.internal.misc.Unsafe
> 300:
On Tue, 23 Mar 2021 12:49:34 GMT, Magnus Ihse Bursie wrote:
>> Anton Kozlov has updated the pull request with a new target base due to a
>> merge or a rebase. The pull request now contains 115 commits:
>>
>> - Merge branch 'master' into jdk-macos
>> - JDK-8262491: bsd_aarch64 part
>> - JDK-8
On Tue, 23 Mar 2021 01:22:56 GMT, Coleen Phillimore wrote:
>> Removed the TRAPS in function declarations in jvmtiRedefineClasses and in
>> ConstantPool merging functions.
>> Tested with vmTestbase/nsk/jvmti and tier1 (in progress).
>
> Coleen Phillimore has updated the pull request incrementally
On 23/03/2021 9:54 pm, Coleen Phillimore wrote:
On Tue, 23 Mar 2021 05:52:51 GMT, Ioi Lam wrote:
src/hotspot/share/prims/jvmtiRedefineClasses.hpp line 484:
482: void rewrite_cp_refs_in_method(methodHandle method,
483: methodHandle * new_method_p, TRAPS);
484: bool rewrite_cp_refs_in_
On Mon, 22 Mar 2021 12:50:14 GMT, Anton Kozlov wrote:
>> Please review the implementation of JEP 391: macOS/AArch64 Port.
>>
>> It's heavily based on existing ports to linux/aarch64, macos/x86_64, and
>> windows/aarch64.
>>
>> Major changes are in:
>> * src/hotspot/cpu/aarch64: support of the
On Mon, 22 Mar 2021 12:50:14 GMT, Anton Kozlov wrote:
>> Please review the implementation of JEP 391: macOS/AArch64 Port.
>>
>> It's heavily based on existing ports to linux/aarch64, macos/x86_64, and
>> windows/aarch64.
>>
>> Major changes are in:
>> * src/hotspot/cpu/aarch64: support of the
On Tue, 23 Mar 2021 02:49:52 GMT, Serguei Spitsyn wrote:
>> Koichi Sakata has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> Fix calculation for the length of white space
>
> Hi Koichi,
> It looks good to me. Thank you for the contribution!
On Mon, 22 Mar 2021 15:49:24 GMT, Coleen Phillimore wrote:
> From CR:
> The useful/general BasicHashtable uses a block allocation scheme to
> reportedly reduce fragmentation. When the StringTable and SymbolTable used to
> use this hashtable, performance benefits were reportedly observed because
On Mon, 22 Mar 2021 23:08:09 GMT, Ioi Lam wrote:
>> Coleen Phillimore has updated the pull request incrementally with one
>> additional commit since the last revision:
>>
>> Fix Hashtable constructor and comments.
>
> Marked as reviewed by iklam (Reviewer).
Thanks Lois and Ioi!
On Tue, 23 Mar 2021 05:52:51 GMT, Ioi Lam wrote:
>> src/hotspot/share/prims/jvmtiRedefineClasses.hpp line 484:
>>
>>> 482: void rewrite_cp_refs_in_method(methodHandle method,
>>> 483: methodHandle * new_method_p, TRAPS);
>>> 484: bool rewrite_cp_refs_in_methods(InstanceKlass* scratch_cla
On Tue, 23 Mar 2021 11:01:10 GMT, Aleksey Shipilev wrote:
> Hi, I have submitted the bug for it:
> https://bugs.openjdk.java.net/browse/JDK-8264028 -- please change the PR
> synopsis to "8264028: Typo in
> javax.management.relation.RelationService::purgeRelations" to get it properly
> hooked
On Tue, 9 Mar 2021 01:25:10 GMT, 赵延
wrote:
>> Hi. Just a reminder for you that the copyright year should be updated to
>> 2021.
>
>> Hi. Just a reminder for you that the copyright year should be updated to
>> 2021.
>
> thanks
Hi, I have submitted the bug for it:
https://bugs.openjdk.java.ne
On Tue, 9 Mar 2021 01:19:11 GMT, Hao Sun wrote:
> Hi. Just a reminder for you that the copyright year should be updated to 2021.
thanks
-
PR: https://git.openjdk.java.net/jdk/pull/2765
On Wed, 3 Mar 2021 16:52:36 GMT, Dalibor Topic wrote:
>> 8264028: Typo in javax.management.relation.RelationService::purgeRelations
>
> Hi, please contact me at dalibor.to...@oracle.com so that I can validate your
> OCA.
Hi. Just a reminder for you that the copyright year should be updated to 2
8264028: Typo in javax.management.relation.RelationService::purgeRelations
-
Commit messages:
- update copyright.
- typo fix.
Changes: https://git.openjdk.java.net/jdk/pull/2765/files
Webrev: https://webrevs.openjdk.java.net/?repo=jdk&pr=2765&range=00
Issue: https://bugs.openjdk
On Sun, 28 Feb 2021 10:48:55 GMT, 赵延
wrote:
> 8264028: Typo in javax.management.relation.RelationService::purgeRelations
Hi, please contact me at dalibor.to...@oracle.com so that I can validate your
OCA.
-
PR: https://git.openjdk.java.net/jdk/pull/2765
On Tue, 23 Mar 2021 09:54:16 GMT, Andrew Haley wrote:
> So, where are we up to now? Are we done yet?
Hello
we would like to get approval for the final version we have now and then
integrate this pr as soon as Mark will target it to jdk17
-
PR: https://git.openjdk.java.net/jdk/pull
On Fri, 12 Mar 2021 16:32:10 GMT, Andrew Haley wrote:
>> Anton Kozlov has updated the pull request with a new target base due to a
>> merge or a rebase. The pull request now contains 105 commits:
>>
>> - Merge commit 'refs/pull/11/head' of https://github.com/AntonKozlov/jdk
>> into jdk-macos
On Tue, 23 Mar 2021 09:53:54 GMT, Andrew Haley wrote:
>>> @theRealAph, could you elaborate on what is need to be done for [#2200
>>> (review)](https://github.com/openjdk/jdk/pull/2200#pullrequestreview-600597066).
>>
>> I think that what you've got now is fine.
>
>> _Mailing list message from [
67 matches
Mail list logo
