Re: RFR: 8259070: Add jcmd option to dump CDS [v6]

2021-03-24 Thread Calvin Cheung
On Wed, 24 Mar 2021 15:35:55 GMT, Yumin Qi wrote: >> Hi, Please review >> >> Added jcmd option for dumping CDS archive during application runtime. >> Before this change, user has to dump shared archive in two steps: first run >> application with >> `java -XX:DumpLoadedClassList= ` >

Re: RFR: 8259070: Add jcmd option to dump CDS [v6]

2021-03-24 Thread Calvin Cheung
On Wed, 24 Mar 2021 15:35:55 GMT, Yumin Qi wrote: >> Hi, Please review >> >> Added jcmd option for dumping CDS archive during application runtime. >> Before this change, user has to dump shared archive in two steps: first run >> application with >> `java -XX:DumpLoadedClassList= ` >

Re: RFR: 8176026: SA: Huge heap sizes cause a negative value to be displayed in the jhisto heap total [v2]

2021-03-24 Thread Marcus G K Williams
On Tue, 23 Mar 2021 13:35:05 GMT, Koichi Sakata wrote: >> When a heap is used more than about 2.1GB, clhsdb jhisto shows a negative >> number in the total field. >> >> $ java -Xmx20g Sample >> >> $ jhsdb clhsdb --pid 5773 >> Attaching to process 5773, please wait... >> hsdb> jhisto >> ... >> 2

Re: RFR: 8259070: Add jcmd option to dump CDS [v6]

2021-03-24 Thread Yumin Qi
> Hi, Please review > > Added jcmd option for dumping CDS archive during application runtime. > Before this change, user has to dump shared archive in two steps: first run > application with > `java -XX:DumpLoadedClassList= ` > to collect shareable class names and saved in file `` ,

Re: RFR: 8264051: Remove unused TRAPS parameters from runtime functions [v2]

2021-03-24 Thread Coleen Phillimore
On Wed, 24 Mar 2021 03:50:14 GMT, David Holmes wrote: >> Coleen Phillimore has updated the pull request incrementally with one >> additional commit since the last revision: >> >> removed thread parameter from nest_host_error and callers. > > Looks good! > > Thanks, > David Thanks for review

Integrated: 8264051: Remove unused TRAPS parameters from runtime functions

2021-03-24 Thread Coleen Phillimore
On Tue, 23 Mar 2021 16:40:44 GMT, Coleen Phillimore wrote: > This change removes the TRAPS parameter from compute_modifier_flags(), > lookup_instance_method_in_klasses and nest_host_error. > > There's a progressive effort to remove cases where the last parameter of a > function is THREAD, and

Integrated: 8264004: Don't use TRAPS if no exceptions are thrown

2021-03-24 Thread Coleen Phillimore
On Tue, 23 Mar 2021 01:04:00 GMT, Coleen Phillimore wrote: > Removed the TRAPS in function declarations in jvmtiRedefineClasses and in > ConstantPool merging functions. > Tested with vmTestbase/nsk/jvmti and tier1 (in progress). This pull request has now been integrated. Changeset: 5d7e93c8 Au

Re: RFR: 8264004: Don't use TRAPS if no exceptions are thrown [v5]

2021-03-24 Thread Coleen Phillimore
On Wed, 24 Mar 2021 05:42:06 GMT, Ioi Lam wrote: >> Coleen Phillimore has updated the pull request incrementally with one >> additional commit since the last revision: >> >> Add ExceptionMarks. > > Marked as reviewed by iklam (Reviewer). Thanks for reviewing! - PR: https://git.