Re: RFR: 8264148: Update spec for exceptions retrofitted for exception chaining

On Thu, 25 Mar 2021 18:52:54 GMT, Stuart Marks wrote: > One special case is the **public field** in `WriteAbortedException`. This is > really bad and something ought to be done about this, including deprecation, > and maybe more. This implies that the exception is mutable, right? Hrrmph. > Isn

Re: RFR: 8263854: Use the blessed modifier in jdk.internal.jvmstat

On Mon, 29 Mar 2021 21:00:20 GMT, Alex Blewitt wrote: > 8263854: Use the blessed modifier in jdk.internal.jvmstat The changes look fine, but you need to fix the CR number. It should be JDK-8264396. Also copyrights need updating. - Changes requested by cjplummer (Reviewer). PR: h

Re: RFR: 8264285: Clean the modification of ccstr JVM flags

On Mon, 29 Mar 2021 21:35:52 GMT, Ioi Lam wrote: > There are two versions of JVMFlagAccess::ccstrAtPut() for modifying JVM flags > of the ccstr type (i.e., strings). > > - One version requires the caller to free the old value, but some callers > don't do that (writeableFlags.cpp). > - The othe

Re: RFR: 8259070: Add jcmd option to dump CDS [v7]

> Hi, Please review > > Added jcmd option for dumping CDS archive during application runtime. > Before this change, user has to dump shared archive in two steps: first run > application with > `java -XX:DumpLoadedClassList= ` > to collect shareable class names and saved in file `` ,

Re: RFR: 8264193: Remove TRAPS parameters for modules and defaultmethods

On Mon, 29 Mar 2021 17:40:09 GMT, Harold Seigel wrote: > Please review this change for JDK-8264193 to remove unneeded TRAPS parameters > from modules and default methods files. Besides removing TRAPS, > Modules::get_named_module() was changed to return an oop instead of a > jobject, removing

Re: RFR: 8264193: Remove TRAPS parameters for modules and defaultmethods

On Mon, 29 Mar 2021 17:40:09 GMT, Harold Seigel wrote: > Please review this change for JDK-8264193 to remove unneeded TRAPS parameters > from modules and default methods files. Besides removing TRAPS, > Modules::get_named_module() was changed to return an oop instead of a > jobject, removing

Re: RFR: 8264124: Update MXBean specification and implementation to extend mapping of CompositeType to records [v2]

On Sat, 27 Mar 2021 01:49:38 GMT, Mandy Chung wrote: >> src/java.management/share/classes/javax/management/MXBean.java line 757: >> >>> 755: >>> 756: If the class is a {@link Record}, its getters are the >>> 757: accessors for the record components. Otherwise, the >> >> It may be goo

RFR: 8264285: Clean the modification of ccstr JVM flags

There are two versions of JVMFlagAccess::ccstrAtPut() for modifying JVM flags of the ccstr type (i.e., strings). - One version requires the caller to free the old value, but some callers don't do that (writeableFlags.cpp). - The other version frees the old value on behalf of the caller. However,

Re: RFR: 8264148: Update spec for exceptions retrofitted for exception chaining

On Thu, 25 Mar 2021 18:52:54 GMT, Stuart Marks wrote: >> 8264148: Update spec for exceptions retrofitted for exception chaining > > The removal of the obsolescent "As of release 1.4, this exception has been > retrofitted..." is good. Changing the calls from the other exception-getting > methods

RFR: 8264148: Update spec for exceptions retrofitted for exception chaining

8264148: Update spec for exceptions retrofitted for exception chaining - Commit messages: - Respond to review feedback. - Respond to review feedback. - Merge branch 'master' into 8264148 - Merge branch 'master' into 8264148 - 8264148: Update spec for exceptions retrofitted for ex

Re: RFR: 8264148: Update spec for exceptions retrofitted for exception chaining

On Wed, 24 Mar 2021 23:17:46 GMT, Joe Darcy wrote: > 8264148: Update spec for exceptions retrofitted for exception chaining The removal of the obsolescent "As of release 1.4, this exception has been retrofitted..." is good. Changing the calls from the other exception-getting methods to `getCau

RFR: 8263854: Use the blessed modifier in jdk.internal.jvmstat

8263854: Use the blessed modifier in jdk.internal.jvmstat - Commit messages: - 8263854: Use the blessed modifier in jdk.internal.jvmstat Changes: https://git.openjdk.java.net/jdk/pull/3252/files Webrev: https://webrevs.openjdk.java.net/?repo=jdk&pr=3252&range=00 Issue: https://bu

Re: RFR: 8264193: Remove TRAPS parameters for modules and defaultmethods

On Mon, 29 Mar 2021 17:40:09 GMT, Harold Seigel wrote: > Please review this change for JDK-8264193 to remove unneeded TRAPS parameters > from modules and default methods files. Besides removing TRAPS, > Modules::get_named_module() was changed to return an oop instead of a > jobject, removing

Re: RFR: 8264193: Remove TRAPS parameters for modules and defaultmethods

On Mon, 29 Mar 2021 17:40:09 GMT, Harold Seigel wrote: > Please review this change for JDK-8264193 to remove unneeded TRAPS parameters > from modules and default methods files. Besides removing TRAPS, > Modules::get_named_module() was changed to return an oop instead of a > jobject, removing

RFR: 8264193: Remove TRAPS parameters for modules and defaultmethods

Please review this change for JDK-8264193 to remove unneeded TRAPS parameters from modules and default methods files. Besides removing TRAPS, Modules::get_named_module() was changed to return an oop instead of a jobject, removing its need for a TRAPS parameter. This change was tested with Mach

Re: RFR: 8252842: Extend jmap to support parallel heap dump [v19]

> 8252842: Extend jmap to support parallel heap dump Lin Zang has updated the pull request with a new target base due to a merge or a rebase. The pull request now contains 24 commits: - Merge branch 'master' into par-dump - Typo fix - remove parallel option and dumpheapext command - Revert "