On Tue, 30 Mar 2021 20:37:45 GMT, Alex Blewitt
wrote:
>> 8264396: Use the blessed modifier order in jdk.internal.jvmstat
>
> Alex Blewitt has updated the pull request incrementally with one additional
> commit since the last revision:
>
> Updated copyright dates
Looks fine to me as well.
-
On Fri, 19 Mar 2021 05:39:25 GMT, Ioi Lam wrote:
>> Yumin Qi has updated the pull request with a new target base due to a merge
>> or a rebase. The incremental webrev excludes the unrelated changes brought
>> in by the merge/rebase. The pull request contains five additional commits
>> since th
On Tue, 30 Mar 2021 03:48:08 GMT, Yumin Qi wrote:
>> Hi, Please review
>>
>> Added jcmd option for dumping CDS archive during application runtime.
>> Before this change, user has to dump shared archive in two steps: first run
>> application with
>> `java -XX:DumpLoadedClassList= `
>
On 31/03/2021 3:41 am, Roman Kennke wrote:
On Tue, 30 Mar 2021 17:12:52 GMT, Chris Plummer wrote:
You'll need a CSR for this enhancement.
Hmm, yeah.
I'm wondering if this should rather go into the Lilliput repository once it is
created (I'd expect in ~1week or so). Then it would be refined
> …ue to large TLAB size
>
> serviceability/jvmti/HeapMonitor tests intermittently fail when using
> PS/Serial GC, original test has implicit assumptions on TLAB size and depends
> on allocate fix amount of objects to consume TLAB and trigger object
> sampling. These tests will fail if TLAB is
On Tue, 30 Mar 2021 20:29:18 GMT, Chris Plummer wrote:
>>> You'll need a CSR for this enhancement.
>>
>> Hmm, yeah.
>> I'm wondering if this should rather go into the Lilliput repository once it
>> is created (I'd expect in ~1week or so). Then it would be refined during
>> Lilliput project liv
On Tue, 30 Mar 2021 09:33:19 GMT, Richard Reingruber wrote:
>> Robbin Ehn has updated the pull request with a new target base due to a
>> merge or a rebase. The pull request now contains two commits:
>>
>> - Merge branch 'master' into SuspendInHandshake
>> - 8257831: Suspend with handshake (r
On Fri, 26 Mar 2021 13:21:43 GMT, Robbin Ehn wrote:
>> A suspend request is done by handshaking thread target thread(s). When
>> executing the handshake operation we know the target mutator thread is in a
>> dormant state (as in safepoint safe state). We have a guarantee that it will
>> check
> 8264396: Use the blessed modifier order in jdk.internal.jvmstat
Alex Blewitt has updated the pull request incrementally with one additional
commit since the last revision:
Updated copyright dates
-
Changes:
- all: https://git.openjdk.java.net/jdk/pull/3252/files
- new: http
On Tue, 30 Mar 2021 17:38:40 GMT, Roman Kennke wrote:
>> You'll need a CSR for this enhancement.
>
>> You'll need a CSR for this enhancement.
>
> Hmm, yeah.
> I'm wondering if this should rather go into the Lilliput repository once it
> is created (I'd expect in ~1week or so). Then it would be
On Wed, 24 Mar 2021 23:17:46 GMT, Joe Darcy wrote:
> 8264148: Update spec for exceptions retrofitted for exception chaining
This pull request has now been integrated.
Changeset: 815248ab
Author:Joe Darcy
URL: https://git.openjdk.java.net/jdk/commit/815248ab
Stats: 84 lines in 22
> Add three tests from JDK-4413752 ported to JVM/TI:
>
> - RawMonitorEnter() with SuspendThread()
> -
> test/hotspot/jtreg/serviceability/jvmti/SuspendWithRawMonitorEnter/SuspendWithRawMonitorEnter.java
> -
> test/hotspot/jtreg/serviceability/jvmti/SuspendWithRawMonitorEnter/libSuspendWithRa
On Tue, 30 Mar 2021 17:12:52 GMT, Chris Plummer wrote:
> You'll need a CSR for this enhancement.
Hmm, yeah.
I'm wondering if this should rather go into the Lilliput repository once it is
created (I'd expect in ~1week or so). Then it would be refined during Lilliput
project live time, and event
On Fri, 26 Mar 2021 13:21:43 GMT, Robbin Ehn wrote:
>> A suspend request is done by handshaking thread target thread(s). When
>> executing the handshake operation we know the target mutator thread is in a
>> dormant state (as in safepoint safe state). We have a guarantee that it will
>> check
On Sun, 28 Feb 2021 10:48:55 GMT, 赵延
wrote:
> 8264028: Typo in javax.management.relation.RelationService::purgeRelations
Looks good.
Thanks,
Serguei
-
Marked as reviewed by sspitsyn (Reviewer).
PR: https://git.openjdk.java.net/jdk/pull/2765
On Tue, 30 Mar 2021 15:04:57 GMT, Roman Kennke wrote:
> For Lilliput evaluation, it would be useful to be able to get some statistics
> about heap objects, e.g. how many objects there typically are, what is their
> (average) size, how big is the live data set, how many objecs have an
> identit
On Wed, 24 Mar 2021 23:17:46 GMT, Joe Darcy wrote:
> 8264148: Update spec for exceptions retrofitted for exception chaining
Marked as reviewed by smarks (Reviewer).
-
PR: https://git.openjdk.java.net/jdk/pull/3182
On 3/30/2021 6:29 AM, Roger Riggs wrote:
On Wed, 24 Mar 2021 23:17:46 GMT, Joe Darcy wrote:
8264148: Update spec for exceptions retrofitted for exception chaining
I agree that the public field in WriteAbortedException could be remediated.
But it is also mostly harmless.
src/jdk.hotspot.age
On 3/30/2021 6:43 AM, jmehrens wrote:
On Wed, 24 Mar 2021 23:17:46 GMT, Joe Darcy wrote:
8264148: Update spec for exceptions retrofitted for exception chaining
src/java.base/share/classes/java/io/WriteAbortedException.java line 86:
84: @Override
85: public Throwable getCause() {
8
On Wed, 24 Mar 2021 23:17:46 GMT, Joe Darcy wrote:
> 8264148: Update spec for exceptions retrofitted for exception chaining
src/java.base/share/classes/java/io/WriteAbortedException.java line 86:
> 84: @Override
> 85: public Throwable getCause() {
> 86: return detail;
Use Suppr
On Wed, 24 Mar 2021 23:17:46 GMT, Joe Darcy wrote:
> 8264148: Update spec for exceptions retrofitted for exception chaining
I agree that the public field in WriteAbortedException could be remediated.
But it is also mostly harmless.
src/jdk.hotspot.agent/share/classes/sun/jvm/hotspot/runtime/VMO
On Mon, 29 Mar 2021 17:40:09 GMT, Harold Seigel wrote:
> Please review this change for JDK-8264193 to remove unneeded TRAPS parameters
> from modules and default methods files. Besides removing TRAPS,
> Modules::get_named_module() was changed to return an oop instead of a
> jobject, removing
…ue to large TLAB size
serviceability/jvmti/HeapMonitor tests intermittently fail when using PS/Serial
GC, original test has implicit assumptions on TLAB size and depends on allocate
fix amount of objects to consume TLAB and trigger object sampling. These tests
will fail if TLAB is above 20M (t
On Tue, 30 Mar 2021 01:40:02 GMT, David Holmes wrote:
>> Please review this change for JDK-8264193 to remove unneeded TRAPS
>> parameters from modules and default methods files. Besides removing TRAPS,
>> Modules::get_named_module() was changed to return an oop instead of a
>> jobject, removi
On Mon, 29 Mar 2021 21:00:20 GMT, Alex Blewitt
wrote:
> 8263854: Use the blessed modifier in jdk.internal.jvmstat
Agreed, change looks good.
-
Marked as reviewed by kevinw (Committer).
PR: https://git.openjdk.java.net/jdk/pull/3252
25 matches
Mail list logo
