Re: RFR: 8264411: serviceability/jvmti/HeapMonitor tests intermittently fail due to large TLAB size [v3]

2021-04-02 Thread Hui Shi
On Sat, 3 Apr 2021 04:24:47 GMT, Hui Shi wrote: >> test/hotspot/jtreg/serviceability/jvmti/HeapMonitor/MyPackage/HeapMonitor.java >> line 169: >> >>> 167: // Trigger GC then loop around an allocation loop and wait until >>> Object Sampling >>> 168: // is enabled for every later allocat

Re: RFR: 8264411: serviceability/jvmti/HeapMonitor tests intermittently fail due to large TLAB size [v3]

2021-04-02 Thread Hui Shi
On Sat, 3 Apr 2021 04:17:14 GMT, Chris Plummer wrote: >> Hui Shi has updated the pull request incrementally with one additional >> commit since the last revision: >> >> clarify comments > > test/hotspot/jtreg/serviceability/jvmti/HeapMonitor/MyPackage/HeapMonitor.java > line 175: > >> 173:

Re: RFR: 8264411: serviceability/jvmti/HeapMonitor tests intermittently fail due to large TLAB size [v4]

2021-04-02 Thread Hui Shi
> …ue to large TLAB size > > serviceability/jvmti/HeapMonitor tests intermittently fail when using > PS/Serial GC, original test has implicit assumptions on TLAB size and depends > on allocate fix amount of objects to consume TLAB and trigger object > sampling. These tests will fail if TLAB is

Re: RFR: 8264411: serviceability/jvmti/HeapMonitor tests intermittently fail due to large TLAB size [v2]

2021-04-02 Thread Hui Shi
On Fri, 2 Apr 2021 20:08:50 GMT, Chris Plummer wrote: >> Hui Shi has updated the pull request incrementally with one additional >> commit since the last revision: >> >> update copyright year > > test/hotspot/jtreg/serviceability/jvmti/HeapMonitor/MyPackage/HeapMonitor.java > line 176: > >>

Re: RFR: 8264411: serviceability/jvmti/HeapMonitor tests intermittently fail due to large TLAB size [v3]

2021-04-02 Thread Hui Shi
On Sat, 3 Apr 2021 04:18:07 GMT, Chris Plummer wrote: >> Hui Shi has updated the pull request incrementally with one additional >> commit since the last revision: >> >> clarify comments > > test/hotspot/jtreg/serviceability/jvmti/HeapMonitor/MyPackage/HeapMonitor.java > line 169: > >> 167:

Re: RFR: 8264411: serviceability/jvmti/HeapMonitor tests intermittently fail due to large TLAB size [v3]

2021-04-02 Thread Chris Plummer
On Sat, 3 Apr 2021 04:09:53 GMT, Hui Shi wrote: >> …ue to large TLAB size >> >> serviceability/jvmti/HeapMonitor tests intermittently fail when using >> PS/Serial GC, original test has implicit assumptions on TLAB size and >> depends on allocate fix amount of objects to consume TLAB and trigge

Re: RFR: 8264411: serviceability/jvmti/HeapMonitor tests intermittently fail due to large TLAB size [v3]

2021-04-02 Thread Hui Shi
> …ue to large TLAB size > > serviceability/jvmti/HeapMonitor tests intermittently fail when using > PS/Serial GC, original test has implicit assumptions on TLAB size and depends > on allocate fix amount of objects to consume TLAB and trigger object > sampling. These tests will fail if TLAB is

Re: RFR: 8263636: Add --disableregistry option to jhsdb debugd

2021-04-02 Thread Chris Plummer
On Sun, 28 Mar 2021 07:53:31 GMT, Yasumasa Suenaga wrote: > `jhsdb debugd` will start RMI registry by default, but we want to prevent it > due to port confliction in some cases. We can control it with > `sun.jvm.hotspot.rmi.startRegistry` system property. However we have no way > to set it exc

Re: RFR: 8264639: SA: Worker thread for ptrace on Linux should be more robustness

2021-04-02 Thread Chris Plummer
On Fri, 2 Apr 2021 08:27:05 GMT, Yasumasa Suenaga wrote: > LinuxDebuggerLocal has worker thread (LinuxDebuggerLocalWorkerThread) to call > ptrace(2) because it have to call from same thread. > > LinuxDebuggerLocalWorkerThread does not have queue, so it depends on > synchronized statement as fo

Re: RFR: 8264411: serviceability/jvmti/HeapMonitor tests intermittently fail due to large TLAB size [v2]

2021-04-02 Thread Chris Plummer
On Tue, 30 Mar 2021 23:51:41 GMT, Hui Shi wrote: >> …ue to large TLAB size >> >> serviceability/jvmti/HeapMonitor tests intermittently fail when using >> PS/Serial GC, original test has implicit assumptions on TLAB size and >> depends on allocate fix amount of objects to consume TLAB and trigg

Re: RFR: 8262386: resourcehogs/serviceability/sa/TestHeapDumpForLargeArray.java timed out

2021-04-02 Thread Chris Plummer
On Fri, 2 Apr 2021 09:22:26 GMT, Lin Zang wrote: >>> > I guess I don't understand why you would want write-through for small >>> > arrays but not large objects. >>> >>> I think it is because that the current implementation does not have code >>> which could calculate the object size before sca

Re: RFR: 8259070: Add jcmd option to dump CDS [v9]

2021-04-02 Thread Yumin Qi
> Hi, Please review > > Added jcmd option for dumping CDS archive during application runtime. > Before this change, user has to dump shared archive in two steps: first run > application with > `java -XX:DumpLoadedClassList= ` > to collect shareable class names and saved in file `` ,

Re: RFR: 8264311: Heap object statistics

2021-04-02 Thread Roman Kennke
On Fri, 2 Apr 2021 17:46:35 GMT, Serguei Spitsyn wrote: > Hi Roman, > Do you have any test case verifying this? > Thanks, > Serguei Hi Serguei, no, not yet, but I will add some. Thanks for the suggestion! - PR: https://git.openjdk.java.net/jdk/pull/3271

Re: RFR: 8264124: Update MXBean specification and implementation to extend mapping of CompositeType to records [v7]

2021-04-02 Thread Daniel Fuchs
> This RFE proposes to extend the MXBean framework to define a mapping to > records. > > The MXBean framework already defines a mapping of `CompositeType` to plain > java objects. Records are a natural representation of CompositeTypes. A > record can be easily reconstructed from a `CompositeDat

Re: RFR: 8264311: Heap object statistics

2021-04-02 Thread Serguei Spitsyn
On Tue, 30 Mar 2021 21:46:12 GMT, Mikhailo Seledtsov wrote: >> I'm not involved in the Lilliput project, but as long as the stakeholders >> are ok with that approach, it's probably the way to go, especially since you >> seem to think the feature might still evolve some. > > If you are planning

Re: RFR: 8264411: serviceability/jvmti/HeapMonitor tests intermittently fail due to large TLAB size [v2]

2021-04-02 Thread Serguei Spitsyn
On Tue, 30 Mar 2021 23:51:41 GMT, Hui Shi wrote: >> …ue to large TLAB size >> >> serviceability/jvmti/HeapMonitor tests intermittently fail when using >> PS/Serial GC, original test has implicit assumptions on TLAB size and >> depends on allocate fix amount of objects to consume TLAB and trigg

Re: RFR: 8264148: Update spec for exceptions retrofitted for exception chaining

2021-04-02 Thread Serguei Spitsyn
On Wed, 24 Mar 2021 23:17:46 GMT, Joe Darcy wrote: > 8264148: Update spec for exceptions retrofitted for exception chaining Joe, The Serviceability part looks good. Thanks, Serguei - PR: https://git.openjdk.java.net/jdk/pull/3182

Integrated: 8262280: Incorrect exception handling for VMThread in class redefinition

2021-04-02 Thread Coleen Phillimore
On Thu, 1 Apr 2021 16:58:00 GMT, Coleen Phillimore wrote: > This is a trivial change to remove the last TRAPS from redefine_single_class > which is called by the VM thread during a safepoint. > Tested with serviceability/jvmti/RedefineClasses, vmTestbase/nsk/jvmti,jdi > and jdk/java/lang/instru

Re: RFR: 8262280: Incorrect exception handling for VMThread in class redefinition

2021-04-02 Thread Coleen Phillimore
On Fri, 2 Apr 2021 12:58:18 GMT, Harold Seigel wrote: >> This is a trivial change to remove the last TRAPS from redefine_single_class >> which is called by the VM thread during a safepoint. >> Tested with serviceability/jvmti/RedefineClasses, vmTestbase/nsk/jvmti,jdi >> and jdk/java/lang/instru

Re: RFR: 8262280: Incorrect exception handling for VMThread in class redefinition

2021-04-02 Thread Harold Seigel
On Thu, 1 Apr 2021 16:58:00 GMT, Coleen Phillimore wrote: > This is a trivial change to remove the last TRAPS from redefine_single_class > which is called by the VM thread during a safepoint. > Tested with serviceability/jvmti/RedefineClasses, vmTestbase/nsk/jvmti,jdi > and jdk/java/lang/instru

RFR: 8264639: SA: Worker thread for ptrace on Linux should be more robustness

2021-04-02 Thread Yasumasa Suenaga
LinuxDebuggerLocal has worker thread (LinuxDebuggerLocalWorkerThread) to call ptrace(2) because it have to call from same thread. LinuxDebuggerLocalWorkerThread does not have queue, so it depends on synchronized statement as following: https://github.com/openjdk/jdk/blob/66d9961cbd83dbfca20b0af

Re: RFR: 8262386: resourcehogs/serviceability/sa/TestHeapDumpForLargeArray.java timed out

2021-04-02 Thread Lin Zang
On Tue, 23 Mar 2021 23:25:10 GMT, Chris Plummer wrote: >> Dear Chris, >> >>> I guess I don't understand why you would want write-through for small >>> arrays but not large objects. >> >> I think it is because that the current implementation does not have code >> which could calculate the obje