Re: RFR: 8257831: Suspend with handshakes [v10]

2021-04-18 Thread David Holmes
On Fri, 16 Apr 2021 06:44:06 GMT, Robbin Ehn wrote: >> A suspend request is done by handshaking thread target thread(s). When >> executing the handshake operation we know the target mutator thread is in a >> dormant state (as in safepoint safe state). We have a guarantee that it will >> check

Re: RFR: 8200559: Java agents doing instrumentation need a means to define auxilary classes

2021-04-18 Thread Rafael Winterhalter
As for the need to inject classes into 'new' packages, in Mockito we solve this easily by 'claiming' a package by defining a static dummy class within it which we then use as a hook for injection using a lookup. This works well for us, and I do of course not know the explicit requirements of others

Re: RFR: 8200559: Java agents doing instrumentation need a means to define auxilary classes

2021-04-18 Thread Alan Bateman
On 16/04/2021 21:09, Rafael Winterhalter wrote: I have never seen a need for a non-agent to define a class in a non-existing package. Injection is typically required if you want to work with package-private types or methods which is really only relevant for the Spring framework, but even there I

Re: RFR: 8265136: ZGC: Expose GarbageCollectorMXBeans for both pauses and cycles

2021-04-18 Thread Albert Mingkun Yang
On Wed, 14 Apr 2021 07:13:50 GMT, Per Liden wrote: > JDK-8240679 introduced a change where the information exposed via the > GarbageCollectorMXBean went from being related to the GC pauses to instead be > related to the GC cycles. This helped provide more accurate heap usage > information. How