On Tue, 4 May 2021 23:50:16 GMT, David Holmes wrote:
>> Koichi Sakata has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> Change variable name to better one
>
> src/hotspot/share/logging/logConfiguration.cpp line 430:
>
>> 428: Configurat
On Thu, 6 May 2021 06:24:26 GMT, Koichi Sakata wrote:
>> When reconfiguring log output options of an existing log setting with jcmd
>> VM.log and the file name, a warning message is shown. However, when
>> reconfiguring them with jcmd VM.log and the output index, the message is not
>> shown.
>
> When reconfiguring log output options of an existing log setting with jcmd
> VM.log and the file name, a warning message is shown. However, when
> reconfiguring them with jcmd VM.log and the output index, the message is not
> shown.
>
>
> $ java -Xlog::sample.log:: Sample
> $ jcmd 4976 VM.lo
On Wed, 5 May 2021 08:58:15 GMT, Serguei Spitsyn wrote:
> @buddyliao
> The test update looks good to me.
> Thanks,
> Serguei
@sspitsyn Thanks, I force update the title to match between PR and JBS.
Would you help me to push it?
Thanks,
Buddy
-
PR: https://git.openjdk.java.net/jdk/p
On Wed, 5 May 2021 08:16:38 GMT, Serguei Spitsyn wrote:
>> Lin Zang has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> fix indentation issue
>
> Hi Lin,
> It looks good to me. Sorry for being late on this review.
> Thanks,
> serguei
Dear @
On Wed, 5 May 2021 21:16:07 GMT, Argha C
wrote:
> Thanks for linking that. It sounds reasonable to me to prefer `quota` in that
> case.
Yes, flag `PreferContainerQuotaForCPUCount` is [true by
default](https://github.com/openjdk/jdk/blob/739769c8/src/hotspot/os/linux/globals_linux.hpp#L62).
T
> The testHistoParallel* method are not included in the BasicJMapTest's main()
> method. They should be included.
BuddyLiao has refreshed the contents of this pull request, and previous commits
have been removed. The incremental views will show differences compared to the
previous content of th
On Tue, 4 May 2021 12:31:46 GMT, Coleen Phillimore wrote:
> Marking running_emcp for Method* is unnecessary. We can set/clear
> breakpoints in all old emcp methods because they're not deallocated until
> none are running. See longer explanation in the CR.
>
> Tested with tier1-6, tiers 7,8 a
On Wed, 5 May 2021 22:12:20 GMT, Alex Menkov wrote:
>> test/hotspot/jtreg/vmTestbase/nsk/share/jvmti/hotswap/HotSwap.cpp line 110:
>>
>>> 108: }
>>> 109: // use while instead of if to exit the block on error
>>> 110: while (classCount < max_classes) {
>>
>> Could you ple
On Wed, 5 May 2021 21:01:11 GMT, Leonid Mesnik wrote:
>> Class loading can happen on different threads, but HotSwap agent is not
>> ready to this - classCount variable is used without any synchronization.
>> The fix adds synchronization for ClassFileLoadHook.
>
> test/hotspot/jtreg/vmTestbase/ns
On Wed, 5 May 2021 20:59:01 GMT, Leonid Mesnik wrote:
>> Class loading can happen on different threads, but HotSwap agent is not
>> ready to this - classCount variable is used without any synchronization.
>> The fix adds synchronization for ClassFileLoadHook.
>
> test/hotspot/jtreg/vmTestbase/ns
On Wed, 5 May 2021 21:02:44 GMT, Leonid Mesnik wrote:
> Also, generic comment. There are other counters which might require
> synchronization, like CompiledMethodLoadEventsCount. Doesn't it makes sense
> to fix them also or file a new bug?
The problem with classCount is it's used as an index i
On Wed, 5 May 2021 05:57:55 GMT, Hao Tang
wrote:
>> src/jdk.management/unix/classes/com/sun/management/internal/OperatingSystemImpl.java
>> line 142:
>>
>>> 140: long usageNanos = containerMetrics.getCpuUsage();
>>> 141: if (numPeriods > 0 && usageNanos > 0) {
>
On Wed, 5 May 2021 20:26:13 GMT, Alex Menkov wrote:
> Class loading can happen on different threads, but HotSwap agent is not ready
> to this - classCount variable is used without any synchronization.
> The fix adds synchronization for ClassFileLoadHook.
Also, generic comment. There are other c
Class loading can happen on different threads, but HotSwap agent is not ready
to this - classCount variable is used without any synchronization.
The fix adds synchronization for ClassFileLoadHook.
-
Commit messages:
- Added synchronization for ClassFileLoadHook callback
Changes: ht
On Wed, 5 May 2021 18:39:14 GMT, Pavel Rappo wrote:
>> This fixes two javadoc tag references and several typos. References are
>> fixed by removing whitespace before the opening `(`. That whitespace caused
>> the opening `(` and the rest of the reference to be parsed as a link label.
>>
>> Sin
On Wed, 5 May 2021 18:39:14 GMT, Pavel Rappo wrote:
>> This fixes two javadoc tag references and several typos. References are
>> fixed by removing whitespace before the opening `(`. That whitespace caused
>> the opening `(` and the rest of the reference to be parsed as a link label.
>>
>> Sin
> This fixes two javadoc tag references and several typos. References are fixed
> by removing whitespace before the opening `(`. That whitespace caused the
> opening `(` and the rest of the reference to be parsed as a link label.
>
> Since we are here, I think this class could also benefit from
On Wed, 5 May 2021 15:59:43 GMT, Pavel Rappo wrote:
> This fixes two javadoc tag references and several typos. References are fixed
> by removing whitespace before the opening `(`. That whitespace caused the
> opening `(` and the rest of the reference to be parsed as a link label.
>
> Since we
This fixes two javadoc tag references and several typos. References are fixed
by removing whitespace before the opening `(`. That whitespace caused the
opening `(` and the rest of the reference to be parsed as a link label.
Since we are here, I think this class could also benefit from using mode
On Tue, 4 May 2021 12:31:46 GMT, Coleen Phillimore wrote:
> Marking running_emcp for Method* is unnecessary. We can set/clear
> breakpoints in all old emcp methods because they're not deallocated until
> none are running. See longer explanation in the CR.
>
> Tested with tier1-6, tiers 7,8 a
On Tue, 4 May 2021 12:31:46 GMT, Coleen Phillimore wrote:
> Marking running_emcp for Method* is unnecessary. We can set/clear
> breakpoints in all old emcp methods because they're not deallocated until
> none are running. See longer explanation in the CR.
>
> Tested with tier1-6, tiers 7,8 a
On Wed, 5 May 2021 01:07:13 GMT, Serguei Spitsyn wrote:
>> Marking running_emcp for Method* is unnecessary. We can set/clear
>> breakpoints in all old emcp methods because they're not deallocated until
>> none are running. See longer explanation in the CR.
>>
>> Tested with tier1-6, tiers 7,
Please consider this change which removes the manual transitions to blocked.
This adds a preprocess template/functor which is executed in the destructor of
'ThreadBlockInVM' if we are going to do any processing.
This gives us a way to backout of the object/raw monitor before suspend or
other proc
On Sat, 20 Feb 2021 03:27:22 GMT, Chris Plummer wrote:
>> Hamlin Li has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> improve jcmd GC.class_histogram to support parallel
>
> For jmap -histo we have:
>
> parallel= parallel threads n
On Tue, 13 Apr 2021 04:23:52 GMT, Koichi Sakata wrote:
> When reconfiguring log output options of an existing log setting with jcmd
> VM.log and the file name, a warning message is shown. However, when
> reconfiguring them with jcmd VM.log and the output index, the message is not
> shown.
>
>
On Fri, 30 Apr 2021 08:06:38 GMT, BuddyLiao
wrote:
> The testHistoParallel* method are not included in the BasicJMapTest's main()
> method. They should be included.
@buddyliao
The test update looks good to me.
Thanks,
Serguei
-
Marked as reviewed by sspitsyn (Reviewer).
PR: htt
On Thu, 29 Apr 2021 08:11:12 GMT, Albert Mingkun Yang wrote:
>> It has some cascading effect; two performance variables, `fastWaste` and
>> `maxFastWaste`, can be removed also.
>
> Albert Mingkun Yang has updated the pull request incrementally with one
> additional commit since the last revisio
On Sun, 25 Apr 2021 03:15:07 GMT, Yasumasa Suenaga wrote:
> `jhsdb debugd` supports server name prefix with
> `sun.jvm.hotspot.rmi.serverNamePrefix` system property. It will be used as
> remote name for SA remote object. It is "SARemoteDebugger" by default.
>
> As a result, remote name will be
On Thu, 22 Apr 2021 05:53:35 GMT, Lin Zang wrote:
>> This PR revise the help message of the `parallel=[N]` option of command
>> `jmap -histo`. It mainly comes from the discussion at
>> https://github.com/openjdk/jdk/pull/2379#issuecomment-782609582 and
>> https://github.com/openjdk/jdk/pull
On Wed, 28 Apr 2021 21:48:15 GMT, Alex Menkov wrote:
>> Class loading may cause loading of some other system/internal classes (for
>> example loading of java.util.concurrent classes when an other thread loads
>> some classes concurrently).
>> The fix updates ClassPrepare test so it skip events
On Tue, 13 Apr 2021 04:23:52 GMT, Koichi Sakata wrote:
> When reconfiguring log output options of an existing log setting with jcmd
> VM.log and the file name, a warning message is shown. However, when
> reconfiguring them with jcmd VM.log and the output index, the message is not
> shown.
>
>
On Wed, 21 Apr 2021 20:51:49 GMT, Alex Menkov wrote:
>> The test actually failed starting from jdk13, but the error is masked by
>> JDK-8264667 (and shell part of the test didn't verify result of the java
>> execution)
>> The fix:
>> - updates JvmtiClassFileReconstituter to add attributes in th
On Fri, 23 Apr 2021 15:03:42 GMT, Fairoz Matte wrote:
> findComponentType() logic is wrong. In findComponentType() method, We always
> get vm.classesByName() retruns empty list
> list = vm.classesByName(parser.typeName());
> We have "parser.typeName()" retruns " double[][]"
> vm.classesByName(""
34 matches
Mail list logo
