On Wed, 19 May 2021 11:55:12 GMT, Lin Zang wrote:
>> 8252842: Extend jmap to support parallel heap dump
>
> Lin Zang has updated the pull request with a new target base due to a merge
> or a rebase. The pull request now contains 34 commits:
>
> - fix build issue after rebase and fix one issue
On Wed, 19 May 2021 07:26:14 GMT, Robbin Ehn wrote:
>> Please consider this change which removes the manual transitions to blocked.
>> This adds a preprocess template/functor which is executed in the destructor
>> of 'ThreadBlockInVM' if we are going to do any processing.
>> This gives us a way
On Thu, 20 May 2021 04:05:23 GMT, Phil Race wrote:
>> By converting JDK-8267432 to a bug, there is an extra benefit that we can
>> fix it after RDP. So I'll convert it now.
>
> That is unfortunate, but nonetheless I think required to be done.
> We have acknowledeged this can't reasonably be call
On Thu, 20 May 2021 02:09:57 GMT, Weijun Wang wrote:
>> I can make it a bug.
>>
>> I don't want to do it here is because it involves indefinite amount of
>> manual work and we will see everyone having their preferences. The more time
>> we spend on this PR the more likely there will be merge c
On Sat, 15 May 2021 02:00:15 GMT, Yasumasa Suenaga wrote:
>> `jhsdb debugd` supports server name prefix with
>> `sun.jvm.hotspot.rmi.serverNamePrefix` system property. It will be used as
>> remote name for SA RMI object. It is "SARemoteDebugger" by default.
>>
>> As a result, remote name will
> `jhsdb debugd` supports server name prefix with
> `sun.jvm.hotspot.rmi.serverNamePrefix` system property. It will be used as
> remote name for SA RMI object. It is "SARemoteDebugger" by default.
>
> As a result, remote name will be constructed as following:
>
>
> //host[:port]/['_']
>
>
>
On Thu, 20 May 2021 02:06:46 GMT, Weijun Wang wrote:
>> Well .. as an enhancement (P3 or otherwise) I can see it being dropped and
>> definitely if it misses the fork,
>> and I don't get why you can't do it here. And if it isn't done the JEP isn't
>> really ready.
>> I already pasted the patch
On Wed, 19 May 2021 23:50:04 GMT, Phil Race wrote:
>> I just made it P3 (P4 was the default value), and I will target it to 17
>> once JEP 411 is targeted 17. But I think it's probably not a good idea to
>> include it inside *this* PR. There are some middle ground where it's
>> debatable if a
On Sat, 15 May 2021 02:00:15 GMT, Yasumasa Suenaga wrote:
>> `jhsdb debugd` supports server name prefix with
>> `sun.jvm.hotspot.rmi.serverNamePrefix` system property. It will be used as
>> remote name for SA RMI object. It is "SARemoteDebugger" by default.
>>
>> As a result, remote name will
On Sat, 15 May 2021 02:00:15 GMT, Yasumasa Suenaga wrote:
>> `jhsdb debugd` supports server name prefix with
>> `sun.jvm.hotspot.rmi.serverNamePrefix` system property. It will be used as
>> remote name for SA RMI object. It is "SARemoteDebugger" by default.
>>
>> As a result, remote name will
Hi Sergey,
Fix looks fine. I'm a little surprised we have any SE Embedded test
issues arising - is this a new test?
Cheers,
David
On 20/05/2021 6:28 am, Sergey Nazarkin wrote:
Correct serviceability list address
On May 19, 2021, at 22:19, Sergey Nazarkin wrote:
Hi!
Please review small
On Wed, 19 May 2021 22:14:20 GMT, Weijun Wang wrote:
>> I don't think it is a separate P4 enhancement (?) that someone will (maybe)
>> do next release.
>> I think it should all be taken care of as part of this proposed change.
>
> I just made it P3 (P4 was the default value), and I will target i
On Wed, 19 May 2021 22:04:57 GMT, Phil Race wrote:
>> Correct, there are ways to modify the code to make it more
>> annotation-friendly. We thought about whether it's good to do it before
>> adding the annotations or after it. Our decision now is to do it after
>> because it will be more easy
On Wed, 19 May 2021 21:53:35 GMT, Weijun Wang wrote:
>> That's a sad limitation of the annotation stuff then, but I don't think that
>> it is insurmountable.
>> You can define a static private method to contain this and call it from the
>> static initializer block.
>> Much better than applying
On Wed, 19 May 2021 19:31:24 GMT, Phil Race wrote:
>> This happens when a deprecated method is called inside a static block. The
>> annotation can only be added to a declaration and here it must be the whole
>> class. The call in this file is
>>
>> s = java.security.AccessController.do
> Please review this PR that intents to make sealed classes a final feature in
> Java. This PR contains compiler and VM changes. In line with similar PRs,
> which has made preview features final, this one is mostly removing preview
> related comments from APIs plus options in test cases. Please
On Tue, 18 May 2021 21:44:43 GMT, Weijun Wang wrote:
>> Please review the test changes for [JEP
>> 411](https://openjdk.java.net/jeps/411).
>>
>> With JEP 411 and the default value of `-Djava.security.manager` becoming
>> `disallow`, tests calling `System.setSecurityManager()` need
>> `-Djav
Correct serviceability list address
> On May 19, 2021, at 22:19, Sergey Nazarkin wrote:
>
> Hi!
>
> Please review small patch for the test that fails [1] on jdk8 built with
> JAVASE_EMBEDDED option.
>
> Embedded VM build disables [2] jvmstat instrumentation that prevent launched
> instance
On Wed, 19 May 2021 18:38:39 GMT, Weijun Wang wrote:
>> src/java.desktop/share/classes/java/awt/Component.java line 217:
>>
>>> 215: * @author Sami Shaio
>>> 216: */
>>> 217: @SuppressWarnings("removal")
>>
>> Why is this placed on the *entire class* ??
>> This class is 10535 lines long
On Wed, 19 May 2021 18:44:06 GMT, Weijun Wang wrote:
>> Similar as the one above, it's because of
>>
>> static {
>> // Don't lazy-read because every app uses invalidate()
>> isJavaAwtSmartInvalidate = AccessController.doPrivileged(
>> new GetBooleanAction("jav
On Wed, 19 May 2021 18:39:10 GMT, Weijun Wang wrote:
>> src/java.desktop/share/classes/java/awt/Container.java line 97:
>>
>>> 95: * @since 1.0
>>> 96: */
>>> 97: @SuppressWarnings("removal")
>>
>> Same issue as with Component. a > 5,000 line file that uses AccessController
>> in just 4
On Wed, 19 May 2021 18:26:25 GMT, Phil Race wrote:
>> Weijun Wang has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> fixing awt/datatransfer/DataFlavor/DataFlavorRemoteTest.java
>
> src/java.desktop/share/classes/java/awt/Component.java lin
On Wed, 19 May 2021 13:47:53 GMT, Weijun Wang wrote:
>> Please review this implementation of [JEP
>> 411](https://openjdk.java.net/jeps/411).
>>
>> The code change is divided into 3 commits. Please review them one by one.
>>
>> 1.
>> https://github.com/openjdk/jdk/commit/576161d15423f58281e38
On Wed, 19 May 2021 13:47:53 GMT, Weijun Wang wrote:
>> Please review this implementation of [JEP
>> 411](https://openjdk.java.net/jeps/411).
>>
>> The code change is divided into 3 commits. Please review them one by one.
>>
>> 1.
>> https://github.com/openjdk/jdk/commit/576161d15423f58281e38
On Wed, 19 May 2021 13:47:53 GMT, Weijun Wang wrote:
>> Please review this implementation of [JEP
>> 411](https://openjdk.java.net/jeps/411).
>>
>> The code change is divided into 3 commits. Please review them one by one.
>>
>> 1.
>> https://github.com/openjdk/jdk/commit/576161d15423f58281e38
On Thu, 29 Apr 2021 08:11:12 GMT, Albert Mingkun Yang wrote:
>> It has some cascading effect; two performance variables, `fastWaste` and
>> `maxFastWaste`, can be removed also.
>
> Albert Mingkun Yang has updated the pull request incrementally with one
> additional commit since the last revisio
On Wed, 28 Apr 2021 09:23:31 GMT, Albert Mingkun Yang wrote:
> It has some cascading effect; two performance variables, `fastWaste` and
> `maxFastWaste`, can be removed also.
This pull request has now been integrated.
Changeset: 99fcc410
Author:Albert Mingkun Yang
URL:
https://git.
On Wed, 19 May 2021 07:26:14 GMT, Robbin Ehn wrote:
>> Please consider this change which removes the manual transitions to blocked.
>> This adds a preprocess template/functor which is executed in the destructor
>> of 'ThreadBlockInVM' if we are going to do any processing.
>> This gives us a way
> Please review this implementation of [JEP
> 411](https://openjdk.java.net/jeps/411).
>
> The code change is divided into 3 commits. Please review them one by one.
>
> 1.
> https://github.com/openjdk/jdk/commit/576161d15423f58281e384174d28c9f9be7941a1
> The essential change for this JEP, incl
On Tue, 18 May 2021 21:21:45 GMT, Weijun Wang wrote:
>> Please review this implementation of [JEP
>> 411](https://openjdk.java.net/jeps/411).
>>
>> The code change is divided into 3 commits. Please review them one by one.
>>
>> 1.
>> https://github.com/openjdk/jdk/commit/576161d15423f58281e38
On Mon, 10 May 2021 23:29:36 GMT, Chris Plummer wrote:
>> Lin Zang has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> code refine and typo fix
>
> I think you still need to undo the JMap.java changes since they are now being
> handled by #
> 8252842: Extend jmap to support parallel heap dump
Lin Zang has updated the pull request with a new target base due to a merge or
a rebase. The pull request now contains 34 commits:
- fix build issue after rebase and fix one issue
- Merge branch 'master'
- Merge branch 'master' into pd
- u
On Fri, 14 May 2021 18:02:12 GMT, Richard Reingruber wrote:
> Hi Robbin,
>
> there seem to be issues in the jvmtiRawMonitor part of the change. Besides
> that it looks good.
>
> Cheers, Richard.
Thanks and thanks for finding the two issues, updated!
-
PR: https://git.openjdk.jav
On Thu, 13 May 2021 06:04:19 GMT, David Holmes wrote:
> Hi Robbin,
>
> Sorry for the delay in getting through this.
>
> Overall approach looks good. I have a few queries below and some requested
> naming changes to make things clearer.
>
> Thanks,
> David
Thanks for looking at, update after
On Wed, 12 May 2021 08:04:47 GMT, Robbin Ehn wrote:
>> Please consider this change which removes the manual transitions to blocked.
>> This adds a preprocess template/functor which is executed in the destructor
>> of 'ThreadBlockInVM' if we are going to do any processing.
>> This gives us a way
> Please consider this change which removes the manual transitions to blocked.
> This adds a preprocess template/functor which is executed in the destructor
> of 'ThreadBlockInVM' if we are going to do any processing.
> This gives us a way to backout of the object/raw monitor before suspend or
>
36 matches
Mail list logo
