Re: RFR: 8265148: StackWatermarkSet being updated during AsyncGetCallTrace

2021-05-31 Thread Erik Österlund
On Tue, 1 Jun 2021 04:23:43 GMT, Leonid Mesnik wrote: > Thank you for your prompt response. I meant that it makes sense to update > comments for RegisterMap to mention this. Currently, the doc says how to use > it and how to disable update: > > "Updating of the RegisterMap can be turned off by

Re: RFR: 8265148: StackWatermarkSet being updated during AsyncGetCallTrace

2021-05-31 Thread Leonid Mesnik
On Tue, 1 Jun 2021 04:09:13 GMT, Erik Österlund wrote: >> Let me check with Erik if it makes sense to put more generic comments about >> the usage of stackwatermark frame processing in RegisterMap, frames etc. >> They can't be updated in an arbitrary thread state. It makes sense describe >> t

Re: RFR: 8265148: StackWatermarkSet being updated during AsyncGetCallTrace

2021-05-31 Thread Erik Österlund
On Tue, 1 Jun 2021 03:00:23 GMT, Leonid Mesnik wrote: > Let me check with Erik if it makes sense to put more generic comments about > the usage of stackwatermark frame processing in RegisterMap, frames etc. > They can't be updated in an arbitrary thread state. It makes sense describe > this i

Re: RFR: 8265148: StackWatermarkSet being updated during AsyncGetCallTrace

2021-05-31 Thread Leonid Mesnik
On Thu, 27 May 2021 23:07:02 GMT, David Holmes wrote: >> 8265148: StackWatermarkSet being updated during AsyncGetCallTrace > > src/hotspot/share/prims/forte.cpp line 326: > >> 324: int loop_count; >> 325: int loop_max = MaxJavaStackTraceDepth * 2; >> 326: RegisterMap map(thread, fals

Re: RFR: 8265148: StackWatermarkSet being updated during AsyncGetCallTrace

2021-05-31 Thread Leonid Mesnik
On Thu, 27 May 2021 04:01:17 GMT, Leonid Mesnik wrote: > 8265148: StackWatermarkSet being updated during AsyncGetCallTrace I verified that async-profiles works with ZGC and data look reasonable. - PR: https://git.openjdk.java.net/jdk/pull/4217

Re: RFR: 8266459: Implement JEP 411: Deprecate the Security Manager for Removal [v6]

2021-05-31 Thread Lance Andersen
On Mon, 31 May 2021 15:02:57 GMT, Weijun Wang wrote: >> Please review this implementation of [JEP >> 411](https://openjdk.java.net/jeps/411). >> >> The code change is divided into 3 commits. Please review them one by one. >> >> 1. >> https://github.com/openjdk/jdk/commit/576161d15423f58281e38

Re: RFR: 8266459: Implement JEP 411: Deprecate the Security Manager for Removal [v6]

2021-05-31 Thread Weijun Wang
On Mon, 31 May 2021 15:02:57 GMT, Weijun Wang wrote: >> Please review this implementation of [JEP >> 411](https://openjdk.java.net/jeps/411). >> >> The code change is divided into 3 commits. Please review them one by one. >> >> 1. >> https://github.com/openjdk/jdk/commit/576161d15423f58281e38

Re: RFR: 8266459: Implement JEP 411: Deprecate the Security Manager for Removal [v6]

2021-05-31 Thread Weijun Wang
> Please review this implementation of [JEP > 411](https://openjdk.java.net/jeps/411). > > The code change is divided into 3 commits. Please review them one by one. > > 1. > https://github.com/openjdk/jdk/commit/576161d15423f58281e384174d28c9f9be7941a1 > The essential change for this JEP, incl

Integrated: 8267464: Circular-dependency resilient inline headers

2021-05-31 Thread Stefan Karlsson
On Thu, 20 May 2021 11:55:05 GMT, Stefan Karlsson wrote: > I'd like to propose a small adjustment to how we write .inline.hpp files, in > the hope to reduce include problems because of circular dependencies between > inline headers. > > This is a small, contrived example to show the problem: >

Re: RFR: 8267464: Circular-dependency resilient inline headers [v8]

2021-05-31 Thread Stefan Karlsson
On Mon, 31 May 2021 06:44:45 GMT, Stefan Karlsson wrote: >> I'd like to propose a small adjustment to how we write .inline.hpp files, in >> the hope to reduce include problems because of circular dependencies between >> inline headers. >> >> This is a small, contrived example to show the probl

Re: RFR: 8267666: Add option to jcmd GC.heap_dump to use existing file [v2]

2021-05-31 Thread Anton Kozlov
On Fri, 28 May 2021 10:49:32 GMT, Anton Kozlov wrote: >> Please review a small change that adds an option to GC.heap_dump to use an >> existing file. >> >> The option is necessary if the target file is a predefined file-like object, >> like a named pipe. This opens up a lot of possibilities t

Re: RFR: 8267842: SIGSEGV in get_current_contended_monitor [v6]

2021-05-31 Thread Martin Doerr
On Fri, 28 May 2021 13:42:30 GMT, Martin Doerr wrote: >> We need a fix for crashes in get_current_contended_monitor due to concurrent >> modification of memory locations which are not declared volatile. See bug >> for details. > > Martin Doerr has updated the pull request incrementally with one

Integrated: 8267842: SIGSEGV in get_current_contended_monitor

2021-05-31 Thread Martin Doerr
On Thu, 27 May 2021 09:56:22 GMT, Martin Doerr wrote: > We need a fix for crashes in get_current_contended_monitor due to concurrent > modification of memory locations which are not declared volatile. See bug for > details. This pull request has now been integrated. Changeset: 1e29005a Author

Re: RFR: 8264800: cleanup Threads_lock comments in JVM/TI function headers

2021-05-31 Thread David Holmes
On Fri, 28 May 2021 19:40:00 GMT, Daniel D. Daugherty wrote: > A trivial fix to cleanup Threads_lock comments in JVM/TI function headers. > > Also remove errant text added by the jframeID XSL template code: > > > // java_thread - unchecked > // depth - pre-checked as non-negative > > > The