Re: [jdk17] RFR: 8268433: serviceability/dcmd/framework/VMVersionTest.java fails with Unable to send object throw not established PipeIO Listener Thread connection

2021-06-11 Thread Serguei Spitsyn
On Fri, 11 Jun 2021 19:40:09 GMT, Alex Menkov wrote: > The fix adds check that IOPipe is connected before sending "quit" command Alex, It looks okay in general but I wonder if this is racy. Thanks, Serguei - Marked as reviewed by sspitsyn (Reviewer). PR: https://git.openjdk.java.n

Re: RFR: 8268286: ProblemList serviceability/sa/TestJmapCore.java on linux-aarch64 with ZGC

2021-06-11 Thread Chris Plummer
On Sat, 5 Jun 2021 15:12:50 GMT, Daniel D. Daugherty wrote: > A trivial fix to ProblemList serviceability/sa/TestJmapCore.java on > linux-aarch64 with ZGC. This is an SA bug, so it could be an issue with the aarch64 support in SA. - PR: https://git.openjdk.java.net/jdk/pull/4374

[jdk17] Integrated: 8268630: ProblemList serviceability/jvmti/CompiledMethodLoad/Zombie.java on linux-aarch64

2021-06-11 Thread Daniel D . Daugherty
On Fri, 11 Jun 2021 20:11:12 GMT, Daniel D. Daugherty wrote: > Target is JDK17: > A trivial fix to ProblemList > serviceability/jvmti/CompiledMethodLoad/Zombie.java on linux-aarch64. This pull request has now been integrated. Changeset: 6171ae45 Author:Daniel D. Daugherty URL: htt

Re: [jdk17] RFR: 8268630: ProblemList serviceability/jvmti/CompiledMethodLoad/Zombie.java on linux-aarch64

2021-06-11 Thread Daniel D . Daugherty
On Fri, 11 Jun 2021 20:16:33 GMT, Erik Joelsson wrote: >> Target is JDK17: >> A trivial fix to ProblemList >> serviceability/jvmti/CompiledMethodLoad/Zombie.java on linux-aarch64. > > Marked as reviewed by erikj (Reviewer). @erikj79 - Thanks for the fast review! - PR: https://git.

[jdk17] RFR: 8268630: ProblemList serviceability/jvmti/CompiledMethodLoad/Zombie.java on linux-aarch64

2021-06-11 Thread Daniel D . Daugherty
Target is JDK17: A trivial fix to ProblemList serviceability/jvmti/CompiledMethodLoad/Zombie.java on linux-aarch64. - Commit messages: - 8268630: ProblemList serviceability/jvmti/CompiledMethodLoad/Zombie.java on linux-aarch64 Changes: https://git.openjdk.java.net/jdk17/pull/33/fi

Re: [jdk17] RFR: 8268630: ProblemList serviceability/jvmti/CompiledMethodLoad/Zombie.java on linux-aarch64

2021-06-11 Thread Erik Joelsson
On Fri, 11 Jun 2021 20:11:12 GMT, Daniel D. Daugherty wrote: > Target is JDK17: > A trivial fix to ProblemList > serviceability/jvmti/CompiledMethodLoad/Zombie.java on linux-aarch64. Marked as reviewed by erikj (Reviewer). - PR: https://git.openjdk.java.net/jdk17/pull/33

[jdk17] RFR: 8268433: serviceability/dcmd/framework/VMVersionTest.java fails with Unable to send object throw not established PipeIO Listener Thread connection

2021-06-11 Thread Alex Menkov
The fix adds check that IOPipe is connected before sending "quit" command - Commit messages: - Added check that IOPipe is connected Changes: https://git.openjdk.java.net/jdk17/pull/32/files Webrev: https://webrevs.openjdk.java.net/?repo=jdk17&pr=32&range=00 Issue: https://bugs.op

Re: [jdk17] RFR: 8268564: mark hotspot serviceability/attach tests which ignore external VM flags

2021-06-11 Thread Serguei Spitsyn
On Thu, 10 Jun 2021 18:23:45 GMT, Igor Ignatyev wrote: > Hi all, > > could you please review this one-liner that adds `@requires vm.flagless` to 2 > `serviceability/attach` tests that ignore external VM flags? > > Thanks, > -- Igor Marked as reviewed by sspitsyn (Reviewer). - PR

Re: [jdk17] RFR: 8268563: mark hotspot serviceability/jvmti tests which ignore external VM flags

2021-06-11 Thread Serguei Spitsyn
On Thu, 10 Jun 2021 18:19:46 GMT, Igor Ignatyev wrote: > Hi all, > > could you please review this one-liner that adds `@requires vm.flagless` to 6 > `serviceability/jvmti` tests that ignore external VM flags? > > Thanks, > -- Igor Marked as reviewed by sspitsyn (Reviewer). - PR:

Re: [jdk17] RFR: 8268541: mark hotspot serviceability/sa tests which ignore external VM flags

2021-06-11 Thread Serguei Spitsyn
On Thu, 10 Jun 2021 18:08:45 GMT, Igor Ignatyev wrote: > Hi all, > > could you please review this one-liner that adds `@requires vm.flagless` to > `serviceability/sa/TestJhsdbJstackLineNumbers.java` as it ignores external VM > flags? > > Thanks, > -- Igor Marked as reviewed by sspitsyn (Revi

Re: [jdk17] RFR: 8268531: mark SDTProbesGNULinuxTest as ignoring external VM flags

2021-06-11 Thread Serguei Spitsyn
On Thu, 10 Jun 2021 16:46:12 GMT, Igor Ignatyev wrote: > (recreating openjdk/jdk#4453 against jdk17) > > Hi all, > > could you please review this patch that adds `@requires vm.flagless` to > `SDTProbesGNULinuxTest` test as it ignores all external VM flags? > > Thanks, > -- Igor Marked as rev

Re: RFR: 8268286: ProblemList serviceability/sa/TestJmapCore.java on linux-aarch64 with ZGC

2021-06-11 Thread Daniel D . Daugherty
On Sat, 5 Jun 2021 15:12:50 GMT, Daniel D. Daugherty wrote: > A trivial fix to ProblemList serviceability/sa/TestJmapCore.java on > linux-aarch64 with ZGC. It's only ProblemListed on linux-aarch64 because that's the only place where we've seen the issue in Mach5. It's just that simple. Doesn't

Re: RFR: 8268286: ProblemList serviceability/sa/TestJmapCore.java on linux-aarch64 with ZGC

2021-06-11 Thread Andrew Haley
On Sat, 5 Jun 2021 15:12:50 GMT, Daniel D. Daugherty wrote: > A trivial fix to ProblemList serviceability/sa/TestJmapCore.java on > linux-aarch64 with ZGC. Sort of. I'm trying to understand what can be AArch64-specific about any of this. If it's an AArch64-back-end-specific bug I'd like to kno