Integrated: Merge jdk17

2021-06-18 Thread Jesper Wilhelmsson
On Fri, 18 Jun 2021 22:17:41 GMT, Jesper Wilhelmsson wrote: > Forwardport JDK 17 -> JDK 18 This pull request has now been integrated. Changeset: b7d78a5b Author:Jesper Wilhelmsson URL: https://git.openjdk.java.net/jdk/commit/b7d78a5b661e2b00f271298db3b6cc873cf754e7 Stats: 12229

Re: RFR: Merge jdk17 [v2]

2021-06-18 Thread Jesper Wilhelmsson
> Forwardport JDK 17 -> JDK 18 Jesper Wilhelmsson has updated the pull request with a new target base due to a merge or a rebase. The pull request now contains 46 commits: - Merge - 8267042: bug in monitor locking/unlocking on ARM32 C1 due to uninitialized BasicObjectLock::_displaced_header

RFR: 8236212: CompiledMethodLoad and CompiledMethodUnload events can be posted in START phase

2021-06-18 Thread Alex Menkov
Accordingly the spec CompiledMethodLoad/CompiledMethodUnload events may be sent in the start and live phases. VM implementation send them only in the live phase, but tests should expect them in the start phase too - Commit messages: - Updated tests to allow CompiledMethodLoad/Unloa

Withdrawn: 8200559: Java agents doing instrumentation need a means to define auxiliary classes

2021-06-18 Thread duke
On Fri, 16 Apr 2021 13:44:16 GMT, Rafael Winterhalter wrote: > To allow agents the definition of auxiliary classes, an API is needed to > allow this. Currently, this is often achieved by using `sun.misc.Unsafe` or > `jdk.internal.misc.Unsafe` ever since the `defineClass` method was removed >

RFR: Merge jdk17

2021-06-18 Thread Jesper Wilhelmsson
Forwardport JDK 17 -> JDK 18 - Commit messages: - Merge - 8268316: Typo in JFR jdk.Deserialization event - 8268638: semaphores of AsyncLogWriter may be broken when JVM is exiting. - 8264775: ClhsdbFindPC still fails with java.lang.RuntimeException: 'In java stack' missing from st

Re: Information about possible JDB enhancements

2021-06-18 Thread Chris Plummer
Hi Jakob, You are correct in assuming that in general jdb is low priority. We mostly rely on it for testing jdi (there are quite a few jdb tests we maintain mainly for this purpose), and also for doing some targeted experimenting that might not be quite as easy to do with a full IDE. We do we

[jdk17] Integrated: 8264775: ClhsdbFindPC still fails with java.lang.RuntimeException: 'In java stack' missing from stdout/stderr

2021-06-18 Thread Chris Plummer
On Fri, 18 Jun 2021 17:42:21 GMT, Chris Plummer wrote: > Since a stack address can point to a hotspot object, findpc of a stack > address should allow for "Is of type..." to be the result, rather than > requiring it to be "In java stack". The implementation of findpc checks if > the address is

Re: [jdk17] RFR: 8264775: ClhsdbFindPC still fails with java.lang.RuntimeException: 'In java stack' missing from stdout/stderr

2021-06-18 Thread Chris Plummer
On Fri, 18 Jun 2021 17:42:21 GMT, Chris Plummer wrote: > Since a stack address can point to a hotspot object, findpc of a stack > address should allow for "Is of type..." to be the result, rather than > requiring it to be "In java stack". The implementation of findpc checks if > the address is

RFR: 8268433: serviceability/dcmd/framework/VMVersionTest.java fails with Unable to send object throw not established PipeIO Listener Thread connection

2021-06-18 Thread Alex Menkov
Main logic of the tests is: TestProcessLauncher t = ...; try { t.launch(); .. perform testing ... } finally { t.quit(); } We have some problem with the tests, but the exception from TestProcessLauncher.quit() masks it. The failures are very intermittent, so need to fix this excption t

Re: Information about possible JDB enhancements

2021-06-18 Thread daniel . daugherty
Forwarding to serviceability-dev@... Dan On 6/18/21 3:31 PM, Jakob Cornell wrote: Hi all, I'm hoping to become an OpenJDK contributor in order to make some enhancements to JDB, which is my go-to tool for Java debugging. As an example, JDB currently ignores empty commands, and I hope to make

Re: [jdk17] RFR: 8264775: ClhsdbFindPC still fails with java.lang.RuntimeException: 'In java stack' missing from stdout/stderr

2021-06-18 Thread Daniel D . Daugherty
On Fri, 18 Jun 2021 17:42:21 GMT, Chris Plummer wrote: > Since a stack address can point to a hotspot object, findpc of a stack > address should allow for "Is of type..." to be the result, rather than > requiring it to be "In java stack". The implementation of findpc checks if > the address is

Re: RFR: 8268698: Use Objects.check{Index, FromToIndex, FromIndexSize} where possible [v2]

2021-06-18 Thread Paul Sandoz
On Fri, 18 Jun 2021 05:54:01 GMT, Yi Yang wrote: >> After JDK-8265518(#3615), it's possible to replace all variants of >> checkIndex by >> Objects.checkIndex/Objects.checkFromToIndex/Objects.checkFromIndexSize in >> the whole JDK codebase. > > Yi Yang has updated the pull request incrementally

[jdk17] RFR: 8264775: ClhsdbFindPC still fails with java.lang.RuntimeException: 'In java stack' missing from stdout/stderr

2021-06-18 Thread Chris Plummer
Since a stack address can point to a hotspot object, findpc of a stack address should allow for "Is of type..." to be the result, rather than requiring it to be "In java stack". The implementation of findpc checks if the address is a hotspot object before checking if it is the stack, which seems

Re: Monitoring Java Safepoint Time in JDK16+

2021-06-18 Thread Carter Kozak
On Fri, Jun 18, 2021, at 02:47, David Holmes wrote: > On 18/06/2021 4:35 pm, Alan Bateman wrote: > > On 17/06/2021 22:44, David Holmes wrote: > >> > >> I must admit I'm a bit confused about these implementation-specific > >> MBeans. They are implementation-specific, so no part of the primary > >>

[jdk17] Integrated: 8268564: mark hotspot serviceability/attach tests which ignore external VM flags

2021-06-18 Thread Igor Ignatyev
On Thu, 10 Jun 2021 18:23:45 GMT, Igor Ignatyev wrote: > Hi all, > > could you please review this one-liner that adds `@requires vm.flagless` to 2 > `serviceability/attach` tests that ignore external VM flags? > > Thanks, > -- Igor This pull request has now been integrated. Changeset: 21abcc

[jdk17] Integrated: 8268531: mark SDTProbesGNULinuxTest as ignoring external VM flags

2021-06-18 Thread Igor Ignatyev
On Thu, 10 Jun 2021 16:46:12 GMT, Igor Ignatyev wrote: > (recreating openjdk/jdk#4453 against jdk17) > > Hi all, > > could you please review this patch that adds `@requires vm.flagless` to > `SDTProbesGNULinuxTest` test as it ignores all external VM flags? > > Thanks, > -- Igor This pull req

[jdk17] Integrated: 8268541: mark hotspot serviceability/sa tests which ignore external VM flags

2021-06-18 Thread Igor Ignatyev
On Thu, 10 Jun 2021 18:08:45 GMT, Igor Ignatyev wrote: > Hi all, > > could you please review this one-liner that adds `@requires vm.flagless` to > `serviceability/sa/TestJhsdbJstackLineNumbers.java` as it ignores external VM > flags? > > Thanks, > -- Igor This pull request has now been integ

[jdk17] Integrated: 8268563: mark hotspot serviceability/jvmti tests which ignore external VM flags

2021-06-18 Thread Igor Ignatyev
On Thu, 10 Jun 2021 18:19:46 GMT, Igor Ignatyev wrote: > Hi all, > > could you please review this one-liner that adds `@requires vm.flagless` to 6 > `serviceability/jvmti` tests that ignore external VM flags? > > Thanks, > -- Igor This pull request has now been integrated. Changeset: 5b19898

Re: [jdk17] RFR: 8268564: mark hotspot serviceability/attach tests which ignore external VM flags

2021-06-18 Thread Igor Ignatyev
On Thu, 10 Jun 2021 18:23:45 GMT, Igor Ignatyev wrote: > Hi all, > > could you please review this one-liner that adds `@requires vm.flagless` to 2 > `serviceability/attach` tests that ignore external VM flags? > > Thanks, > -- Igor Thank you, Serguei. - PR: https://git.openjdk.j

Re: [jdk17] RFR: 8268531: mark SDTProbesGNULinuxTest as ignoring external VM flags

2021-06-18 Thread Igor Ignatyev
On Thu, 10 Jun 2021 16:46:12 GMT, Igor Ignatyev wrote: > (recreating openjdk/jdk#4453 against jdk17) > > Hi all, > > could you please review this patch that adds `@requires vm.flagless` to > `SDTProbesGNULinuxTest` test as it ignores all external VM flags? > > Thanks, > -- Igor Serguei, than

Re: [jdk17] RFR: 8268541: mark hotspot serviceability/sa tests which ignore external VM flags

2021-06-18 Thread Igor Ignatyev
On Thu, 10 Jun 2021 18:08:45 GMT, Igor Ignatyev wrote: > Hi all, > > could you please review this one-liner that adds `@requires vm.flagless` to > `serviceability/sa/TestJhsdbJstackLineNumbers.java` as it ignores external VM > flags? > > Thanks, > -- Igor thank you, Serguei. -

Re: [jdk17] RFR: 8268563: mark hotspot serviceability/jvmti tests which ignore external VM flags

2021-06-18 Thread Igor Ignatyev
On Thu, 10 Jun 2021 18:19:46 GMT, Igor Ignatyev wrote: > Hi all, > > could you please review this one-liner that adds `@requires vm.flagless` to 6 > `serviceability/jvmti` tests that ignore external VM flags? > > Thanks, > -- Igor Serguei, thank you for your review. - PR: https:

Re: RFR: 8178287: AsyncGetCallTrace fails to traverse valid Java stacks [v3]

2021-06-18 Thread Ludovic Henry
> When the signal sent for AsyncGetCallTrace or JFR would land on a runtime > stub (like arraycopy), a vtable stub, or the prolog of a compiled method, it > wouldn't be able to detect the sender (caller) frame for multiple reasons. > This patch fixes these cases through adding CodeBlob-specific

Re: RFR: 8268857: Merge VM_PrintJNI and VM_PrintThreads and remove the unused field 'is_deadlock' of DeadlockCycle [v3]

2021-06-18 Thread Denghui Dong
On Thu, 17 Jun 2021 23:12:04 GMT, David Holmes wrote: >> Denghui Dong has refreshed the contents of this pull request, and previous >> commits have been removed. The incremental views will show differences >> compared to the previous content of the PR. > > Sorry still not a fan even with the ha

Re: RFR: 8268857: Merge VM_PrintJNI and VM_PrintThreads and remove the unused field 'is_deadlock' of DeadlockCycle [v7]

2021-06-18 Thread David Holmes
On Fri, 18 Jun 2021 06:51:53 GMT, Denghui Dong wrote: >> Hi, >> >> Could I have a review of this change that merges three vm >> operations(VM_PrintThreads, VM_PrintJNI, VM_FindDeadlocks) in thread_dump >> and signal_thread_entry. >> >> `jstack` is a very common command, even in the production