Re: RFR: 8269652: Factor out the common code for creating system j.l.Thread objects

2021-07-02 Thread Xin Liu
On Fri, 2 Jul 2021 07:03:50 GMT, David Holmes wrote: > Please review this simple refactoring to share the common code used to create > j.l.Thread instances for the internal VM JavaThreads. (Also fix a missing > space from my previous change in thread.cpp.) > > It is all very straight-forward.

Re: RFR: 8269652: Factor out the common code for creating system j.l.Thread objects

2021-07-02 Thread Vladimir Kozlov
On Fri, 2 Jul 2021 07:03:50 GMT, David Holmes wrote: > Please review this simple refactoring to share the common code used to create > j.l.Thread instances for the internal VM JavaThreads. (Also fix a missing > space from my previous change in thread.cpp.) > > It is all very straight-forward.

Re: RFR: 8269652: Factor out the common code for creating system j.l.Thread objects

2021-07-02 Thread David Holmes
On 3/07/2021 7:58 am, Daniel D.Daugherty wrote: On Fri, 2 Jul 2021 07:03:50 GMT, David Holmes wrote: Please review this simple refactoring to share the common code used to create j.l.Thread instances for the internal VM JavaThreads. (Also fix a missing space from my previous change in thread

Re: RFR: 8269652: Factor out the common code for creating system j.l.Thread objects

2021-07-02 Thread David Holmes
On 3/07/2021 4:27 am, Coleen Phillimore wrote: On Fri, 2 Jul 2021 07:03:50 GMT, David Holmes wrote: Please review this simple refactoring to share the common code used to create j.l.Thread instances for the internal VM JavaThreads. (Also fix a missing space from my previous change in thread.

[jdk17] RFR: 8269830: SA's vm object vtable matching code sometimes matches on incorrect type

2021-07-02 Thread Chris Plummer
See the CR for details. This issue is causing a lot of failures related to some threads occasionally not being included in the jstack output, such as SteadyStateThread, Common-Cleaner, and "Signal Dispatcher". The bug caused SA to sometimes think a JavaThread object is actually an instance of th

Re: RFR: 8269652: Factor out the common code for creating system j.l.Thread objects

2021-07-02 Thread Daniel D . Daugherty
On Fri, 2 Jul 2021 07:03:50 GMT, David Holmes wrote: > Please review this simple refactoring to share the common code used to create > j.l.Thread instances for the internal VM JavaThreads. (Also fix a missing > space from my previous change in thread.cpp.) > > It is all very straight-forward.

RFR: 8269616: serviceability/dcmd/framework/VMVersionTest.java fails with Address already in use error

2021-07-02 Thread Alex Menkov
SocketIOPipe/IOPipe classes can select listening port by 2 ways: 1. caller specifies "-transport.address=dynamic" argument creating ArgumentHandler, and calls Binder.prepareForPipeConnection (actually see nsk.share.jpda.DebugeeBinder.prepareForPipeConnection()) before start listening. In the case

Re: RFR: 8269770: nsk tests should start IOPipe channel before launch debuggee - Debugee.prepareDebugee [v2]

2021-07-02 Thread Alex Menkov
> The change fixes several hundreds tests which launch debugee by using uses > Debugee.prepareDebugee() method or use > debugee = Binder.bindToDebugee(...); > IOPipe pipe = debugee.createIOPipe(); > logic. > Debugee.prepareDebugee() and Binder.bindToDebugee() launch debuggee by using > CommandLi

Re: RFR: 8269652: Factor out the common code for creating system j.l.Thread objects

2021-07-02 Thread Coleen Phillimore
On Fri, 2 Jul 2021 07:03:50 GMT, David Holmes wrote: > Please review this simple refactoring to share the common code used to create > j.l.Thread instances for the internal VM JavaThreads. (Also fix a missing > space from my previous change in thread.cpp.) > > It is all very straight-forward.

Re: RFR: 8262386: resourcehogs/serviceability/sa/TestHeapDumpForLargeArray.java timed out [v14]

2021-07-02 Thread Lin Zang
On Mon, 7 Jun 2021 08:01:54 GMT, Lin Zang wrote: >> 8262386: resourcehogs/serviceability/sa/TestHeapDumpForLargeArray.java timed >> out > > Lin Zang has updated the pull request with a new target base due to a merge > or a rebase. The incremental webrev excludes the unrelated changes brought in

RFR: 8269685: Optimize HeapHprofBinWriter implementation

2021-07-02 Thread Lin Zang
This PR rewrite the implementation of the HeapHprofBinWriter, which could simplify the logic of current implementation. please see detail description at https://bugs.openjdk.java.net/browse/JDK-8269685. - Commit messages: - 8269685: Optimize HeapHprofBinWriter implementation Chang

RFR: 8269652: Factor out the common code for creating system j.l.Thread objects

2021-07-02 Thread David Holmes
Please review this simple refactoring to share the common code used to create j.l.Thread instances for the internal VM JavaThreads. (Also fix a missing space from my previous change in thread.cpp.) It is all very straight-forward. Compiler folk I can go one step further and remove CompileBroke