Re: RFR: 8270862: Fix problem list entries for 32-bit

2021-07-16 Thread Serguei Spitsyn
On Sat, 17 Jul 2021 00:50:04 GMT, David Holmes wrote: > 32-bit is specified as linux-i586 not linux-x86 > > Waiting for GHA results to confirm. > > Thanks, > David Hi David, Looks good and trivial. Thanks, Serguei - Marked as reviewed by sspitsyn (Reviewer). PR: https://git.ope

RFR: 8270862: Fix problem list entries for 32-bit

2021-07-16 Thread David Holmes
32-bit is specified as linux-i586 not linux-x86 Waiting for GHA results to confirm. Thanks, David - Commit messages: - Fix 32-bit Changes: https://git.openjdk.java.net/jdk/pull/4818/files Webrev: https://webrevs.openjdk.java.net/?repo=jdk&pr=4818&range=00 Issue: https://bugs.o

RFR: 8213714: AttachingConnector/attach/attach001 failed due to "bind failed: Address already in use"

2021-07-16 Thread Alex Menkov
The fix updates the tests to use dynamic port launching debuggee and get the listening port from the debugee output - Commit messages: - Fixed AttachingConnector tests Changes: https://git.openjdk.java.net/jdk/pull/4817/files Webrev: https://webrevs.openjdk.java.net/?repo=jdk&pr=4

Re: RFR: 8269909: getStack method in hprof.parser.Reader should use try-with-resource [v5]

2021-07-16 Thread David Holmes
On Fri, 16 Jul 2021 11:53:15 GMT, Lin Zang wrote: >> 8269909: getStack method in hprof.parser.Reader should use try-with-resource > > Lin Zang has updated the pull request incrementally with one additional > commit since the last revision: > > rename variables LGTM. Thanks, David -

Re: RFR: 8261236: C2: ClhsdbJstackXcompStress test fails when StressGCM is enabled

2021-07-16 Thread Chris Plummer
On Fri, 16 Jul 2021 10:24:56 GMT, Nick Gasson wrote: > The clhsdb jstack command crashes when the debugged program is run with > `-Xcomp -XX:+StressGCM -XX:StressSeed=2` on AArch64: > > > sun.jvm.hotspot.utilities.AssertionFailure: sanity check > at jdk.hotspot.agent/sun.jvm.hotspot.utilit

Re: RFR: JDK-8270820: remove unused stiFileTableIndex from SDE.c

2021-07-16 Thread Serguei Spitsyn
On Fri, 16 Jul 2021 07:24:55 GMT, Matthias Baesken wrote: > Hello, please review this very small change. While checking compiler warnings > of the type : "function 'xyz' was declared but never referenced" I came > across stiFileTableIndex from SDE.c that generated such a warning and can be > r

Re: RFR: JDK-8270820: remove unused stiFileTableIndex from SDE.c

2021-07-16 Thread Chris Plummer
On Fri, 16 Jul 2021 07:24:55 GMT, Matthias Baesken wrote: > Hello, please review this very small change. While checking compiler warnings > of the type : "function 'xyz' was declared but never referenced" I came > across stiFileTableIndex from SDE.c that generated such a warning and can be > r

Re: RFR: 8269909: getStack method in hprof.parser.Reader should use try-with-resource [v5]

2021-07-16 Thread Chris Plummer
On Fri, 16 Jul 2021 11:53:15 GMT, Lin Zang wrote: >> 8269909: getStack method in hprof.parser.Reader should use try-with-resource > > Lin Zang has updated the pull request incrementally with one additional > commit since the last revision: > > rename variables Marked as reviewed by cjplummer

Re: RFR: 8269909: getStack method in hprof.parser.Reader should use try-with-resource [v4]

2021-07-16 Thread Lin Zang
On Thu, 15 Jul 2021 17:22:31 GMT, Serguei Spitsyn wrote: >> Lin Zang has updated the pull request with a new target base due to a merge >> or a rebase. The incremental webrev excludes the unrelated changes brought >> in by the merge/rebase. The pull request contains five additional commits >>

Re: RFR: 8269909: getStack method in hprof.parser.Reader should use try-with-resource [v5]

2021-07-16 Thread Lin Zang
> 8269909: getStack method in hprof.parser.Reader should use try-with-resource Lin Zang has updated the pull request incrementally with one additional commit since the last revision: rename variables - Changes: - all: https://git.openjdk.java.net/jdk/pull/4717/files - new: ht

RFR: 8261236: C2: ClhsdbJstackXcompStress test fails when StressGCM is enabled

2021-07-16 Thread Nick Gasson
The clhsdb jstack command crashes when the debugged program is run with `-Xcomp -XX:+StressGCM -XX:StressSeed=2` on AArch64: sun.jvm.hotspot.utilities.AssertionFailure: sanity check at jdk.hotspot.agent/sun.jvm.hotspot.utilities.Assert.that(Assert.java:32) at jdk.hotspot.agent/sun.jvm.hot

Re: RFR: JDK-8270820: remove unused stiFileTableIndex from SDE.c

2021-07-16 Thread NikolayTach
On Fri, 16 Jul 2021 07:24:55 GMT, Matthias Baesken wrote: > Hello, please review this very small change. While checking compiler warnings > of the type : "function 'xyz' was declared but never referenced" I came > across stiFileTableIndex from SDE.c that generated such a warning and can be > r

RFR: JDK-8270820: remove unused stiFileTableIndex from SDE.c

2021-07-16 Thread Matthias Baesken
Hello, please review this very small change. While checking compiler warnings of the type : "function 'xyz' was declared but never referenced" I came across stiFileTableIndex from SDE.c that generated such a warning and can be removed. Thanks, Matthias - Commit messages: - JDK-827

Integrated: 8270814: ProblemList the failing serviceability/jvmti/HeapMonitor/MyPackage/HeapMonitor* tests

2021-07-16 Thread David Holmes
On Fri, 16 Jul 2021 06:02:05 GMT, David Holmes wrote: > Two tests have started failing regularly in our CI testing, and also in GHA, > so I'm ProblemListing them until the issue can be resolved. > > Thanks, > David This pull request has now been integrated. Changeset: 4927ee42 Author:Davi

Re: RFR: 8270814: ProblemList the failing serviceability/jvmti/HeapMonitor/MyPackage/HeapMonitor* tests

2021-07-16 Thread David Holmes
On Fri, 16 Jul 2021 06:41:59 GMT, Thomas Schatzl wrote: >> Two tests have started failing regularly in our CI testing, and also in GHA, >> so I'm ProblemListing them until the issue can be resolved. >> >> Thanks, >> David > > Marked as reviewed by tschatzl (Reviewer). Thanks for the reviews @t

Re: RFR: 8270814: ProblemList the failing serviceability/jvmti/HeapMonitor/MyPackage/HeapMonitor* tests

2021-07-16 Thread NikolayTach
On Fri, 16 Jul 2021 06:02:05 GMT, David Holmes wrote: > Two tests have started failing regularly in our CI testing, and also in GHA, > so I'm ProblemListing them until the issue can be resolved. > > Thanks, > David It doesn't include a complete implementation of the Java SE 16 Platform and ad