Re: RFR: JDK-8272318: Improve performance of HeapDumpAllTest

2021-08-11 Thread Ralf Schmelter
On Wed, 11 Aug 2021 19:19:51 GMT, Chris Plummer wrote: > Is there a reason you don't want this change to also apply to HeapDumpTest? Since the GC.heap_dump already does a GC it is not really needed. Of course doing the gc in HeapDumpTest is a smaller change, so I'm open for that. -

Integrated: 8272120: Avoid looking for standard encodings in "java." modules

2021-08-11 Thread Sergey Bylokhov
On Tue, 10 Aug 2021 05:08:54 GMT, Sergey Bylokhov wrote: > This is the continuation of JDK-8233884 and JDK-8271456. This change affects > fewer cases so I fix all "java." modules at once. > > In many places standard charsets are looked up via their names, for example: > absolutePath.getBytes("U

Re: RFR: JDK-8272318: Improve performance of HeapDumpAllTest

2021-08-11 Thread Sergey Bylokhov
On Wed, 11 Aug 2021 13:05:06 GMT, Ralf Schmelter wrote: > This change triggers a GC by System.gc() in the test case, so the created > heap dump is significantly smaller and the test runs much faster. I also tried to improve this test, it almost always fails because of OOM when tried to parse t

Re: RFR: JDK-8272318: Improve performance of HeapDumpAllTest

2021-08-11 Thread Chris Plummer
On Wed, 11 Aug 2021 13:05:06 GMT, Ralf Schmelter wrote: > This change triggers a GC by System.gc() in the test case, so the created > heap dump is significantly smaller and the test runs much faster. Is there a reason you don't want this change to also apply to HeapDumpTest? - PR:

Re: RFR: 8272120: Avoid looking for standard encodings in "java." modules

2021-08-11 Thread Naoto Sato
On Tue, 10 Aug 2021 05:08:54 GMT, Sergey Bylokhov wrote: > This is the continuation of JDK-8233884 and JDK-8271456. This change affects > fewer cases so I fix all "java." modules at once. > > In many places standard charsets are looked up via their names, for example: > absolutePath.getBytes("U

Re: RFR: 8272120: Avoid looking for standard encodings in "java." modules

2021-08-11 Thread Daniel Fuchs
On Tue, 10 Aug 2021 05:08:54 GMT, Sergey Bylokhov wrote: > This is the continuation of JDK-8233884 and JDK-8271456. This change affects > fewer cases so I fix all "java." modules at once. > > In many places standard charsets are looked up via their names, for example: > absolutePath.getBytes("U

Re: RFR: 8272120: Avoid looking for standard encodings in "java." modules

2021-08-11 Thread Alan Bateman
On Tue, 10 Aug 2021 18:41:04 GMT, Claes Redestad wrote: > Yes, while I don't know exactly which changes resolved JDK-6764325, it's > clear from the microbenchmarks added for #2102 that it's no longer an issue - > at least not in the mainline. Thanks for checking and for closing that issue. --

Re: RFR: 8272120: Avoid looking for standard encodings in "java." modules

2021-08-11 Thread Alan Bateman
On Tue, 10 Aug 2021 05:08:54 GMT, Sergey Bylokhov wrote: > This is the continuation of JDK-8233884 and JDK-8271456. This change affects > fewer cases so I fix all "java." modules at once. > > In many places standard charsets are looked up via their names, for example: > absolutePath.getBytes("U

Re: RFR: 8272120: Avoid looking for standard encodings in "java." modules

2021-08-11 Thread Naoto Sato
On Tue, 10 Aug 2021 05:08:54 GMT, Sergey Bylokhov wrote: > This is the continuation of JDK-8233884 and JDK-8271456. This change affects > fewer cases so I fix all "java." modules at once. > > In many places standard charsets are looked up via their names, for example: > absolutePath.getBytes("U

RFR: JDK-8272318: Improve performance of HeapDumpAllTest

2021-08-11 Thread Ralf Schmelter
This change triggers a GC by System.gc() in the test case, so the created heap dump is significantly smaller and the test runs much faster. - Commit messages: - Improve performance of HeapDumpAllTest Changes: https://git.openjdk.java.net/jdk/pull/5084/files Webrev: https://webrevs

Re: RFR: 8272120: Avoid looking for standard encodings in "java." modules

2021-08-11 Thread Daniel Fuchs
On Tue, 10 Aug 2021 05:08:54 GMT, Sergey Bylokhov wrote: > This is the continuation of JDK-8233884 and JDK-8271456. This change affects > fewer cases so I fix all "java." modules at once. > > In many places standard charsets are looked up via their names, for example: > absolutePath.getBytes("U