Hi all,
While working on changes for JBS 8271356 I spent some time testing on locales
other than en-US and found something a bit odd. I can override the system
default locale for JDB by setting the `LANG' environment variable (on Linux),
and I can override the system locale for the debuggee b
On Fri, 20 Aug 2021 16:41:40 GMT, Coleen Phillimore wrote:
> I moved nonleaf ranked locks to be leaf (or leaf+something). Many of the
> leaf locks are safepoint_check_never. Segregating this rank into safepoint
> checking and non-safepoint checking is left for a future RFE.
> Tested with tier
On Wed, 1 Sep 2021 17:05:26 GMT, Coleen Phillimore wrote:
>> I moved nonleaf ranked locks to be leaf (or leaf+something). Many of the
>> leaf locks are safepoint_check_never. Segregating this rank into safepoint
>> checking and non-safepoint checking is left for a future RFE.
>> Tested with t
On Wed, 1 Sep 2021 17:52:49 GMT, Coleen Phillimore wrote:
>> src/hotspot/share/runtime/mutexLocker.cpp line 270:
>>
>>> 268:
>>> 269: def(Threads_lock , PaddedMonitor, barrier, true,
>>> _safepoint_check_always); // Used for safepoint protocol.
>>> 270: def(NonJavaThr
On Wed, 1 Sep 2021 17:27:33 GMT, Patricio Chilano Mateo
wrote:
>> Coleen Phillimore has updated the pull request with a new target base due to
>> a merge or a rebase. The pull request now contains four commits:
>>
>> - Fix merge error.
>> - Merge branch 'master' into nonleaf
>> - Remove Jfr
On Wed, 1 Sep 2021 17:35:12 GMT, Naoto Sato wrote:
>> A trivial fix to ProblemList
>> java/lang/instrument/BootClassPath/BootClassPathTest.sh on all configs.
>
> Marked as reviewed by naoto (Reviewer).
@naotoj - Thanks for the review!
-
PR: https://git.openjdk.java.net/jdk/pull/53
On Wed, 1 Sep 2021 17:33:13 GMT, Daniel D. Daugherty wrote:
> A trivial fix to ProblemList
> java/lang/instrument/BootClassPath/BootClassPathTest.sh on all configs.
This pull request has now been integrated.
Changeset: 4ee0dace
Author:Daniel D. Daugherty
URL:
https://git.openjdk.ja
On Tue, 31 Aug 2021 20:02:37 GMT, Naoto Sato wrote:
>> Trivial fixes to reduce the noise in the JDK18 CI:
>> JDK-8273197 ProblemList 2 jtools tests due to JDK-8273187
>> JDK-8273198 ProblemList
>> java/lang/instrument/BootClassPath/BootClassPathTest.sh due to JDK-8273188
>>
>> These failures ha
On Wed, 1 Sep 2021 17:33:13 GMT, Daniel D. Daugherty wrote:
> A trivial fix to ProblemList
> java/lang/instrument/BootClassPath/BootClassPathTest.sh on all configs.
Marked as reviewed by naoto (Reviewer).
-
PR: https://git.openjdk.java.net/jdk/pull/5337
A trivial fix to ProblemList
java/lang/instrument/BootClassPath/BootClassPathTest.sh on all configs.
-
Commit messages:
- 8273248: ProblemList java/lang/instrument/BootClassPath/BootClassPathTest.sh
on all configs
Changes: https://git.openjdk.java.net/jdk/pull/5337/files
Webrev:
On Tue, 31 Aug 2021 21:52:12 GMT, Coleen Phillimore wrote:
>> I moved nonleaf ranked locks to be leaf (or leaf+something). Many of the
>> leaf locks are safepoint_check_never. Segregating this rank into safepoint
>> checking and non-safepoint checking is left for a future RFE.
>> Tested with
> I moved nonleaf ranked locks to be leaf (or leaf+something). Many of the
> leaf locks are safepoint_check_never. Segregating this rank into safepoint
> checking and non-safepoint checking is left for a future RFE.
> Tested with tier1-3. Tier 4-6 testing in progress.
Coleen Phillimore has up
On Wed, 1 Sep 2021 01:40:17 GMT, Coleen Phillimore wrote:
> Make lock be declared as safepoint_check_never.
> Ran tier1-3 tests and test that uses this code:
> serviceability/dcmd/gc/ClassHistogramTest.java
Thanks David and Patricio!
-
PR: https://git.openjdk.java.net/jdk/pull/532
On Wed, 1 Sep 2021 01:40:17 GMT, Coleen Phillimore wrote:
> Make lock be declared as safepoint_check_never.
> Ran tier1-3 tests and test that uses this code:
> serviceability/dcmd/gc/ClassHistogramTest.java
This pull request has now been integrated.
Changeset: dacd1978
Author:Coleen Philli
On Wed, 1 Sep 2021 01:40:17 GMT, Coleen Phillimore wrote:
> Make lock be declared as safepoint_check_never.
> Ran tier1-3 tests and test that uses this code:
> serviceability/dcmd/gc/ClassHistogramTest.java
LGTM.
Thanks,
Patricio
-
Marked as reviewed by pchilanomate (Committer).
On Wed, 1 Sep 2021 11:32:15 GMT, Coleen Phillimore wrote:
>> src/hotspot/share/memory/heapInspection.cpp line 564:
>>
>>> 562: missed_count = ric.missed_count();
>>> 563: {
>>> 564: MutexLocker x(&_mutex, Mutex::_no_safepoint_check_flag);
>>
>> This change seems unnecessary - this lock
On Wed, 1 Sep 2021 01:40:17 GMT, Coleen Phillimore wrote:
> Make lock be declared as safepoint_check_never.
> Ran tier1-3 tests and test that uses this code:
> serviceability/dcmd/gc/ClassHistogramTest.java
Marked as reviewed by dholmes (Reviewer).
-
PR: https://git.openjdk.java.n
On Wed, 1 Sep 2021 06:28:36 GMT, David Holmes wrote:
>> Make lock be declared as safepoint_check_never.
>> Ran tier1-3 tests and test that uses this code:
>> serviceability/dcmd/gc/ClassHistogramTest.java
>
> src/hotspot/share/memory/heapInspection.cpp line 564:
>
>> 562: missed_count = ric.m
On Wed, 1 Sep 2021 01:40:17 GMT, Coleen Phillimore wrote:
> Make lock be declared as safepoint_check_never.
> Ran tier1-3 tests and test that uses this code:
> serviceability/dcmd/gc/ClassHistogramTest.java
Hi Coleen,
The main change is fine, but the other seems unnecessary - see comment below
19 matches
Mail list logo
