On Mon, 6 Sep 2021 08:03:22 GMT, Lin Zang wrote:
>> 8252842: Extend jmap to support parallel heap dump
>
> Lin Zang has updated the pull request incrementally with one additional
> commit since the last revision:
>
> fix build error
I will start reviewing this today.
-
PR:
On Thu, 19 Aug 2021 21:18:53 GMT, Leonid Mesnik wrote:
> monitors_iterate make several checks which often are true before filter
> monitor by a thread. It might take a lot of time when there are a lot of
> threads. So it makes sense to first check thread and only then other
> conditions.
On Fri, 3 Sep 2021 01:26:01 GMT, Daniel D. Daugherty wrote:
>> monitors_iterate make several checks which often are true before filter
>> monitor by a thread. It might take a lot of time when there are a lot of
>> threads. So it makes sense to first check thread and only then other
>>
On Wed, 8 Sep 2021 02:07:47 GMT, David Holmes wrote:
>> A trivial fix to bump the timeout value for the second sub-test in
>> jfr/api/consumer/TestRecordedFrame.java. See the bug report
>> for the gory details.
>
> LGTM!
>
> Thanks,
> David
@dholmes-ora - Thanks for the lightning fast review!
On Wed, 8 Sep 2021 02:04:50 GMT, Daniel D. Daugherty wrote:
> A trivial fix to bump the timeout value for the second sub-test in
> jfr/api/consumer/TestRecordedFrame.java. See the bug report
> for the gory details.
This pull request has now been integrated.
Changeset: ea4907a8
Author:
A trivial fix to bump the timeout value for the second sub-test in
jfr/api/consumer/TestRecordedFrame.java. See the bug report
for the gory details.
-
Commit messages:
- 8273047: test jfr/api/consumer/TestRecordedFrame.java timing out
Changes:
On Wed, 8 Sep 2021 02:04:50 GMT, Daniel D. Daugherty wrote:
> A trivial fix to bump the timeout value for the second sub-test in
> jfr/api/consumer/TestRecordedFrame.java. See the bug report
> for the gory details.
LGTM!
Thanks,
David
-
Marked as reviewed by dholmes (Reviewer).
On Tue, 7 Sep 2021 12:25:54 GMT, Leo Korinth wrote:
> The basic problem is that we are relying on undefined behaviour, as
> documented in the code:
>
> // This whole business of passing information from ResourceObj::operator new
> // to the ResourceObj constructor via fields in the "object" is
On Thu, 28 Jan 2021 07:30:29 GMT, Serguei Spitsyn wrote:
>> 8252842: Extend jmap to support parallel heap dump
>
> Hi Lin,
> It is also in my memory that you actually did not have 4 arguments.
> The real incompatibility issue was that the order of arguments was swapped.
> It is why it was
The basic problem is that we are relying on undefined behaviour, as documented
in the code:
// This whole business of passing information from ResourceObj::operator new
// to the ResourceObj constructor via fields in the "object" is technically UB.
// But it seems to work within the limitations
10 matches
Mail list logo