Re: RFR: 8252842: Extend jmap to support parallel heap dump [v32]

2021-09-07 Thread Ralf Schmelter
On Mon, 6 Sep 2021 08:03:22 GMT, Lin Zang wrote: >> 8252842: Extend jmap to support parallel heap dump > > Lin Zang has updated the pull request incrementally with one additional > commit since the last revision: > > fix build error I will start reviewing this today. - PR:

Re: RFR: 8265489: Stress test times out because of long ObjectSynchronizer::monitors_iterate(...) operation

2021-09-07 Thread Daniel D . Daugherty
On Thu, 19 Aug 2021 21:18:53 GMT, Leonid Mesnik wrote: > monitors_iterate make several checks which often are true before filter > monitor by a thread. It might take a lot of time when there are a lot of > threads. So it makes sense to first check thread and only then other > conditions.

Re: RFR: 8265489: Stress test times out because of long ObjectSynchronizer::monitors_iterate(...) operation

2021-09-07 Thread Daniel D . Daugherty
On Fri, 3 Sep 2021 01:26:01 GMT, Daniel D. Daugherty wrote: >> monitors_iterate make several checks which often are true before filter >> monitor by a thread. It might take a lot of time when there are a lot of >> threads. So it makes sense to first check thread and only then other >>

Re: Integrated: 8273047: test jfr/api/consumer/TestRecordedFrame.java timing out

2021-09-07 Thread Daniel D . Daugherty
On Wed, 8 Sep 2021 02:07:47 GMT, David Holmes wrote: >> A trivial fix to bump the timeout value for the second sub-test in >> jfr/api/consumer/TestRecordedFrame.java. See the bug report >> for the gory details. > > LGTM! > > Thanks, > David @dholmes-ora - Thanks for the lightning fast review!

Integrated: 8273047: test jfr/api/consumer/TestRecordedFrame.java timing out

2021-09-07 Thread Daniel D . Daugherty
On Wed, 8 Sep 2021 02:04:50 GMT, Daniel D. Daugherty wrote: > A trivial fix to bump the timeout value for the second sub-test in > jfr/api/consumer/TestRecordedFrame.java. See the bug report > for the gory details. This pull request has now been integrated. Changeset: ea4907a8 Author:

Integrated: 8273047: test jfr/api/consumer/TestRecordedFrame.java timing out

2021-09-07 Thread Daniel D . Daugherty
A trivial fix to bump the timeout value for the second sub-test in jfr/api/consumer/TestRecordedFrame.java. See the bug report for the gory details. - Commit messages: - 8273047: test jfr/api/consumer/TestRecordedFrame.java timing out Changes:

Re: Integrated: 8273047: test jfr/api/consumer/TestRecordedFrame.java timing out

2021-09-07 Thread David Holmes
On Wed, 8 Sep 2021 02:04:50 GMT, Daniel D. Daugherty wrote: > A trivial fix to bump the timeout value for the second sub-test in > jfr/api/consumer/TestRecordedFrame.java. See the bug report > for the gory details. LGTM! Thanks, David - Marked as reviewed by dholmes (Reviewer).

Re: RFR: 8269537: memset() is called after operator new

2021-09-07 Thread Ioi Lam
On Tue, 7 Sep 2021 12:25:54 GMT, Leo Korinth wrote: > The basic problem is that we are relying on undefined behaviour, as > documented in the code: > > // This whole business of passing information from ResourceObj::operator new > // to the ResourceObj constructor via fields in the "object" is

Re: RFR: 8252842: Extend jmap to support parallel heap dump

2021-09-07 Thread Chris Plummer
On Thu, 28 Jan 2021 07:30:29 GMT, Serguei Spitsyn wrote: >> 8252842: Extend jmap to support parallel heap dump > > Hi Lin, > It is also in my memory that you actually did not have 4 arguments. > The real incompatibility issue was that the order of arguments was swapped. > It is why it was

RFR: 8269537: memset() is called after operator new

2021-09-07 Thread Leo Korinth
The basic problem is that we are relying on undefined behaviour, as documented in the code: // This whole business of passing information from ResourceObj::operator new // to the ResourceObj constructor via fields in the "object" is technically UB. // But it seems to work within the limitations