Re: RFR: 8252842: Extend jmap to support parallel heap dump [v32]

2021-09-09 Thread Lin Zang
On Mon, 6 Sep 2021 08:03:22 GMT, Lin Zang wrote: >> 8252842: Extend jmap to support parallel heap dump > > Lin Zang has updated the pull request incrementally with one additional > commit since the last revision: > > fix build error Seems the #5410 has made some change that will affect this

Re: RFR: 8273482: Remove "foreground work" concept from WorkGang [v2]

2021-09-09 Thread Per Liden
> JDK-8237354 introduced the concept of "foreground work" in WorkGang, as a > special case for use by the HeapDumper. I propose that we remove this code, > since this special use case can be solved without the need for the concept of > "foreground work" in WorkGang. > > As far as I can tell, th

Re: RFR: 8273482: Remove "foreground work" concept from WorkGang

2021-09-09 Thread Per Liden
On Wed, 8 Sep 2021 09:56:21 GMT, Per Liden wrote: > JDK-8237354 introduced the concept of "foreground work" in WorkGang, as a > special case for use by the HeapDumper. I propose that we remove this code, > since this special use case can be solved without the need for the concept of > "foregro

Integrated: 8273188: java/lang/instrument/BootClassPath/BootClassPathTest.sh fails with "FATAL ERROR in native method: processing of -javaagent failed, processJavaStart failed"

2021-09-09 Thread Naoto Sato
On Wed, 8 Sep 2021 22:15:12 GMT, Naoto Sato wrote: > The gist of the issue is that the test case now always creates the boot > classpath with non-ASCII chars appended, because the default encoding is > fixed to UTF-8 with the fix to JDK-8260265. > > On macOS, javaagent tries to load the class

Re: RFR: 8252842: Extend jmap to support parallel heap dump [v32]

2021-09-09 Thread Chris Plummer
On Wed, 8 Sep 2021 05:02:18 GMT, Ralf Schmelter wrote: > I will start reviewing this today. Thanks! - PR: https://git.openjdk.java.net/jdk/pull/2261

Re: RFR: 8273188: java/lang/instrument/BootClassPath/BootClassPathTest.sh fails with "FATAL ERROR in native method: processing of -javaagent failed, processJavaStart failed"

2021-09-09 Thread Alan Bateman
On Wed, 8 Sep 2021 22:15:12 GMT, Naoto Sato wrote: > The gist of the issue is that the test case now always creates the boot > classpath with non-ASCII chars appended, because the default encoding is > fixed to UTF-8 with the fix to JDK-8260265. > > On macOS, javaagent tries to load the class