Re: RFR: 8252842: Extend jmap to support parallel heap dump [v36]

2021-09-15 Thread Lin Zang
> 8252842: Extend jmap to support parallel heap dump Lin Zang has updated the pull request incrementally with one additional commit since the last revision: fix build issue - Changes: - all: https://git.openjdk.java.net/jdk/pull/2261/files - new: https://git.openjdk.java.net/

Re: RFR: 8252842: Extend jmap to support parallel heap dump [v35]

2021-09-15 Thread Lin Zang
> 8252842: Extend jmap to support parallel heap dump Lin Zang has updated the pull request incrementally with one additional commit since the last revision: code refine - Changes: - all: https://git.openjdk.java.net/jdk/pull/2261/files - new: https://git.openjdk.java.net/jdk/

Re: RFR: 8252842: Extend jmap to support parallel heap dump [v34]

2021-09-15 Thread Lin Zang
> 8252842: Extend jmap to support parallel heap dump Lin Zang has updated the pull request incrementally with one additional commit since the last revision: fix issue - Changes: - all: https://git.openjdk.java.net/jdk/pull/2261/files - new: https://git.openjdk.java.net/jdk/pu

RFR: 8270434: JDI+UT: Unexpected event in JDI tests

2021-09-15 Thread Alex Menkov
Updated the tests to skip events from unexpected threads. - Commit messages: - Fixed test to handle events from system threads Changes: https://git.openjdk.java.net/jdk/pull/5538/files Webrev: https://webrevs.openjdk.java.net/?repo=jdk&pr=5538&range=00 Issue: https://bugs.openjdk

Integrated: 8273575: memory leak in appendBootClassPath(), paths must be deallocated

2021-09-15 Thread Serguei Spitsyn
On Wed, 15 Sep 2021 01:05:10 GMT, Serguei Spitsyn wrote: > The memory allocated and hold in the paths local variable of function > appendBootClassPath() is never deallocated: > splitPathList(pathList, &count, &paths); > So, it is a memory leak which needs to be fixed. > The fix is to add one

Re: RFR: 8273575: memory leak in appendBootClassPath(), paths must be deallocated

2021-09-15 Thread Serguei Spitsyn
On Wed, 15 Sep 2021 01:05:10 GMT, Serguei Spitsyn wrote: > The memory allocated and hold in the paths local variable of function > appendBootClassPath() is never deallocated: > splitPathList(pathList, &count, &paths); > So, it is a memory leak which needs to be fixed. > The fix is to add one

Re: RFR: 8273575: memory leak in appendBootClassPath(), paths must be deallocated

2021-09-15 Thread Alex Menkov
On Wed, 15 Sep 2021 01:05:10 GMT, Serguei Spitsyn wrote: > The memory allocated and hold in the paths local variable of function > appendBootClassPath() is never deallocated: > splitPathList(pathList, &count, &paths); > So, it is a memory leak which needs to be fixed. > The fix is to add one

Re: RFR: 8273684: Unnecessary Stack usage

2021-09-15 Thread Chris Plummer
On Wed, 15 Sep 2021 18:27:05 GMT, Andrey Turbanov wrote: >> I wonder if you are exporting CLASSPATH and that is causing `jhsdb` to pick >> up the wrong SA implementation. > > Rechecked again. > Now without involving IDEA. Just started small java program and then attached. > Then checkouted revi

Re: RFR: 8273684: Unnecessary Stack usage

2021-09-15 Thread Chris Plummer
On Sun, 29 Aug 2021 21:14:19 GMT, Andrey Turbanov wrote: > Usage of thread-safe collection Stack is unnecessary. It's recommended to use > ArrayDequeue if a thread-safe implementation is not needed. Marked as reviewed by cjplummer (Reviewer). - PR: https://git.openjdk.java.net/jd

Re: RFR: 8273684: Unnecessary Stack usage

2021-09-15 Thread Andrey Turbanov
On Wed, 15 Sep 2021 17:03:43 GMT, Chris Plummer wrote: >> SA doesn't doesn't run any code on the target. > > I wonder if you are exporting CLASSPATH and that is causing `jhsdb` to pick > up the wrong SA implementation. Rechecked again. Now without involving IDEA. Just started small java program

Re: RFR: 8273684: Unnecessary Stack usage

2021-09-15 Thread Chris Plummer
On Wed, 15 Sep 2021 16:42:39 GMT, Chris Plummer wrote: >> I wondered about this too. Perhaps this messages coming from the _target >> JDK_ which I'm attached too? >> I attached to my IntelliJ IDEA process. It uses JDK 11. > > SA doesn't doesn't run any code on the target. I wonder if you are ex

Re: RFR: 8273684: Unnecessary Stack usage

2021-09-15 Thread Chris Plummer
On Wed, 15 Sep 2021 16:34:51 GMT, Andrey Turbanov wrote: >> There is something wrong with the version of jhsdb you are running. It >> appears to be an old version, not the latest. You should not be seeing the >> following warning. The code that produces it is not even present in the >> latest

Re: RFR: 8273684: Unnecessary Stack usage

2021-09-15 Thread Andrey Turbanov
On Wed, 15 Sep 2021 16:28:51 GMT, Chris Plummer wrote: >> Checked. >> Ordering is the same. >> ![изображение](https://user-images.githubusercontent.com/741251/133420954-67404798-b56d-4d6f-98ee-c457622d58f4.png) >> >> [with_fixes_java_vmstructsdump.txt](https://github.com/openjdk/jdk/files/716944

Re: RFR: 8273684: Unnecessary Stack usage

2021-09-15 Thread Chris Plummer
On Wed, 15 Sep 2021 10:53:47 GMT, Andrey Turbanov wrote: >> src/jdk.hotspot.agent/share/classes/sun/jvm/hotspot/CommandProcessor.java >> line 988: >> >>> 986: // Make sure the types are emitted in an order than >>> can be read back in >>> 987: HashSet emitted =

Re: RFR: 8272992: Replace usages of Collections.sort with List.sort call in jdk.* modules [v2]

2021-09-15 Thread Andrey Turbanov
On Tue, 14 Sep 2021 19:02:10 GMT, Chris Plummer wrote: >Make sure you run the tests in test/hotspot/jtreg/serviceability/sa/ and >test/jdk/sun/tools/jhsdb/ Checked. All fine: == Test summary == TEST

Re: RFR: 8273684: Unnecessary Stack usage

2021-09-15 Thread Andrey Turbanov
On Tue, 14 Sep 2021 17:52:03 GMT, Chris Plummer wrote: >> Usage of thread-safe collection Stack is unnecessary. It's recommended to >> use ArrayDequeue if a thread-safe implementation is not needed. > > src/jdk.hotspot.agent/share/classes/sun/jvm/hotspot/CommandProcessor.java > line 988: > >>