8273921: Refactor NSK/JDI tests to create thread using factory
-
Commit messages:
- EventRequest
- ExceptionRequest
- ThreadStartRequest
- ThreadReference
- more tests
- EventRequestManager
- EventSet
- fix
- Event
- StepRequest
- ... and 12 more: https://git.openjdk.java.n
On Thu, 16 Sep 2021 16:11:44 GMT, Serguei Spitsyn wrote:
>> Lin Zang has updated the pull request with a new target base due to a merge
>> or a rebase. The pull request now contains ten commits:
>>
>> - Merge branch 'master' into hprof
>> - code clean up and refinement
>> - Merge branch 'mas
> This PR rewrite the implementation of the HeapHprofBinWriter, which could
> simplify the logic of current implementation.
> please see detail description at
> https://bugs.openjdk.java.net/browse/JDK-8269685.
Lin Zang has updated the pull request incrementally with one additional commit
since
On Sun, 29 Aug 2021 21:14:19 GMT, Andrey Turbanov
wrote:
> Usage of thread-safe collection Stack is unnecessary. It's recommended to use
> ArrayDequeue if a thread-safe implementation is not needed.
Marked as reviewed by serb (Reviewer).
-
PR: https://git.openjdk.java.net/jdk/pul
On Thu, 16 Sep 2021 15:44:46 GMT, Serguei Spitsyn wrote:
>> Lin Zang has updated the pull request with a new target base due to a merge
>> or a rebase. The pull request now contains ten commits:
>>
>> - Merge branch 'master' into hprof
>> - code clean up and refinement
>> - Merge branch 'mas
On Thu, 16 Sep 2021 15:58:24 GMT, Serguei Spitsyn wrote:
>> Lin Zang has updated the pull request with a new target base due to a merge
>> or a rebase. The pull request now contains ten commits:
>>
>> - Merge branch 'master' into hprof
>> - code clean up and refinement
>> - Merge branch 'mas
On Wed, 15 Sep 2021 23:22:43 GMT, Alex Menkov wrote:
> Updated the tests to skip events from unexpected threads.
This pull request has now been integrated.
Changeset: 8c022e2c
Author:Alex Menkov
URL:
https://git.openjdk.java.net/jdk/commit/8c022e2c174cca2b03e8fdf4fadad42bc11c65f1
St
Hi Volker,
Please note that non-trivial fixes should wait ~24hrs before integration
to ensure a range of folk have an opportunity to comment.
Thanks,
David
On 17/09/2021 5:59 am, Volker Simonis wrote:
On Thu, 16 Sep 2021 19:27:40 GMT, Coleen Phillimore wrote:
Currently, `OopHandle::releas
Trivial change to add an internal API that is useful when debugging. Only
included in debug builds, and has no impact on debug agent functionality.
-
Commit messages:
- Add threadControl_dumpThread()
Changes: https://git.openjdk.java.net/jdk/pull/5554/files
Webrev: https://webrevs
On Thu, 16 Sep 2021 14:36:02 GMT, Kevin Walls wrote:
>
>
> Looks good to me too.
>
> I struggled to verify the name "thread2" was correct for testThreadName, I
> think I found it in
> vmTestbase/nsk/jdi/EventIterator/nextEvent/nextevent001a.java: thread2 = new
> Thread3nextevent001a("thread
On Thu, 16 Sep 2021 16:08:39 GMT, Volker Simonis wrote:
> Currently, `OopHandle::release()` is implemented as follows:
>
> inline void OopHandle::release(OopStorage* storage) {
> if (peek() != NULL) {
> // Clear the OopHandle first
> NativeAccess<>::oop_store(_obj, (oop)NULL);
> st
On Thu, 16 Sep 2021 19:27:40 GMT, Coleen Phillimore wrote:
>> Currently, `OopHandle::release()` is implemented as follows:
>>
>> inline void OopHandle::release(OopStorage* storage) {
>> if (peek() != NULL) {
>> // Clear the OopHandle first
>> NativeAccess<>::oop_store(_obj, (oop)NULL);
On Thu, 16 Sep 2021 16:08:39 GMT, Volker Simonis wrote:
> Currently, `OopHandle::release()` is implemented as follows:
>
> inline void OopHandle::release(OopStorage* storage) {
> if (peek() != NULL) {
> // Clear the OopHandle first
> NativeAccess<>::oop_store(_obj, (oop)NULL);
> st
On Thu, 1 Jul 2021 12:19:53 GMT, Сергей Цыпанов
wrote:
>> In some JDK classes there's still the following hashCode() implementation:
>>
>> long objNum;
>>
>> public int hashCode() {
>> return (int) objNum;
>> }
>>
>> This outdated expression should be replaced with Long.hashCode(long) as
On Thu, 16 Sep 2021 16:08:39 GMT, Volker Simonis wrote:
> Currently, `OopHandle::release()` is implemented as follows:
>
> inline void OopHandle::release(OopStorage* storage) {
> if (peek() != NULL) {
> // Clear the OopHandle first
> NativeAccess<>::oop_store(_obj, (oop)NULL);
> st
Currently, `OopHandle::release()` is implemented as follows:
inline void OopHandle::release(OopStorage* storage) {
if (peek() != NULL) {
// Clear the OopHandle first
NativeAccess<>::oop_store(_obj, (oop)NULL);
storage->release(_obj);
}
}
However, peek() returns NULL not only if th
On Thu, 16 Sep 2021 12:26:10 GMT, Lin Zang wrote:
>> This PR rewrite the implementation of the HeapHprofBinWriter, which could
>> simplify the logic of current implementation.
>> please see detail description at
>> https://bugs.openjdk.java.net/browse/JDK-8269685.
>
> Lin Zang has updated the p
On Thu, 16 Sep 2021 12:26:10 GMT, Lin Zang wrote:
>> This PR rewrite the implementation of the HeapHprofBinWriter, which could
>> simplify the logic of current implementation.
>> please see detail description at
>> https://bugs.openjdk.java.net/browse/JDK-8269685.
>
> Lin Zang has updated the p
On Thu, 16 Sep 2021 12:26:10 GMT, Lin Zang wrote:
>> This PR rewrite the implementation of the HeapHprofBinWriter, which could
>> simplify the logic of current implementation.
>> please see detail description at
>> https://bugs.openjdk.java.net/browse/JDK-8269685.
>
> Lin Zang has updated the p
On Thu, 16 Sep 2021 12:26:10 GMT, Lin Zang wrote:
>> This PR rewrite the implementation of the HeapHprofBinWriter, which could
>> simplify the logic of current implementation.
>> please see detail description at
>> https://bugs.openjdk.java.net/browse/JDK-8269685.
>
> Lin Zang has updated the p
On Thu, 16 Sep 2021 12:26:10 GMT, Lin Zang wrote:
>> This PR rewrite the implementation of the HeapHprofBinWriter, which could
>> simplify the logic of current implementation.
>> please see detail description at
>> https://bugs.openjdk.java.net/browse/JDK-8269685.
>
> Lin Zang has updated the p
On Wed, 15 Sep 2021 23:22:43 GMT, Alex Menkov wrote:
> Updated the tests to skip events from unexpected threads.
Marked as reviewed by kevinw (Committer).
Looks good to me too.
I struggled to verify the name "thread2" was correct for testThreadName, I
think I found it in
vmTestbase/nsk/jdi/E
> This PR rewrite the implementation of the HeapHprofBinWriter, which could
> simplify the logic of current implementation.
> please see detail description at
> https://bugs.openjdk.java.net/browse/JDK-8269685.
Lin Zang has updated the pull request with a new target base due to a merge or
a reb
On Wed, 8 Sep 2021 05:02:18 GMT, Ralf Schmelter wrote:
>> Lin Zang has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> fix build error
>
> I will start reviewing this today.
Hi Ralf @schmelter-sap,
I have updated the PR, would you lik
> 8252842: Extend jmap to support parallel heap dump
Lin Zang has refreshed the contents of this pull request, and previous commits
have been removed. The incremental views will show differences compared to the
previous content of the PR. The pull request contains one new commit since the
last
On Wed, 15 Sep 2021 23:22:43 GMT, Alex Menkov wrote:
> Updated the tests to skip events from unexpected threads.
Hi Alex,
LGTM
Thanks,
Serguei
-
Marked as reviewed by sspitsyn (Reviewer).
PR: https://git.openjdk.java.net/jdk/pull/5538
26 matches
Mail list logo
