On Tue, 21 Sep 2021 04:27:58 GMT, Leonid Mesnik wrote:
>> 8273921: Refactor NSK/JDI tests to create thread using factory
>
> Leonid Mesnik has updated the pull request incrementally with one additional
> commit since the last revision:
>
> fixed line numbers after Idea autoimport.
I've revie
> 8273921: Refactor NSK/JDI tests to create thread using factory
Leonid Mesnik has updated the pull request incrementally with one additional
commit since the last revision:
fixed line numbers after Idea autoimport.
-
Changes:
- all: https://git.openjdk.java.net/jdk/pull/5515/f
> 8273921: Refactor NSK/JDI tests to create thread using factory
Leonid Mesnik has updated the pull request incrementally with one additional
commit since the last revision:
space fixed
-
Changes:
- all: https://git.openjdk.java.net/jdk/pull/5515/files
- new: https://git.open
On Fri, 17 Sep 2021 20:56:14 GMT, Chris Plummer wrote:
>> Leonid Mesnik has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> Renamed JDITask to NamedTask.
>
> test/hotspot/jtreg/vmTestbase/nsk/jdi/BreakpointRequest/addInstanceFilter/instancef
On Tue, 21 Sep 2021 03:13:15 GMT, Leonid Mesnik wrote:
>> 8273921: Refactor NSK/JDI tests to create thread using factory
>
> Leonid Mesnik has updated the pull request incrementally with one additional
> commit since the last revision:
>
> Renamed JDITask to NamedTask.
The tName was removed
> 8273921: Refactor NSK/JDI tests to create thread using factory
Leonid Mesnik has updated the pull request incrementally with one additional
commit since the last revision:
Renamed JDITask to NamedTask.
-
Changes:
- all: https://git.openjdk.java.net/jdk/pull/5515/files
- new
> 8273921: Refactor NSK/JDI tests to create thread using factory
Leonid Mesnik has updated the pull request incrementally with one additional
commit since the last revision:
More tests fixed.
-
Changes:
- all: https://git.openjdk.java.net/jdk/pull/5515/files
- new: https://gi
On Mon, 20 Sep 2021 20:16:03 GMT, Coleen Phillimore wrote:
>> Partition safepoint checking and nonchecking lock ranks. The nonchecking
>> locks are always lower ranked than the safepoint checking locks because they
>> cannot block.
>>
>> This moves some leaf locks to 'nosafepoint' rank and cor
On Mon, 20 Sep 2021 13:21:26 GMT, Coleen Phillimore wrote:
>> src/hotspot/share/gc/parallel/psCompactionManager.cpp line 95:
>>
>>> 93: _shadow_region_array = new (ResourceObj::C_HEAP, mtGC)
>>> GrowableArray(10, mtGC);
>>> 94:
>>> 95: _shadow_region_monitor = new Monitor(Mutex::nosafepoin
On Wed, 8 Sep 2021 05:02:18 GMT, Ralf Schmelter wrote:
>> Lin Zang has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> fix build error
>
> I will start reviewing this today.
Thanks @schmelter-sap and @plummercj for your help review and appr
On Tue, 14 Sep 2021 07:46:12 GMT, Andrey Turbanov
wrote:
>> Collections.sort is just a wrapper, so it is better to use an instance
>> method directly.
>
> Andrey Turbanov has updated the pull request incrementally with one
> additional commit since the last revision:
>
> 8272992: Replace us
On Mon, 20 Sep 2021 13:26:12 GMT, Coleen Phillimore wrote:
>> src/hotspot/share/runtime/mutexLocker.cpp line 253:
>>
>>> 251: def(ClassInitError_lock , PaddedMonitor, leaf+1, true,
>>> _safepoint_check_always);
>>> 252: def(Module_lock , PaddedMutex , leaf+2
On Mon, 20 Sep 2021 22:54:19 GMT, Coleen Phillimore wrote:
>> This change removes the special ranking and folds it into nosafepoint. You
>> have to look at commit #3 to see this actual part of the change that doesn't
>> include JDK-8273915.
>> This passes tier1-6 also.
>
> Coleen Phillimore ha
On Mon, 20 Sep 2021 22:08:19 GMT, Chris Plummer wrote:
>> I've gotten through about 1/3 of the test plus the new files, so thought I'd
>> pass along my comments so far. Overall it looks good though.
>
>> I've gotten through about 1/3 of the test plus the new files, so thought I'd
>> pass along
> 8273921: Refactor NSK/JDI tests to create thread using factory
Leonid Mesnik has updated the pull request incrementally with one additional
commit since the last revision:
Removed some unused tName variables.
-
Changes:
- all: https://git.openjdk.java.net/jdk/pull/5515/files
On Mon, 20 Sep 2021 22:55:02 GMT, Leonid Mesnik wrote:
>> 8273921: Refactor NSK/JDI tests to create thread using factory
>
> Leonid Mesnik has updated the pull request incrementally with one additional
> commit since the last revision:
>
> Removed some unused tName variables.
test/hotspot/jt
> This change removes the special ranking and folds it into nosafepoint. You
> have to look at commit #3 to see this actual part of the change that doesn't
> include JDK-8273915.
> This passes tier1-6 also.
Coleen Phillimore has updated the pull request incrementally with one
additional commit
On Fri, 17 Sep 2021 11:50:22 GMT, Coleen Phillimore wrote:
> This change removes the special ranking and folds it into nosafepoint. You
> have to look at commit #3 to see this actual part of the change that doesn't
> include JDK-8273915.
> This passes tier1-6 also.
All the lock rankings are n
On Wed, 15 Sep 2021 00:34:08 GMT, Leonid Mesnik wrote:
> 8273921: Refactor NSK/JDI tests to create thread using factory
test/hotspot/jtreg/vmTestbase/nsk/jdi/StepRequest/addClassFilter_rt/filter_rt001a.java
line 169:
> 167: class Thread1filter_rt001a extends JDITask {
> 168:
> 169: privat
On Fri, 17 Sep 2021 11:50:22 GMT, Coleen Phillimore wrote:
> This change removes the special ranking and folds it into nosafepoint. You
> have to look at commit #3 to see this actual part of the change that doesn't
> include JDK-8273915.
> This passes tier1-6 also.
Sorry I don't follow. Lets
On Mon, 20 Sep 2021 20:16:03 GMT, Coleen Phillimore wrote:
>> Partition safepoint checking and nonchecking lock ranks. The nonchecking
>> locks are always lower ranked than the safepoint checking locks because they
>> cannot block.
>>
>> This moves some leaf locks to 'nosafepoint' rank and cor
On Sat, 18 Sep 2021 01:35:07 GMT, Chris Plummer wrote:
> I've gotten through about 1/3 of the test plus the new files, so thought I'd
> pass along my comments so far. Overall it looks good though.
I went through the rest of the files. No new issues, so just waiting for a
response to my previou
On Mon, 20 Sep 2021 20:16:03 GMT, Coleen Phillimore wrote:
>> Partition safepoint checking and nonchecking lock ranks. The nonchecking
>> locks are always lower ranked than the safepoint checking locks because they
>> cannot block.
>>
>> This moves some leaf locks to 'nosafepoint' rank and cor
On Wed, 15 Sep 2021 00:34:08 GMT, Leonid Mesnik wrote:
> 8273921: Refactor NSK/JDI tests to create thread using factory
Hi Leonid,
The refactoring looks great.
I also like that some unneeded constructors and fields go away.
Thanks,
Serguei
-
Marked as reviewed by sspitsyn (Reviewer
On Wed, 15 Sep 2021 00:34:08 GMT, Leonid Mesnik wrote:
> 8273921: Refactor NSK/JDI tests to create thread using factory
test/hotspot/jtreg/vmTestbase/nsk/jdi/ClassType/newInstance/newinstance001.java
line 54:
> 52: * A debugger launchs a debuggee which creates new thread, thread2.
> 53: * T
On Fri, 17 Sep 2021 20:07:13 GMT, Alex Menkov wrote:
> The changes fixes discovered issues with getEventSetForThreadStartDeath
> method and its callers:
> - getEventSetForThreadStartDeath must resume suspended thread(s), otherwise
> it can never get desired event;
> - callers should not call ad
> Partition safepoint checking and nonchecking lock ranks. The nonchecking
> locks are always lower ranked than the safepoint checking locks because they
> cannot block.
>
> This moves some leaf locks to 'nosafepoint' rank and corrects relative
> ranking.
>
> Tested with tier1-6 and built and
On Thu, 16 Sep 2021 21:20:00 GMT, Chris Plummer wrote:
> Trivial change to add an internal API that is useful when debugging. Only
> included in debug builds, and has no impact on debug agent functionality.
This pull request has now been integrated.
Changeset: 04891c95
Author:Chris Plummer
On Mon, 20 Sep 2021 13:35:29 GMT, Coleen Phillimore wrote:
>> Partition safepoint checking and nonchecking lock ranks. The nonchecking
>> locks are always lower ranked than the safepoint checking locks because they
>> cannot block.
>>
>> This moves some leaf locks to 'nosafepoint' rank and cor
On Mon, 20 Sep 2021 18:15:44 GMT, Ioi Lam wrote:
>> Coleen Phillimore has updated the pull request incrementally with one
>> additional commit since the last revision:
>>
>> Remove 'safepoint' rank, now unused.
>
> src/hotspot/share/runtime/mutex.hpp line 53:
>
>> 51:special=
On Fri, 17 Sep 2021 11:50:22 GMT, Coleen Phillimore wrote:
> This change removes the special ranking and folds it into nosafepoint. You
> have to look at commit #3 to see this actual part of the change that doesn't
> include JDK-8273915.
> This passes tier1-6 also.
Thanks for looking at this,
On Mon, 20 Sep 2021 13:35:29 GMT, Coleen Phillimore wrote:
>> Partition safepoint checking and nonchecking lock ranks. The nonchecking
>> locks are always lower ranked than the safepoint checking locks because they
>> cannot block.
>>
>> This moves some leaf locks to 'nosafepoint' rank and cor
On Thu, 16 Sep 2021 09:35:20 GMT, Lin Zang wrote:
>> 8252842: Extend jmap to support parallel heap dump
>
> Lin Zang has refreshed the contents of this pull request, and previous
> commits have been removed. The incremental views will show differences
> compared to the previous content of the P
On Thu, 16 Sep 2021 01:08:45 GMT, Naoto Sato wrote:
> Fixing failing regression tests caused by the JEP 400: UTF-8 by Default.
>
> `JcmdOutputEncodingTest` test case uses `file.encoding=UTF-8` in `C` locale.
> The output from the agent library is in `UTF-8` so it succeeded before the
> JEP has
> Partition safepoint checking and nonchecking lock ranks. The nonchecking
> locks are always lower ranked than the safepoint checking locks because they
> cannot block.
>
> This moves some leaf locks to 'nosafepoint' rank and corrects relative
> ranking.
>
> Tested with tier1-6 and built and
On Mon, 20 Sep 2021 00:08:11 GMT, David Holmes wrote:
>> Partition safepoint checking and nonchecking lock ranks. The nonchecking
>> locks are always lower ranked than the safepoint checking locks because they
>> cannot block.
>>
>> This moves some leaf locks to 'nosafepoint' rank and corrects
On Thu, 16 Sep 2021 17:11:30 GMT, Coleen Phillimore wrote:
> Partition safepoint checking and nonchecking lock ranks. The nonchecking
> locks are always lower ranked than the safepoint checking locks because they
> cannot block.
>
> This moves some leaf locks to 'nosafepoint' rank and corrects
On Fri, 17 Sep 2021 20:07:13 GMT, Alex Menkov wrote:
> The changes fixes discovered issues with getEventSetForThreadStartDeath
> method and its callers:
> - getEventSetForThreadStartDeath must resume suspended thread(s), otherwise
> it can never get desired event;
> - callers should not call ad
38 matches
Mail list logo
