On Sat, 25 Sep 2021 05:19:24 GMT, Daniel D. Daugherty
wrote:
>> A trivial fix to ProblemList 2 serviceability/dcmd/gc tests with ZGC on
>> macOS-all.
>
> Daniel D. Daugherty has updated the pull request incrementally with one
> additional commit since the last revision:
>
> 8274313: Problem
On Sat, 25 Sep 2021 05:19:24 GMT, Daniel D. Daugherty
wrote:
>> A trivial fix to ProblemList 2 serviceability/dcmd/gc tests with ZGC on
>> macOS-all.
>
> Daniel D. Daugherty has updated the pull request incrementally with one
> additional commit since the last revision:
>
> 8274313: Problem
> A trivial fix to ProblemList 2 serviceability/dcmd/gc tests with ZGC on
> macOS-all.
Daniel D. Daugherty has updated the pull request incrementally with one
additional commit since the last revision:
8274313: ProblemList sun/tools/jmap/BasicJMapTest.java subtests
-
Changes:
A trivial fix to ProblemList 2 serviceability/dcmd/gc tests with ZGC on
macOS-all.
-
Commit messages:
- 8274312: ProblemList 2 serviceability/dcmd/gc tests with ZGC on macos-all
Changes: https://git.openjdk.java.net/jdk/pull/5691/files
Webrev: https://webrevs.openjdk.java.net/?rep
On Fri, 24 Sep 2021 09:27:02 GMT, Markus Grönlund wrote:
>> Greetings,
>>
>> Object.finalize() was deprecated in JDK9. There is an ongoing effort to
>> replace and mitigate Object.finalize() uses in the JDK libraries; please see
>> https://bugs.openjdk.java.net/browse/JDK-8253568 for more info
On Thu, 23 Sep 2021 20:36:07 GMT, Alex Menkov wrote:
> The fix executes "use" jdb command after class redifinition to improve test
> logs (print correct source line)
This pull request has now been integrated.
Changeset: 61ac53f6
Author:Alex Menkov
URL:
https://git.openjdk.java.net/
On Fri, 24 Sep 2021 16:44:13 GMT, Lin Zang wrote:
>> This PR rewrite the implementation of the HeapHprofBinWriter, which could
>> simplify the logic of current implementation.
>> please see detail description at
>> https://bugs.openjdk.java.net/browse/JDK-8269685.
>
> Lin Zang has updated the p
On Fri, 24 Sep 2021 16:44:13 GMT, Lin Zang wrote:
>> This PR rewrite the implementation of the HeapHprofBinWriter, which could
>> simplify the logic of current implementation.
>> please see detail description at
>> https://bugs.openjdk.java.net/browse/JDK-8269685.
>
> Lin Zang has updated the p
On Fri, 24 Sep 2021 13:13:39 GMT, Lin Zang wrote:
> The root cause for crash in ZGC is that the JNIHandles are processed before
> object iteration. And ZGC would update the JNIHandles at object iteration
> with read barrier. So the crash is cause by accessing the invalid address
> which can be
On Fri, 24 Sep 2021 15:05:33 GMT, Lin Zang wrote:
>> yes
>> void Mutex::check_no_safepoint_state(Thread* thread) {
>>check_block_state(thread);
>>assert(!thread->is_active_Java_thread() || _safepoint_check_required
>> != _safepoint_check_always,
>> "This lock sh
> This PR rewrite the implementation of the HeapHprofBinWriter, which could
> simplify the logic of current implementation.
> please see detail description at
> https://bugs.openjdk.java.net/browse/JDK-8269685.
Lin Zang has updated the pull request with a new target base due to a merge or
a reb
On Fri, 24 Sep 2021 15:34:18 GMT, Daniel D. Daugherty
wrote:
> A trivial fix to ProblemList sun/tools/jmap/BasicJMapTest.java.
Marked as reviewed by rriggs (Reviewer).
-
PR: https://git.openjdk.java.net/jdk/pull/5685
On Fri, 24 Sep 2021 15:37:13 GMT, Roger Riggs wrote:
>> A trivial fix to ProblemList sun/tools/jmap/BasicJMapTest.java.
>
> Marked as reviewed by rriggs (Reviewer).
@RogerRiggs - Thanks for the fast review!
-
PR: https://git.openjdk.java.net/jdk/pull/5685
A trivial fix to ProblemList sun/tools/jmap/BasicJMapTest.java.
-
Commit messages:
- 8274294: ProblemList sun/tools/jmap/BasicJMapTest.java
Changes: https://git.openjdk.java.net/jdk/pull/5685/files
Webrev: https://webrevs.openjdk.java.net/?repo=jdk&pr=5685&range=00
Issue: https:/
On Fri, 24 Sep 2021 15:34:18 GMT, Daniel D. Daugherty
wrote:
> A trivial fix to ProblemList sun/tools/jmap/BasicJMapTest.java.
This pull request has now been integrated.
Changeset: 0c050be6
Author:Daniel D. Daugherty
URL:
https://git.openjdk.java.net/jdk/commit/0c050be64b7db297126c
On Fri, 24 Sep 2021 13:13:39 GMT, Lin Zang wrote:
> The root cause for crash in ZGC is that the JNIHandles are processed before
> object iteration. And ZGC would update the JNIHandles at object iteration
> with read barrier. So the crash is cause by accessing the invalid address
> which can be
On Fri, 24 Sep 2021 15:01:26 GMT, Coleen Phillimore wrote:
>> I agree the flag here and at the place of lock acquiring seems problematic.
>> I will try to see whether I can use `Mutex::_safepoint_check_never` here and
>> get rid of the assert.
>
> yes
> void Mutex::check_no_safepoint_state
On Fri, 24 Sep 2021 14:05:48 GMT, Lin Zang wrote:
>> I think it may be because this is actually not a JavaThread. So the assert
>> in `Mutex::check_no_safepoint_state` would pass.
>> Moreover, I have tried to use `PaddedMonitor(Mutex::nosafepoint,
>> "ParallelHProfWriter_lock", Mutex::_safepoi
On Fri, 24 Sep 2021 13:46:13 GMT, Lin Zang wrote:
>> src/hotspot/share/services/heapDumper.cpp line 751:
>>
>>> 749: static void before_work() {
>>> 750: assert(_lock == NULL, "ParDumpWriter lock must be initialized only
>>> once");
>>> 751: _lock = new (std::nothrow) PaddedMonitor(Mu
On Fri, 24 Sep 2021 13:37:44 GMT, Coleen Phillimore wrote:
>> The root cause for crash in ZGC is that the JNIHandles are processed before
>> object iteration. And ZGC would update the JNIHandles at object iteration
>> with read barrier. So the crash is cause by accessing the invalid address
>>
On Fri, 24 Sep 2021 13:13:39 GMT, Lin Zang wrote:
> The root cause for crash in ZGC is that the JNIHandles are processed before
> object iteration. And ZGC would update the JNIHandles at object iteration
> with read barrier. So the crash is cause by accessing the invalid address
> which can be
On Thu, 23 Sep 2021 22:35:26 GMT, Coleen Phillimore wrote:
>> Markus Grönlund has updated the pull request incrementally with two
>> additional commits since the last revision:
>>
>> - remove rehashing and rely on default grow_hint for table resize
>> - mtStatistics
>
> src/hotspot/share/jfr/
> Greetings,
>
> Object.finalize() was deprecated in JDK9. There is an ongoing effort to
> replace and mitigate Object.finalize() uses in the JDK libraries; please see
> https://bugs.openjdk.java.net/browse/JDK-8253568 for more information.
>
> We also like to assist users in replacing and mit
On Fri, 24 Sep 2021 08:45:54 GMT, Serguei Spitsyn wrote:
>> There are few places in code where manual `for` loop is used with Iterator
>> to iterate over Collection or Array.
>> Instead of manual `for` cycles it's preferred to use enhanced-for cycle
>> instead: it's less verbose, makes code eas
On Wed, 8 Sep 2021 12:57:18 GMT, Leo Korinth wrote:
>> Hmm, u8 was not what I was thinking, I will change that to a uint8_t in the
>> next update...
>
> I hit the new assert when not on Linux, I guess it has to do with the
> initialization of the thread local variable.
Thanks Ioi for making me
On Fri, 24 Sep 2021 07:30:02 GMT, Andrey Turbanov
wrote:
> There are few places in code where manual `for` loop is used with Iterator to
> iterate over Collection or Array.
> Instead of manual `for` cycles it's preferred to use enhanced-for cycle
> instead: it's less verbose, makes code easier
There are few places in code where manual `for` loop is used with Iterator to
iterate over Collection or Array.
Instead of manual `for` cycles it's preferred to use enhanced-for cycle
instead: it's less verbose, makes code easier to read and it's less error-prone.
It doesn't have any performance
> In several places, String.compareTo was _compared_ with 0 ( via `== 0` or `!=
> 0`).
> Instead of this, we can use String.equals calls. `String.equals` is faster
> and shorter.
Andrey Turbanov has updated the pull request incrementally with one additional
commit since the last revision:
82
28 matches
Mail list logo
