Re: RFR: 8218885: Restore pop_frame and force_early_return functionality for Graal

2021-09-30 Thread Doug Simon
On Wed, 22 Sep 2021 05:40:40 GMT, Tom Rodriguez wrote: > This logic no longer seems to be necessary since the adjustCompilationLevel > callback has been removed. I sent instructions via email since it requires using internal resources. - PR: https://git.openjdk.java.net/jdk/pull/5

Integrated: 8274506: TestPids.java and TestPidsLimit.java fail with podman run as root

2021-09-30 Thread Severin Gehwolf
On Wed, 29 Sep 2021 12:51:00 GMT, Severin Gehwolf wrote: > Please review this test fix to work around a podman issue[1]. `podman` > expects for the "unlimited" option of `--pids-limit` to be `0` whereas > `docker` wants `-1`. See the JBS bug for details. Thoughts? > > Testing: hotspot/jdk cont

Re: RFR: 8274395: Use enhanced-for instead of plain 'for' in jdk.internal.jvmstat [v2]

2021-09-30 Thread Serguei Spitsyn
On Tue, 28 Sep 2021 07:32:47 GMT, Andrey Turbanov wrote: >> There are few places in code where manual `for` loop is used with Iterator >> to iterate over Collection or Array. >> Instead of manual `for` cycles it's preferred to use enhanced-for cycle >> instead: it's less verbose, makes code ea

Re: RFR: 8274318: Replace 'for' cycles with iterator with enhanced-for in java.management

2021-09-30 Thread Serguei Spitsyn
On Sat, 25 Sep 2021 10:51:12 GMT, Andrey Turbanov wrote: > There are a few places in code, where manual `for` loop is used with Iterator > to iterate over Collection. > Instead of manual `for` cycles, it's preferred to use enhanced-for cycle > instead: it's less verbose, makes code easier to r

Re: RFR: 8274398: Suppress more warnings on non-serializable non-transient instance fields in management libs

2021-09-30 Thread Serguei Spitsyn
On Mon, 27 Sep 2021 21:49:06 GMT, Joe Darcy wrote: > Follow-up change to JDK-8232442, augmentations to javac's Xlint:serial > checking are out for review (#5709) and various management libraries would > need some changes to pass under the expanded checks. > > The changes are to suppress warnin

Re: RFR: 8253197: vmTestbase/nsk/jvmti/StopThread/stopthrd007/TestDescription.java fails with "ERROR: DebuggeeSleepingThread: ThreadDeath lost"

2021-09-30 Thread Serguei Spitsyn
On Tue, 28 Sep 2021 22:07:38 GMT, Patricio Chilano Mateo wrote: > Hi, > > Please review this simple fix. As pointed out by @dholmes-ora in the bug > comments, the ThreadDeath exception could be delivered and thrown while the > target JavaThread is still executing within the Wicket.unlock call

RFR: 8273152: Refactor CDS FileMapHeader loading code

2021-09-30 Thread Yumin Qi
Please review, Refactor fundamental CDS FileMapHeader code for reliable reading of basic info from shared archive. With the change, it makes it possible to read an archive generated by different version of hotspot. Also it is possible to automatically generate a CDS archive If the archive su

Re: RFR: 8274196: Crashes in VM_HeapDumper::work after JDK-8252842 [v5]

2021-09-30 Thread Lin Zang
On Mon, 27 Sep 2021 14:28:43 GMT, Lin Zang wrote: >> The root cause for crash in ZGC is that the JNIHandles are processed before >> object iteration. And ZGC would update the JNIHandles at object iteration >> with read barrier. So the crash is cause by accessing the invalid address >> which ca

Integrated: 8274196: Crashes in VM_HeapDumper::work after JDK-8252842

2021-09-30 Thread Lin Zang
On Fri, 24 Sep 2021 13:13:39 GMT, Lin Zang wrote: > The root cause for crash in ZGC is that the JNIHandles are processed before > object iteration. And ZGC would update the JNIHandles at object iteration > with read barrier. So the crash is cause by accessing the invalid address > which can be

Re: RFR: 8253197: vmTestbase/nsk/jvmti/StopThread/stopthrd007/TestDescription.java fails with "ERROR: DebuggeeSleepingThread: ThreadDeath lost"

2021-09-30 Thread Patricio Chilano Mateo
On Wed, 29 Sep 2021 18:35:27 GMT, Chris Plummer wrote: >> Hi, >> >> Please review this simple fix. As pointed out by @dholmes-ora in the bug >> comments, the ThreadDeath exception could be delivered and thrown while the >> target JavaThread is still executing within the Wicket.unlock call. To

Integrated: 8253197: vmTestbase/nsk/jvmti/StopThread/stopthrd007/TestDescription.java fails with "ERROR: DebuggeeSleepingThread: ThreadDeath lost"

2021-09-30 Thread Patricio Chilano Mateo
On Tue, 28 Sep 2021 22:07:38 GMT, Patricio Chilano Mateo wrote: > Hi, > > Please review this simple fix. As pointed out by @dholmes-ora in the bug > comments, the ThreadDeath exception could be delivered and thrown while the > target JavaThread is still executing within the Wicket.unlock call

Re: RFR: 8273152: Refactor CDS FileMapHeader loading code [v2]

2021-09-30 Thread Yumin Qi
> Please review, > Refactor fundamental CDS FileMapHeader code for reliable reading of basic > info from shared archive. > With the change, it makes it possible to read an archive generated by > different version of hotspot. Also it is possible to automatically generate a > CDS archive If th

Re: RFR: 8274398: Suppress more warnings on non-serializable non-transient instance fields in management libs

2021-09-30 Thread Joe Darcy
On Thu, 30 Sep 2021 09:56:45 GMT, Serguei Spitsyn wrote: > > > Looks good. Thanks, Serguei Thanks Serguei, I'll add some explanatory comments and check for any needed copyright updates before pushing. - PR: https://git.openjdk.java.net/jdk/pull/5726

Re: RFR: 8274398: Suppress more warnings on non-serializable non-transient instance fields in management libs [v2]

2021-09-30 Thread Joe Darcy
> Follow-up change to JDK-8232442, augmentations to javac's Xlint:serial > checking are out for review (#5709) and various management libraries would > need some changes to pass under the expanded checks. > > The changes are to suppress warnings where non-transient fields in > serializable type

Integrated: 8274398: Suppress more warnings on non-serializable non-transient instance fields in management libs

2021-09-30 Thread Joe Darcy
On Mon, 27 Sep 2021 21:49:06 GMT, Joe Darcy wrote: > Follow-up change to JDK-8232442, augmentations to javac's Xlint:serial > checking are out for review (#5709) and various management libraries would > need some changes to pass under the expanded checks. > > The changes are to suppress warnin

Re: RFR: 8271356: Modify jdb to treat an empty command as a repeat of the previous command [v5]

2021-09-30 Thread Jakob Cornell
On Thu, 23 Sep 2021 15:24:47 GMT, Jakob Cornell wrote: >> This has been under discussion on and off for the past month or so on >> serviceability-dev, and I think a CSR request is required, so this may be a >> work in progress. >> >> Notes on the patch: >> >> - The `list` command previously

Re: RFR: 8271356: Modify jdb to treat an empty command as a repeat of the previous command [v5]

2021-09-30 Thread Chris Plummer
On Thu, 30 Sep 2021 19:11:33 GMT, Jakob Cornell wrote: > Hey Chris, is there any update on this? I've revised the Problem section so I > think we're waiting on the CSR ticket to be updated accordingly and for > someone to be assigned for the CSR review. Ok. I updated the CSR with your changes